Skip to content

add cron mode & retryUpdateCronHpaStatus#112

Open
LivingCcj wants to merge 2 commits into
AliyunContainerService:masterfrom
LivingCcj:feature/add_cron_mode
Open

add cron mode & retryUpdateCronHpaStatus#112
LivingCcj wants to merge 2 commits into
AliyunContainerService:masterfrom
LivingCcj:feature/add_cron_mode

Conversation

@LivingCcj

Copy link
Copy Markdown

add cron mode & retryUpdateCronHpaStatus

@ringtail

ringtail commented Sep 1, 2022

Copy link
Copy Markdown
Member

Could you explain what is cron mode.

@LivingCcj

Copy link
Copy Markdown
Author

cronMode : controller cron job work or not work.
Enable: means cron job is work normal.
Disable: means cron job is not work (set cron mode when upgrade service or stop cronhpa but not delete it).

@ringtail

ringtail commented Sep 8, 2022

Copy link
Copy Markdown
Member

cronMode : controller cron job work or not work. Enable: means cron job is work normal. Disable: means cron job is not work (set cron mode when upgrade service or stop cronhpa but not delete it).

What's is the scene?

@LivingCcj

Copy link
Copy Markdown
Author

base scene : cronhpa -> deployment
when you upgrade deployment, the cronhpa will attack the upgrade operation, so it should skip this cron job.
meanwhile cronhpa -> hpa -> deployment

@ringtail

ringtail commented Sep 9, 2022

Copy link
Copy Markdown
Member

when you upgrade deployment, the cronhpa will attack the upgrade operation, so it should skip this cron job.

Do you mean cronhpa is in a very tiny duration?

@LivingCcj

Copy link
Copy Markdown
Author

when you upgrade deployment, the cronhpa will attack the upgrade operation, so it should skip this cron job.

Do you mean cronhpa is in a very tiny duration?

if deployment type is Rolling update,cron job will disturb the procedure of rolling. there would take some risk

@ringtail

Copy link
Copy Markdown
Member

Would skip this time and retry later be better for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants