Julia 1.12 compatibility: Explicit imports for local module types#111
Open
SimonAB wants to merge 2 commits into
Open
Julia 1.12 compatibility: Explicit imports for local module types#111SimonAB wants to merge 2 commits into
SimonAB wants to merge 2 commits into
Conversation
- Add explicit imports for Decapode, SummationDecapode from decapodeacset - Add explicit imports for Judgement, Term, Equation from decapodes - Qualify all constructor extensions and calls - Resolves multiple deprecation warnings - Compatible with Julia 1.12+
There was a problem hiding this comment.
Pull request overview
This PR adds explicit imports and qualified names for types and constructors from local modules to ensure Julia 1.12 compatibility. Julia 1.12 introduced stricter requirements for extending constructors from other modules, requiring either explicit imports or fully qualified names.
Key changes:
- Added explicit imports for
Judgement,Term,Equation, andEqfrom thedecapodesmodule - Added explicit imports for
DecapodeandSummationDecapodefrom thedecapodeacsetmodule - Qualified all constructor calls and type annotations in pattern matching with module prefixes (e.g.,
decapodes.Judgement,decapodes.Eq)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/DiagrammaticEquations.jl | Adds import statement for Decapode and SummationDecapode constructors from decapodeacset module with explanatory comment about include order |
| src/language.jl | Adds explicit imports from decapodes module and qualifies all constructor calls, type annotations, and pattern matches with decapodes. or decapodeacset. prefixes |
| src/colanguage.jl | Qualifies all constructor calls with decapodes. prefix and extends decapodes.Term using qualified function definition syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SimonAB
added a commit
to SimonAB/DiagrammaticEquations.jl
that referenced
this pull request
Jan 8, 2026
- Update colanguage.jl comment to mention @intertypes macro - Update language.jl comment to clarify Eq is a constructor variant of Equation sum type - Both comments now accurately reflect the code structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds explicit imports for types and constructors from the local
decapodesmodule to resolve Julia 1.12 deprecation warnings about extending constructors without explicit qualification or import.Changes:
import .decapodes: Judgement, Term, Equation, Eqdecapodes.prefixMotivation
Julia 1.12 requires explicit imports when extending constructors. This change silences deprecation warnings and ensures compatibility with Julia 1.12+.
Testing
Type of change
Checklist
Note: This is a compatibility fix that doesn't require documentation changes or new tests.