fix(ui): resolve accessibility, performance and theming audit findings#11
Merged
Conversation
- contact: add a scrim + centered radial vignette so white text keeps AA/AAA contrast over the background image - hero: mount the heavy skills graph (React Flow + d3-force) only on md+ viewports via a media-query wrapper, skipping the simulation on mobile - graph: tokenize edge colors with color-mix(var(--muted-foreground)) - button: enlarge touch targets to 44px on coarse pointers only, keeping the dense desktop scale intact - projects: clamp card tags to a single line with a "+N" overflow badge measured by a new useOneLineFit hook; keep all tags in an sr-only list - projects: add priority to the detail page LCP image and enlarge the back button touch target - about: add an sr-only h2 so the section appears in the document outline - mobile-nav: add a localized SheetDescription to satisfy Radix dialog a11y - styles: drop unused gradient utilities and the orphaned --gradient-vite
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
Audit UI complet (a11y, perf, theming, responsive, anti-patterns) puis correction de tous les findings P1→P3.
Changements
md+via un wrapper media-query ; plus de simulation d3 sur mobile.color-mix(var(--muted-foreground))).pointer-coarse), le barème dense desktop est conservé.+N(nouveau hookuseOneLineFit) ; tous les tags restent dans une listesr-only.prioritysur l''image LCP de la page détail + cible tactile du bouton retour.h2sr-onlypour figurer dans le plan du document.SheetDescriptionlocalisée (a11y dialog Radix).--gradient-vite.Vérification
pnpm build✅ (29 pages)pnpm test✅ 7/7pnpm test:e2e✅ 9/9pnpm lint/pnpm typecheck✅