Partner application form: required fields, skills rework, fail-fast validation (#21710)

## Summary (twenty-website — partner application form)

- **Required fields**: website URL, city, hourly rate, minimum project
are now required (client step-gate + server zod) with `*` markers. The
final step validates before POSTing, so empty required fields fail fast
client-side instead of round-tripping.
- **Technical skills reworked to *complement* "What you cover"** (the
service categories) rather than duplicate them — now a small shown set +
a larger searchable-only pool of tools / technologies / industries.
Field hint clarifies the intent.
- **No competitor CRMs** in suggestions (Salesforce/HubSpot/Attio
removed); a guard test fails if one ever reappears. Migrations surface
as a generic "CRM migration".
- `Form.TagInput` gains an optional `searchPool` prop (autocomplete-only
entries, not rendered as chips).

Companion to the app-side PR #21709.

<!-- This is an auto-generated description by cubic. -->
<a
href="https://cubic.dev/pr/twentyhq/twenty/pull/21710?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->

Author: rashad

packages/twenty-website/package.json

@@ -48,6 +48,9 @@
     "@opennextjs/cloudflare": "^1.0.0",
     "@swc/core": "^1.15.11",
     "@swc/jest": "^0.2.39",
+    "@testing-library/jest-dom": "^6.6.3",
+    "@testing-library/react": "^16.3.0",
+    "@testing-library/user-event": "^14.6.1",
     "@types/jest": "^30.0.0",
     "@types/node": "^20",
     "@types/react": "^19.2.0",
@@ -56,6 +59,7 @@
     "@types/three": "^0.183.1",
     "babel-plugin-react-compiler": "1.0.0",
     "jest": "29.7.0",
+    "jest-environment-jsdom": "30.0.0-beta.3",
     "jest-environment-node": "^29.4.1",
     "ts-jest": "^29.1.1",
     "wrangler": "^4.0.0"

packages/twenty-website/src/app/api/partner-application/__tests__/partner-application-schema.test.ts

@@ -7,6 +7,10 @@ const minimalValid = {
   name: 'Ada Lovelace',
   email: 'ada@example.com',
   company: 'Analytical Engines Ltd',
+  website: 'https://analyticalengines.example',
+  city: 'London',
+  hourlyRate: 150,
+  projectBudgetMin: 5000,
 };
 
 const fullValid = {
@@ -108,7 +112,6 @@ describe('buildLogicFunctionPayload', () => {
     expect('country' in payload).toBe(false);
     expect('languages' in payload).toBe(false);
     expect('partnerScope' in payload).toBe(false);
-    expect('domainName' in payload).toBe(false);
   });
 
   it('forwards website as domainName when provided', () => {

packages/twenty-website/src/app/api/partner-application/__tests__/route.test.ts

@@ -7,6 +7,9 @@ const VALID_PAYLOAD = {
   name: 'Ada Lovelace',
   company: 'Analytical Engines',
   website: 'https://analytical.example/',
+  city: 'London',
+  hourlyRate: 150,
+  projectBudgetMin: 5000,
 };
 
 const VALID_BODY = JSON.stringify(VALID_PAYLOAD);
@@ -168,6 +171,9 @@ describe('POST /api/partner-application', () => {
       lastName: 'Lovelace',
       companyName: 'Analytical Engines',
       domainName: 'https://analytical.example/',
+      city: 'London',
+      hourlyRate: 150,
+      projectBudgetMin: 5000,
     });
     expect(init.signal).toBeInstanceOf(AbortSignal);
   });

packages/twenty-website/src/design-system/components/Form/TagInput.tsx

@@ -136,6 +136,7 @@ type FormTagInputProps = {
   placeholder?: string;
   ariaLabel?: string;
   suggestions?: ReadonlyArray<string>;
+  searchPool?: ReadonlyArray<string>;
 };
 
 export function FormTagInput({
@@ -144,14 +145,20 @@ export function FormTagInput({
   placeholder,
   ariaLabel,
   suggestions,
+  searchPool,
 }: FormTagInputProps) {
   const [draft, setDraft] = useState('');
   const [activeIndex, setActiveIndex] = useState(-1);
   const listId = useId();
 
-  const menuMatches =
+  const searchableSuggestions =
     suggestions !== undefined
-      ? filterSkillSuggestions(suggestions, values, draft)
+      ? [...suggestions, ...(searchPool ?? [])]
+      : undefined;
+
+  const menuMatches =
+    searchableSuggestions !== undefined
+      ? filterSkillSuggestions(searchableSuggestions, values, draft)
       : [];
   const menuOpen = menuMatches.length > 0;
 

packages/twenty-website/src/design-system/components/Form/__tests__/TagInput.test.tsx

@@ -0,0 +1,40 @@
+/**
+ * @jest-environment jsdom
+ */
+import '@testing-library/jest-dom';
+import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { useState } from 'react';
+
+import { FormTagInput } from '@/design-system/components/Form/TagInput';
+
+function Harness() {
+  const [values, setValues] = useState<string[]>([]);
+  return (
+    <FormTagInput
+      values={values}
+      onValuesChange={setValues}
+      ariaLabel="skills"
+      suggestions={['Workflows']}
+      searchPool={['Kubernetes']}
+    />
+  );
+}
+
+describe('FormTagInput searchPool', () => {
+  it('shows only `suggestions` as ghost chips, not the pool', () => {
+    render(<Harness />);
+    expect(
+      screen.getByRole('button', { name: '+ Workflows' }),
+    ).toBeInTheDocument();
+    expect(screen.queryByRole('button', { name: '+ Kubernetes' })).toBeNull();
+  });
+
+  it('autocompletes against the pool', async () => {
+    render(<Harness />);
+    await userEvent.type(screen.getByRole('combobox'), 'kuber');
+    expect(
+      screen.getByRole('option', { name: 'Kubernetes' }),
+    ).toBeInTheDocument();
+  });
+});

packages/twenty-website/src/sections/PartnerApplication/__tests__/partner-application-field-schemas.test.ts

@@ -0,0 +1,52 @@
+import {
+  nonNegativeAmountStringSchema,
+  partnerApplicationRequestSchema,
+} from '@/sections/PartnerApplication/partner-application-field-schemas';
+
+const validBody: Record<string, unknown> = {
+  name: 'Acme',
+  email: 'a@acme.com',
+  company: 'Acme Inc',
+  website: 'https://acme.com',
+  city: 'Paris',
+  country: 'FRANCE',
+  partnerScope: ['DEVELOPMENT'],
+  hourlyRate: 120,
+  projectBudgetMin: 5000,
+};
+
+describe('partnerApplicationRequestSchema required fields', () => {
+  it('accepts a complete body', () => {
+    expect(partnerApplicationRequestSchema.safeParse(validBody).success).toBe(
+      true,
+    );
+  });
+
+  it.each(['website', 'city', 'hourlyRate', 'projectBudgetMin'])(
+    'rejects a body missing %s',
+    (field) => {
+      const { [field]: _omitted, ...rest } = validBody;
+      expect(partnerApplicationRequestSchema.safeParse(rest).success).toBe(
+        false,
+      );
+    },
+  );
+});
+
+describe('nonNegativeAmountStringSchema', () => {
+  it.each(['0', '120', '12.5', '.5', '12.', '  90  '])(
+    'accepts the valid amount %p',
+    (value) => {
+      expect(nonNegativeAmountStringSchema.safeParse(value).success).toBe(true);
+    },
+  );
+
+  it.each(['', '.', 'abc', '12abc', '-5', 'NaN', 'Infinity'])(
+    'rejects the invalid amount %p',
+    (value) => {
+      expect(nonNegativeAmountStringSchema.safeParse(value).success).toBe(
+        false,
+      );
+    },
+  );
+});

packages/twenty-website/src/sections/PartnerApplication/partner-application-field-schemas.ts

@@ -25,20 +25,36 @@ export const httpUrlFieldSchema = z
   .min(1)
   .pipe(z.httpUrl({ error: 'Invalid URL.' }));
 
+// Currency fields live in wizard state as strings, and the Form.Currency input
+// allows digits plus a single decimal separator — so a lone "." (or "") can
+// reach the reducer. Reject any non-empty value that doesn't represent a
+// finite, non-negative number, so the wizard fails fast on the commercials step
+// instead of submitting parseFloat(".") === NaN to the server.
+export const nonNegativeAmountStringSchema = z
+  .string()
+  .trim()
+  .min(1)
+  .refine(
+    (value) => {
+      const parsed = Number(value);
+      return Number.isFinite(parsed) && parsed >= 0;
+    },
+    { error: 'Enter a valid non-negative amount.' },
+  );
+
 const optionalNonEmptyString = z.string().trim().min(1).optional();
 const optionalUrl = httpUrlFieldSchema.optional();
-const optionalNonNegativeNumber = z.number().nonnegative().optional();
 
 export const partnerApplicationRequestSchema = z.strictObject({
   // Identity
   name: z.string().trim().min(1, { error: 'Name is required.' }),
   email: emailFieldSchema,
   company: z.string().trim().min(1, { error: 'Company is required.' }),
-  website: optionalUrl,
+  website: httpUrlFieldSchema,
 
   // Profile
   linkedin: optionalUrl,
-  city: optionalNonEmptyString,
+  city: z.string().trim().min(1, { error: 'City is required.' }),
   country: z.enum(PARTNER_COUNTRY_VALUES).optional(),
   languages: z.array(z.enum(PARTNER_LANGUAGE_VALUES)).optional(),
 
@@ -49,8 +65,10 @@ export const partnerApplicationRequestSchema = z.strictObject({
   applicationNotes: optionalNonEmptyString,
 
   // Commercials
-  hourlyRate: optionalNonNegativeNumber,
-  projectBudgetMin: optionalNonNegativeNumber,
+  hourlyRate: z.number({ error: 'Hourly rate is required.' }).nonnegative(),
+  projectBudgetMin: z
+    .number({ error: 'Minimum project budget is required.' })
+    .nonnegative(),
   calendarLink: optionalUrl,
 });
 

packages/twenty-website/src/sections/PartnerApplication/partner-application-modal-data.ts

@@ -20,6 +20,7 @@ export const PARTNER_APPLICATION_MODAL_COPY = {
     incompleteForm: msg`Please complete all required fields before continuing.`,
     invalidEmail: msg`Enter a valid email address.`,
     invalidUrl: msg`Enter a valid URL (starting with http:// or https://).`,
+    invalidAmount: msg`Enter a valid amount using numbers only.`,
     submitFailed: msg`We could not submit your application. Please try again in a moment.`,
   },
 } as const;
@@ -29,10 +30,10 @@ export const PARTNER_APPLICATION_FIELD_COPY = {
   name: msg`Your name *`,
   email: msg`Work email *`,
   company: msg`Company or brand *`,
-  website: msg`Website or GitHub`,
+  website: msg`Website or GitHub *`,
   // Profile
   linkedin: msg`LinkedIn URL`,
-  city: msg`City`,
+  city: msg`City *`,
   country: msg`Country *`,
   countryPlaceholder: msg`Select your country`,
   countrySearchPlaceholder: msg`Search a country…`,
@@ -44,14 +45,14 @@ export const PARTNER_APPLICATION_FIELD_COPY = {
   partnerScope: msg`What you cover *`,
   partnerScopeHint: msg`Pick every category that applies.`,
   skills: msg`Technical skills`,
-  skillsHint: msg`Press Enter or comma to add a skill.`,
-  skillsPlaceholder: msg`e.g. React, Postgres, n8n…`,
+  skillsHint: msg`Tools, technologies and industries you specialize in. Press Enter or comma to add.`,
+  skillsPlaceholder: msg`e.g. n8n, Shopify, Real estate…`,
   applicationNotes: msg`Anything else we should know?`,
   applicationNotesPlaceholder: msg`Workspace URL, customer references, relevant links…`,
   // Commercials
-  hourlyRate: msg`Hourly rate`,
+  hourlyRate: msg`Hourly rate *`,
   hourlyRatePlaceholder: msg`150`,
-  projectBudgetMin: msg`Minimum project budget`,
+  projectBudgetMin: msg`Minimum project budget *`,
   projectBudgetMinPlaceholder: msg`5,000`,
   calendarLink: msg`Calendar / booking link`,
 } as const;

packages/twenty-website/src/sections/PartnerApplication/wizard/PartnerApplicationWizard.tsx

@@ -177,6 +177,7 @@ export function PartnerApplicationWizard({
     setSubmitError,
     setSubmitted,
     reset,
+    validateCurrentStep,
   } = controller;
 
   useEffect(() => {
@@ -192,7 +193,9 @@ export function PartnerApplicationWizard({
     ? PARTNER_APPLICATION_MODAL_COPY.validation.invalidEmail
     : errorValues.includes('invalid_url')
       ? PARTNER_APPLICATION_MODAL_COPY.validation.invalidUrl
-      : PARTNER_APPLICATION_MODAL_COPY.validation.incompleteForm;
+      : errorValues.includes('invalid_amount')
+        ? PARTNER_APPLICATION_MODAL_COPY.validation.invalidAmount
+        : PARTNER_APPLICATION_MODAL_COPY.validation.incompleteForm;
 
   const stepLabelNode = (
     <>
@@ -214,6 +217,9 @@ export function PartnerApplicationWizard({
         return;
       }
       if (state.isSubmitting) return;
+      // Fail fast: the final step bypasses GO_NEXT's gate, so validate its
+      // required fields here before hitting the server.
+      if (!validateCurrentStep()) return;
 
       const payload = buildPartnerApplicationRequestBody(state);
 
@@ -244,6 +250,7 @@ export function PartnerApplicationWizard({
     [
       isLastStep,
       goNext,
+      validateCurrentStep,
       state,
       setSubmitError,
       setSubmitting,