refactor(sonar): apply low-risk dataset and DOM cleanup wave

Author: thomasasen

CHANGELOG.md

@@ -21,6 +21,9 @@ direkt zu einer versionierten Release-Sektion.
 
 ### Fixed
 
+- Nutzerwirkung: Keine beabsichtigte sichtbare Verhaltensänderung; eine weitere Low-Risk-Sonar-Welle modernisiert interne Datenattribut-, Menü- und Overlay-Helfer, ohne Cricket-, X01-, xConfig- oder Theme-Abläufe fachlich umzubauen.
+  Technik: Mehrere Runtime- und UI-Pfade lesen und schreiben `data-*`-Felder jetzt konsistent über `dataset`, kleine Klarheitsrefactors glätten optionale Config-/Legacy-Zweige sowie einzelne DOM-Einfügepfade, `electric-border-engine` nutzt im Fallback wieder korrekt `parentNode.removeChild(...)`, und der Fake-DOM plus gezielte Runtime-Regressionen sichern `dataset`-/`before`-/`after`-Semantik sowie den Defs-Cleanup gegen Drift ab.
+
 - Nutzerwirkung: Keine beabsichtigte sichtbare Verhaltensänderung; mehrere kleine Sonar-getriebene Bereinigungen halten Runtime-, xConfig-, Theme- und Testpfade auf moderneren Standard-APIs, ohne die Fachlogik der Module sichtbar umzubauen.
   Technik: Niedrigrisiko-Refactorings vereinheitlichen `Object.hasOwn(...)`, `globalThis.window`, `Number.NaN`, `replaceAll(...)`, `String.raw`, `.at(...)` und einzelne Re-exports/Import-Aufräumer; dazu wurden nur eng begrenzte Test- und Helper-Anpassungen ergänzt, damit Sortierungen, Regex-Helfer, DOM-Klassenlisten und Changelog-/Build-Checks weiter stabil gegen Drift abgesichert bleiben.
 

dist/autodarts-xconfig.user.js

@@ -2365,7 +2365,10 @@
       const showDeadValue = Object.hasOwn(rawConfig, "showDeadTargets") ? rawConfig.showDeadTargets : rawConfig.showDeadObjectives;
       const normalizedDimStyle = normalizeStringChoice(rawConfig.irrelevantBoardDimStyle, "smoke", CRICKET_HIGHLIGHT_IRRELEVANT_DIM_STYLES);
       const hasLegacyDimSetting = Object.hasOwn(rawConfig, "dimIrrelevantBoardTargets");
-      const irrelevantBoardDimStyle = hasLegacyDimSetting && normalizedDimStyle === "smoke" ? normalizeBoolean(rawConfig.dimIrrelevantBoardTargets, true) ? "smoke" : "off" : normalizedDimStyle;
+      let irrelevantBoardDimStyle = normalizedDimStyle;
+      if (hasLegacyDimSetting && normalizedDimStyle === "smoke") {
+        irrelevantBoardDimStyle = normalizeBoolean(rawConfig.dimIrrelevantBoardTargets, true) ? "smoke" : "off";
+      }
       return { enabled: normalizeBoolean(rawConfig.enabled, false), showOpenObjectives: normalizeBoolean(showOpenValue, false), showDeadObjectives: normalizeBoolean(showDeadValue, true), irrelevantBoardDimStyle, dimIrrelevantBoardTargets: irrelevantBoardDimStyle !== "off", colorTheme: normalizeStringChoice(rawConfig.colorTheme, "standard", CRICKET_HIGHLIGHT_THEMES), intensity: normalizeStringChoice(rawConfig.intensity, "normal", CRICKET_HIGHLIGHT_INTENSITIES), debug: normalizeBoolean(rawConfig.debug, false) };
     },
     cricketGridFx(rawConfig = {}) {
@@ -2390,7 +2393,10 @@
     },
     turnPointsCount(rawConfig = {}) {
       const hasLegacyFlashPermanent = Object.hasOwn(rawConfig, "flashPermanent");
-      const legacyFlashMode = hasLegacyFlashPermanent ? normalizeBoolean(rawConfig.flashPermanent, false) ? "permanent" : "on-change" : "on-change";
+      let legacyFlashMode = "on-change";
+      if (hasLegacyFlashPermanent) {
+        legacyFlashMode = normalizeBoolean(rawConfig.flashPermanent, false) ? "permanent" : "on-change";
+      }
       const normalizedFlashMode = normalizeMappedStringChoice(rawConfig.flashMode, legacyFlashMode, { "": "on-change", "on-change": "on-change", onchange: "on-change", appear: "on-change", burst: "on-change", "nur-bei-änderung": "on-change", "nur-bei-aenderung": "on-change", permanent: "permanent", always: "permanent", persistent: "permanent", dauerhaft: "permanent" });
       return { enabled: normalizeBoolean(rawConfig.enabled, false), durationMs: normalizeNumberChoice(rawConfig.durationMs, 416, TURN_POINTS_COUNT_DURATIONS), flashOnChange: normalizeBoolean(rawConfig.flashOnChange, true), flashMode: hasLegacyFlashPermanent ? legacyFlashMode : normalizedFlashMode, debug: normalizeBoolean(rawConfig.debug, false) };
     },
@@ -3186,7 +3192,7 @@
         return;
       }
       const importedFeature = importer(legacyFeatureState);
-      if (!importedFeature || !importedFeature.configKey) {
+      if (!importedFeature?.configKey) {
         return;
       }
       importedFeatureCount += 1;
@@ -7758,8 +7764,8 @@
     return [
       role,
       String(node.tagName || ""),
-      String(node.getAttribute("data-target-ring") || ""),
-      String(node.getAttribute("data-target-value") || ""),
+      String(node.dataset?.targetRing || ""),
+      String(node.dataset?.targetValue || ""),
       String(node.getAttribute("d") || ""),
       String(node.getAttribute("r") || ""),
       String(node.getAttribute("fill-rule") || "")
@@ -7957,9 +7963,15 @@
       return;
     }
     shapeNode.setAttribute(TARGET_FAMILY_ATTRIBUTE, String(styleProfile.family || "single"));
-    shapeNode.setAttribute("data-target-ring", String(target?.ring || ""));
+    if (shapeNode.dataset) {
+      shapeNode.dataset.targetRing = String(target?.ring || "");
+    }
     if (Number.isFinite(target?.value)) {
-      shapeNode.setAttribute("data-target-value", String(target.value));
+      if (shapeNode.dataset) {
+        shapeNode.dataset.targetValue = String(target.value);
+      }
+    } else if (shapeNode.dataset) {
+      delete shapeNode.dataset.targetValue;
     }
   }
   function applyShapeStyle(shapeNode, visualConfig, styleProfile) {
@@ -8247,7 +8259,11 @@
       if (referenceNode === node) {
         return;
       }
-      overlay.insertBefore(node, referenceNode);
+      if (referenceNode) {
+        referenceNode.before(node);
+        return;
+      }
+      overlay.appendChild(node);
     });
   }
 
@@ -10184,8 +10200,8 @@
     }
     return 2.75;
   }
-  function toElementNode(node) {
-    let current = node || null;
+  function toElementNode(node = null) {
+    let current = node;
     while (current && current.nodeType !== 1) {
       current = current.parentNode || null;
     }
@@ -11917,7 +11933,7 @@
     if (nodeToRemove && typeof nodeToRemove.remove === "function") {
       nodeToRemove.remove();
     } else if (nodeToRemove && nodeToRemove.parentNode && typeof nodeToRemove.parentNode.removeChild === "function") {
-      nodeToRemove.remove();
+      nodeToRemove.parentNode.removeChild(nodeToRemove);
     }
     setReadyClass(documentRef, false);
     REF_COUNT_BY_DOCUMENT.delete(documentRef);
@@ -39648,7 +39664,7 @@ span.css-3fr5p8{
         return;
       }
       if (isConfigRoute()) {
-        button.setAttribute("data-active", "true");
+        button.dataset.active = "true";
       } else {
         button.removeAttribute("data-active");
       }
@@ -39662,11 +39678,11 @@ span.css-3fr5p8{
       const remoteVersion = String(state.updateStatus?.remoteVersion || "").trim();
       const title = hasUpdate && remoteVersion ? `${menuLabel} - Update verfügbar (${installedVersion} -> ${remoteVersion})` : menuLabel;
       if (hasUpdate) {
-        button.setAttribute("data-update-available", "true");
+        button.dataset.updateAvailable = "true";
       } else {
         button.removeAttribute("data-update-available");
       }
-      button.setAttribute("data-update-state", String(state.updateStatus?.status || ""));
+      button.dataset.updateState = String(state.updateStatus?.status || "");
       button.setAttribute("title", title);
       button.setAttribute("aria-label", title);
     }
@@ -39697,12 +39713,13 @@ span.css-3fr5p8{
       const sidebarLinks = Array.from(sidebar.querySelectorAll("a[href]"));
       const boardsAnchor = sidebarLinks.find((link) => toRoutePathname2(windowRef, link.getAttribute("href")) === "/boards") || sidebarLinks.find((link) => String(link.textContent || "").trim().toLowerCase() === "meine boards") || null;
       const insertionAnchor = boardsAnchor || sidebarLinks.find((link) => sidebarRouteHints.has(toRoutePathname2(windowRef, link.getAttribute("href")))) || null;
-      const templateCandidates = [
+      const template = [
         insertionAnchor,
         ...Array.from(sidebar.querySelectorAll?.("a[href], button, [role='button']") || []),
         sidebar.lastElementChild
-      ].filter(Boolean).filter((node) => node.id !== menuItemId).filter((node) => !node.closest?.(`#${panelHostId}`)).filter((node) => String(node.getAttribute?.("data-adxconfig-tab") || "").trim() === "");
-      const template = templateCandidates[0] || null;
+      ].find((node) => {
+        return Boolean(node) && node.id !== menuItemId && !node.closest?.(`#${panelHostId}`) && String(node.dataset?.adxconfigTab || "").trim() === "";
+      }) || null;
       let item = documentRef.getElementById?.(menuItemId);
       const shouldRebuildExistingItem = Boolean(item) && (Boolean(item.closest?.(`#${panelHostId}`)) || item.getAttribute?.("data-adxconfig-tab") !== null || String(item.getAttribute?.("data-adxconfig-action") || "").trim() !== "open" || !item.querySelector?.(".ad-xconfig-menu-label"));
       if (shouldRebuildExistingItem) {
@@ -39725,7 +39742,7 @@ span.css-3fr5p8{
       item.setAttribute("tabindex", "0");
       item.setAttribute("aria-label", menuLabel);
       item.setAttribute("title", menuLabel);
-      item.setAttribute("data-adxconfig-action", "open");
+      item.dataset.adxconfigAction = "open";
       item.style.cursor = "pointer";
       if (String(item.tagName || "").toLowerCase() === "a") {
         item.removeAttribute("href");
@@ -39749,7 +39766,7 @@ span.css-3fr5p8{
       }
       if (insertionAnchor) {
         if (insertionAnchor.nextElementSibling !== item) {
-          insertionAnchor.insertAdjacentElement("afterend", item);
+          insertionAnchor.after(item);
         }
       } else if (item.parentNode !== sidebar) {
         sidebar.appendChild(item);
@@ -41841,9 +41858,9 @@ span.css-3fr5p8{
     const codeNode = fieldNode.querySelector?.("[data-adxconfig-setting='true'][data-color-input-role='hex']") || null;
     const resetNode = fieldNode.querySelector?.("[data-adxconfig-action='clear-setting-color']") || null;
     const statusNode = fieldNode.querySelector?.("[data-adxconfig-color-status='true']") || null;
-    fieldNode.setAttribute("data-invalid", invalid ? "true" : "false");
-    fieldNode.setAttribute("data-has-custom-value", normalizedValue ? "true" : "false");
-    fieldNode.setAttribute("data-color-value", normalizedValue);
+    fieldNode.dataset.invalid = invalid ? "true" : "false";
+    fieldNode.dataset.hasCustomValue = normalizedValue ? "true" : "false";
+    fieldNode.dataset.colorValue = normalizedValue;
     if (swatchNode) {
       swatchNode.style.background = normalizedValue || "";
     }
@@ -41877,7 +41894,7 @@ span.css-3fr5p8{
     const previewFontFamily = String(preset?.previewFontFamily || "").trim();
     if (previewFontFamily && preset?.remote) {
       labelNode.style.fontFamily = previewFontFamily;
-      labelNode.setAttribute("data-adxconfig-preview-font", preset.value);
+      labelNode.dataset.adxconfigPreviewFont = preset.value;
     }
     return labelNode;
   }
@@ -42191,7 +42208,7 @@ span.css-3fr5p8{
     if (!optionNode || typeof optionNode.setAttribute !== "function") {
       return;
     }
-    optionNode.setAttribute("data-active", isActive ? "true" : "false");
+    optionNode.dataset.active = isActive ? "true" : "false";
     optionNode.setAttribute("aria-pressed", isActive ? "true" : "false");
     const activeContainer = optionNode.querySelector?.("[data-option-active-slot='true']") || optionNode.querySelector?.(".ad-xconfig-option-head") || null;
     if (!activeContainer) {
@@ -42207,10 +42224,10 @@ span.css-3fr5p8{
     activeBadge?.remove?.();
   }
   function syncSelectOptionButtons(documentRef, actionNode, selectedValue) {
-    if (!actionNode || typeof actionNode.getAttribute !== "function") {
+    if (!actionNode) {
       return;
     }
-    const settingKey = String(actionNode.getAttribute("data-setting-key") || "").trim();
+    const settingKey = String(actionNode.dataset?.settingKey || "").trim();
     if (!settingKey) {
       return;
     }
@@ -42225,14 +42242,14 @@ span.css-3fr5p8{
     );
     const selectedValues = Array.isArray(selectedValue) ? selectedValue.map((value) => String(value ?? "")) : [String(selectedValue ?? "")];
     optionButtons.forEach((optionNode) => {
-      const optionValue = String(optionNode.getAttribute("data-setting-value") ?? "");
+      const optionValue = String(optionNode.dataset?.settingValue ?? "");
       setSelectOptionActiveState(documentRef, optionNode, selectedValues.includes(optionValue));
     });
     const optionList = inputWrap.querySelector?.(
       `[data-adxconfig-setting='true'][data-setting-control='select'][data-setting-key='${settingKey}']`
     );
     if (optionList) {
-      optionList.setAttribute("data-selected-value", selectedValues.join(","));
+      optionList.dataset.selectedValue = selectedValues.join(",");
     }
   }
   function buildFeatureCard(documentRef, feature) {
@@ -43036,7 +43053,7 @@ span.css-3fr5p8{
       }
       const tabNode = target.closest("[data-adxconfig-tab]");
       if (tabNode) {
-        const tabId = tabNode.getAttribute("data-adxconfig-tab") || "themes";
+        const tabId = tabNode.dataset?.adxconfigTab || "themes";
         if (TAB_DEFINITIONS2.some((tab) => tab.id === tabId)) {
           state.activeTab = tabId;
           state.activeSettingsFeatureKey = "";
@@ -43053,15 +43070,15 @@ span.css-3fr5p8{
       if (!insideMenuButton && !insidePanelHost) {
         return;
       }
-      const action = actionNode.getAttribute("data-adxconfig-action");
+      const action = actionNode.dataset?.adxconfigAction || "";
       if (action === "close-settings-backdrop") {
         const insideModal = target.closest("[data-adxconfig-modal='true']");
         if (insideModal) {
           return;
         }
       }
       event.preventDefault?.();
-      const featureKey = actionNode.getAttribute("data-feature-key");
+      const featureKey = actionNode.dataset?.featureKey || "";
       const feature = getFeatures().find((entry) => entry.featureKey === featureKey) || null;
       handleAction(action, actionNode, feature);
     }
@@ -43070,8 +43087,8 @@ span.css-3fr5p8{
       if (!target || typeof target.getAttribute !== "function") {
         return;
       }
-      if (target.getAttribute("data-adxconfig-feature-toggle") === "true") {
-        const featureKey2 = target.getAttribute("data-feature-key");
+      if (target.dataset?.adxconfigFeatureToggle === "true") {
+        const featureKey2 = target.dataset?.featureKey || "";
         if (featureKey2 && typeof runtimeApi.setFeatureEnabled === "function") {
           withRuntimeCall(
             runtimeApi.setFeatureEnabled(featureKey2, Boolean(target.checked)),
@@ -43081,12 +43098,12 @@ span.css-3fr5p8{
         }
         return;
       }
-      if (target.getAttribute("data-adxconfig-setting") !== "true") {
+      if (target.dataset?.adxconfigSetting !== "true") {
         return;
       }
-      const featureKey = target.getAttribute("data-feature-key");
-      const configKey = target.getAttribute("data-config-key");
-      const settingKey = target.getAttribute("data-setting-key");
+      const featureKey = target.dataset?.featureKey || "";
+      const configKey = target.dataset?.configKey || "";
+      const settingKey = target.dataset?.settingKey || "";
       if (!featureKey || !configKey || !settingKey || typeof runtimeApi.saveConfig !== "function") {
         return;
       }

scripts/check-changelog-consistency.mjs

@@ -135,7 +135,11 @@ function validateSectionEntries(section) {
       continue;
     }
 
-    if (/^- /.test(line) && !/^- Nutzerwirkung:\s+\S/.test(line)) {
+    const hasUserImpactPrefix = line.startsWith("- Nutzerwirkung: ");
+    if (
+      line.startsWith("- ") &&
+      (!hasUserImpactPrefix || !line.slice("- Nutzerwirkung: ".length).trim())
+    ) {
       errors.push(`Abschnitt ${section.name}: Listenpunkte müssen mit "Nutzerwirkung:" beginnen.`);
     }
 

src/config/config-store.js

@@ -460,7 +460,7 @@ function mapLegacyConfig(legacyConfig) {
     }
 
     const importedFeature = importer(legacyFeatureState);
-    if (!importedFeature || !importedFeature.configKey) {
+    if (!importedFeature?.configKey) {
       return;
     }
 

src/config/feature-config-spec.js

@@ -565,7 +565,12 @@ const FEATURE_NORMALIZERS = Object.freeze({
     const showDeadValue = Object.hasOwn(rawConfig, "showDeadTargets") ? rawConfig.showDeadTargets : rawConfig.showDeadObjectives;
     const normalizedDimStyle = normalizeStringChoice(rawConfig.irrelevantBoardDimStyle, "smoke", CRICKET_HIGHLIGHT_IRRELEVANT_DIM_STYLES);
     const hasLegacyDimSetting = Object.hasOwn(rawConfig, "dimIrrelevantBoardTargets");
-    const irrelevantBoardDimStyle = hasLegacyDimSetting && normalizedDimStyle === "smoke" ? normalizeBoolean(rawConfig.dimIrrelevantBoardTargets, true) ? "smoke" : "off" : normalizedDimStyle;
+    let irrelevantBoardDimStyle = normalizedDimStyle;
+    if (hasLegacyDimSetting && normalizedDimStyle === "smoke") {
+      irrelevantBoardDimStyle = normalizeBoolean(rawConfig.dimIrrelevantBoardTargets, true)
+        ? "smoke"
+        : "off";
+    }
     return { enabled: normalizeBoolean(rawConfig.enabled, false), showOpenObjectives: normalizeBoolean(showOpenValue, false), showDeadObjectives: normalizeBoolean(showDeadValue, true), irrelevantBoardDimStyle, dimIrrelevantBoardTargets: irrelevantBoardDimStyle !== "off", colorTheme: normalizeStringChoice(rawConfig.colorTheme, "standard", CRICKET_HIGHLIGHT_THEMES), intensity: normalizeStringChoice(rawConfig.intensity, "normal", CRICKET_HIGHLIGHT_INTENSITIES), debug: normalizeBoolean(rawConfig.debug, false) };
   },
   cricketGridFx(rawConfig = {}) {
@@ -590,7 +595,12 @@ const FEATURE_NORMALIZERS = Object.freeze({
   },
   turnPointsCount(rawConfig = {}) {
     const hasLegacyFlashPermanent = Object.hasOwn(rawConfig, "flashPermanent");
-    const legacyFlashMode = hasLegacyFlashPermanent ? normalizeBoolean(rawConfig.flashPermanent, false) ? "permanent" : "on-change" : "on-change";
+    let legacyFlashMode = "on-change";
+    if (hasLegacyFlashPermanent) {
+      legacyFlashMode = normalizeBoolean(rawConfig.flashPermanent, false)
+        ? "permanent"
+        : "on-change";
+    }
     const normalizedFlashMode = normalizeMappedStringChoice(rawConfig.flashMode, legacyFlashMode, { "": "on-change", "on-change": "on-change", onchange: "on-change", appear: "on-change", burst: "on-change", "nur-bei-änderung": "on-change", "nur-bei-aenderung": "on-change", permanent: "permanent", always: "permanent", persistent: "permanent", dauerhaft: "permanent" });
     return { enabled: normalizeBoolean(rawConfig.enabled, false), durationMs: normalizeNumberChoice(rawConfig.durationMs, 416, TURN_POINTS_COUNT_DURATIONS), flashOnChange: normalizeBoolean(rawConfig.flashOnChange, true), flashMode: hasLegacyFlashPermanent ? legacyFlashMode : normalizedFlashMode, debug: normalizeBoolean(rawConfig.debug, false) };
   },

src/features/checkout-board-targets/logic.js

@@ -125,8 +125,8 @@ function buildRenderableNodeKey(node) {
   return [
     role,
     String(node.tagName || ""),
-    String(node.getAttribute("data-target-ring") || ""),
-    String(node.getAttribute("data-target-value") || ""),
+    String(node.dataset?.targetRing || ""),
+    String(node.dataset?.targetValue || ""),
     String(node.getAttribute("d") || ""),
     String(node.getAttribute("r") || ""),
     String(node.getAttribute("fill-rule") || ""),
@@ -368,9 +368,15 @@ function applyTargetMetadata(shapeNode, target, styleProfile) {
   }
 
   shapeNode.setAttribute(TARGET_FAMILY_ATTRIBUTE, String(styleProfile.family || "single"));
-  shapeNode.setAttribute("data-target-ring", String(target?.ring || ""));
+  if (shapeNode.dataset) {
+    shapeNode.dataset.targetRing = String(target?.ring || "");
+  }
   if (Number.isFinite(target?.value)) {
-    shapeNode.setAttribute("data-target-value", String(target.value));
+    if (shapeNode.dataset) {
+      shapeNode.dataset.targetValue = String(target.value);
+    }
+  } else if (shapeNode.dataset) {
+    delete shapeNode.dataset.targetValue;
   }
 }
 
@@ -694,6 +700,10 @@ export function renderCheckoutTargets(options = {}) {
     if (referenceNode === node) {
       return;
     }
-    overlay.insertBefore(node, referenceNode);
+    if (referenceNode) {
+      referenceNode.before(node);
+      return;
+    }
+    overlay.appendChild(node);
   });
 }