fix(x01): release bust highlight visual fix in 2.4.7

thomasasen · thomasasen · commit 848458d57afe · 2026-06-25T19:28:30.000+02:00
- keep bust active-player styling independent from later hit tile colors
- bump userscript version and regenerate release artifacts
- document release and require commit messages for future version bumps
diff --git a/.agents/skills/package-userscript-release/SKILL.md b/.agents/skills/package-userscript-release/SKILL.md
@@ -22,6 +22,7 @@ Do not use it for ordinary implementation, cleanup, validation, or docs work.
 - keep local working tree, local commit, GitHub-published, and installed-userscript truth separate
 - use `$maintain-changelog` for changelog curation; do not duplicate changelog policy here
 - do not claim remote publication or installed-version availability unless actually verified
+- include a suitable draft commit message whenever a version bump is performed
 
 # Context budget
 
@@ -48,3 +49,4 @@ A valid result must:
 - align all local version markers
 - distinguish local, committed, GitHub-published, and installed truth
 - report validation and publication state honestly
+- include a suitable draft commit message when the task included a version bump
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,13 @@ zum nächsten Release-Commit vorübergehend auf `HEAD` zeigen.
 Dieses Repository führt keine `Unreleased`-Sektion. Jeder dokumentierte Eintrag gehört
 direkt zu einer versionierten Release-Sektion.
 
+## [2.4.7] - 2026-06-25
+
+### Fixed
+
+- Nutzerwirkung: `X01 Bust Active Player Highlight` behält beim Überwurf das rote `60 T20`-Hitkachel-Design auf der aktiven Spielerkarte, auch wenn spätere Trefferanimationen andere Farben verwenden.
+  Technik: Das Bust-Modul verwendet eine feste Kopie der roten Hitkachel-Visuals statt aktueller Throw-Tile-Styles und schützt den Pfad mit einer Regression gegen anders eingefärbte Trefferflächen.
+
 ## [2.4.6] - 2026-06-25
 
 ### Added
@@ -1759,7 +1766,8 @@ direkt zu einer versionierten Release-Sektion.
   und Regressionstests eingeführt und die generierten README-/FEATURES-Texte wurden
   entsprechend synchronisiert.
 
-[2.4.6]: https://github.com/thomasasen/autodarts-xconfig/compare/4da06d6...HEAD
+[2.4.7]: https://github.com/thomasasen/autodarts-xconfig/compare/369c519...HEAD
+[2.4.6]: https://github.com/thomasasen/autodarts-xconfig/compare/4da06d6...369c519
 [2.4.5]: https://github.com/thomasasen/autodarts-xconfig/compare/106b63c...4da06d6
 [2.4.4]: https://github.com/thomasasen/autodarts-xconfig/compare/e93e11d...106b63c
 [2.4.3]: https://github.com/thomasasen/autodarts-xconfig/compare/73900ce...e93e11d
diff --git a/dist/autodarts-xconfig.meta.js b/dist/autodarts-xconfig.meta.js
@@ -1,7 +1,7 @@
 // ==UserScript==
 // @name         autodarts-xconfig
 // @namespace    https://github.com/thomasasen/autodarts-xconfig
-// @version      2.4.6
+// @version      2.4.7
 // @description  Modular, side-effect resistant Tampermonkey runtime for Autodarts enhancements.
 // @author       Thomas Asen
 // @license      MIT
diff --git a/dist/autodarts-xconfig.user.js b/dist/autodarts-xconfig.user.js
@@ -1,7 +1,7 @@
 // ==UserScript==
 // @name         autodarts-xconfig
 // @namespace    https://github.com/thomasasen/autodarts-xconfig
-// @version      2.4.6
+// @version      2.4.7
 // @description  Modular, side-effect resistant Tampermonkey runtime for Autodarts enhancements.
 // @author       Thomas Asen
 // @license      MIT
@@ -12926,7 +12926,6 @@ ${scopedClassSelector(selectorPrefix, EFFECT_CLASSES["fade-blink"])} {
 
   // src/features/x01-bust-active-player-highlight/logic.js
   var TURN_POINTS_SELECTOR2 = ".ad-ext-turn-points";
-  var TURN_THROW_SELECTOR = "#ad-ext-turn .ad-ext-turn-throw, .ad-ext-turn-throw";
   var ACTIVE_PLAYER_SELECTOR = "#ad-ext-player-display .ad-ext-player.ad-ext-player-active, #ad-ext-player-display .ad-ext-player-active, .ad-ext-player.ad-ext-player-active, .ad-ext-player-active";
   var SHAKE_DURATION_MS = 3e3;
   var BUST_SOUND_VOLUME = 0.9;
@@ -12996,26 +12995,12 @@ ${scopedClassSelector(selectorPrefix, EFFECT_CLASSES["fade-blink"])} {
     }
     return queryOne2(documentRef, ACTIVE_PLAYER_SELECTOR);
   }
-  function readComputedValue(style, propertyName, fallbackValue) {
-    const value = String(style?.[propertyName] || "").trim();
-    return value || fallbackValue;
-  }
-  function resolveBustCardVisuals(documentRef, windowRef = null) {
-    const throwNode = queryOne2(documentRef, TURN_THROW_SELECTOR);
-    const getComputedStyleRef3 = windowRef && typeof windowRef.getComputedStyle === "function" ? windowRef.getComputedStyle.bind(windowRef) : null;
-    const style = throwNode && getComputedStyleRef3 ? getComputedStyleRef3(throwNode) : null;
+  function resolveBustCardVisuals() {
     return {
-      background: readComputedValue(style, "background", FALLBACK_BUST_CARD_VISUALS.background),
-      backgroundColor: readComputedValue(
-        style,
-        "backgroundColor",
-        FALLBACK_BUST_CARD_VISUALS.backgroundColor
-      ),
-      border: readComputedValue(style, "border", FALLBACK_BUST_CARD_VISUALS.border),
-      borderColor: readComputedValue(style, "borderColor", "rgb(207, 52, 52)"),
-      borderStyle: readComputedValue(style, "borderStyle", "solid"),
-      borderWidth: readComputedValue(style, "borderWidth", "0.8px"),
-      boxShadow: readComputedValue(style, "boxShadow", FALLBACK_BUST_CARD_VISUALS.boxShadow)
+      ...FALLBACK_BUST_CARD_VISUALS,
+      borderColor: "rgb(207, 52, 52)",
+      borderStyle: "solid",
+      borderWidth: "0.8px"
     };
   }
   function setStylePropertyIfChanged(node, propertyName, value) {
@@ -13434,7 +13419,7 @@ ${scopedClassSelector(selectorPrefix, EFFECT_CLASSES["fade-blink"])} {
       clearNodeState(state.activeNode);
     }
     const enteredBust = state.wasBust !== true;
-    const visuals = resolveBustCardVisuals(documentRef, windowRef);
+    const visuals = resolveBustCardVisuals();
     activeNode.classList.add(BUST_ACTIVE_CLASS);
     applyBustCardVisuals(activeNode, visuals);
     state.activeNode = activeNode;
@@ -41964,7 +41949,7 @@ ${buildTurnSuggestionDartGuardStyleBlock()}`;
 
   // src/core/bootstrap.js
   var GLOBAL_NAMESPACE_KEY = "__adXConfig";
-  var API_VERSION = "2.4.6";
+  var API_VERSION = "2.4.7";
   var STARTUP_DEFER_INTERVAL_MS = 16;
   function getWindowTimerApi(windowRef) {
     let setTimeoutRef = null;
diff --git a/loader/autodarts-xconfig.user.js b/loader/autodarts-xconfig.user.js
@@ -1,7 +1,7 @@
 // ==UserScript==
 // @name         autodarts-xconfig
 // @namespace    https://github.com/thomasasen/autodarts-xconfig
-// @version      2.4.6
+// @version      2.4.7
 // @description  Modular, side-effect resistant Tampermonkey runtime for Autodarts enhancements.
 // @author       Thomas Asen
 // @license      MIT
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "autodarts-xconfig",
-  "version": "2.4.6",
+  "version": "2.4.7",
   "description": "Clean successor architecture for autodarts xConfig userscript modules",
   "type": "module",
   "imports": {
diff --git a/src/core/bootstrap.js b/src/core/bootstrap.js
@@ -13,7 +13,7 @@ import { createListenerRegistry } from "./listener-registry.js";
 import { createObserverRegistry } from "./observer-registry.js";
 
 const GLOBAL_NAMESPACE_KEY = "__adXConfig";
-const API_VERSION = "2.4.6";
+const API_VERSION = "2.4.7";
 const STARTUP_DEFER_INTERVAL_MS = 16;
 
 function getWindowTimerApi(windowRef) {
diff --git a/src/features/x01-bust-active-player-highlight/logic.js b/src/features/x01-bust-active-player-highlight/logic.js
@@ -10,7 +10,6 @@ import { isX01VariantText } from "../../domain/variant-rules.js";
 import { removeBustCracks, renderBustCracks } from "./cracks.js";
 
 export const TURN_POINTS_SELECTOR = ".ad-ext-turn-points";
-export const TURN_THROW_SELECTOR = "#ad-ext-turn .ad-ext-turn-throw, .ad-ext-turn-throw";
 export const ACTIVE_PLAYER_SELECTOR =
   "#ad-ext-player-display .ad-ext-player.ad-ext-player-active, #ad-ext-player-display .ad-ext-player-active, .ad-ext-player.ad-ext-player-active, .ad-ext-player-active";
 export const SHAKE_DURATION_MS = 3000;
@@ -101,31 +100,12 @@ export function findActiveX01PlayerCard(documentRef) {
   return queryOne(documentRef, ACTIVE_PLAYER_SELECTOR);
 }
 
-function readComputedValue(style, propertyName, fallbackValue) {
-  const value = String(style?.[propertyName] || "").trim();
-  return value || fallbackValue;
-}
-
-export function resolveBustCardVisuals(documentRef, windowRef = null) {
-  const throwNode = queryOne(documentRef, TURN_THROW_SELECTOR);
-  const getComputedStyleRef =
-    windowRef && typeof windowRef.getComputedStyle === "function"
-      ? windowRef.getComputedStyle.bind(windowRef)
-      : null;
-  const style = throwNode && getComputedStyleRef ? getComputedStyleRef(throwNode) : null;
-
+export function resolveBustCardVisuals() {
   return {
-    background: readComputedValue(style, "background", FALLBACK_BUST_CARD_VISUALS.background),
-    backgroundColor: readComputedValue(
-      style,
-      "backgroundColor",
-      FALLBACK_BUST_CARD_VISUALS.backgroundColor
-    ),
-    border: readComputedValue(style, "border", FALLBACK_BUST_CARD_VISUALS.border),
-    borderColor: readComputedValue(style, "borderColor", "rgb(207, 52, 52)"),
-    borderStyle: readComputedValue(style, "borderStyle", "solid"),
-    borderWidth: readComputedValue(style, "borderWidth", "0.8px"),
-    boxShadow: readComputedValue(style, "boxShadow", FALLBACK_BUST_CARD_VISUALS.boxShadow),
+    ...FALLBACK_BUST_CARD_VISUALS,
+    borderColor: "rgb(207, 52, 52)",
+    borderStyle: "solid",
+    borderWidth: "0.8px",
   };
 }
 
@@ -625,7 +605,7 @@ export function syncBustActivePlayerHighlight(context = {}, state = createBustAc
   }
 
   const enteredBust = state.wasBust !== true;
-  const visuals = resolveBustCardVisuals(documentRef, windowRef);
+  const visuals = resolveBustCardVisuals();
   activeNode.classList.add(BUST_ACTIVE_CLASS);
   applyBustCardVisuals(activeNode, visuals);
   state.activeNode = activeNode;
diff --git a/tests/runtime/x01-bust-active-player-highlight.test.js b/tests/runtime/x01-bust-active-player-highlight.test.js
@@ -129,7 +129,7 @@ function setupBustDocument(options = {}) {
   documentRef.variantElement.textContent = options.variantText || "X01";
   setTurnScore(documentRef, options.turnScoreText || "BUST");
   const players = appendPlayerDisplay(documentRef);
-  documentRef.throwRow.__computedStyle = {
+  documentRef.throwRow.__computedStyle = options.throwComputedStyle || {
     background:
       "rgba(255, 0, 0, 0.15) none repeat scroll 0% 0% / auto padding-box border-box",
     backgroundColor: "rgba(255, 0, 0, 0.15)",
@@ -181,6 +181,38 @@ test("x01 bust highlight styles and shakes only the active player on bust entry"
   assert.equal(activeCard.style.getPropertyPriority("box-shadow"), "important");
 });
 
+test("x01 bust highlight keeps copied hit visuals when current hit tiles use another theme", () => {
+  const { documentRef, activeCard, activeSurface } = setupBustDocument({
+    throwComputedStyle: {
+      background:
+        "rgba(0, 0, 0, 0) linear-gradient(165deg, rgba(8, 12, 12, 0.98) 0%, rgba(11, 19, 12, 0.96) 48%, rgba(6, 11, 8, 0.99) 100%) repeat scroll 0% 0% / auto padding-box border-box",
+      backgroundColor: "rgba(0, 0, 0, 0)",
+      border: "0.8px solid rgba(255, 255, 255, 0.14)",
+      borderColor: "rgba(255, 255, 255, 0.14)",
+      borderStyle: "solid",
+      borderWidth: "0.8px",
+      boxShadow:
+        "rgba(255, 255, 255, 0.04) 0px 0px 0px 1px inset, rgba(0, 0, 0, 0.28) 0px -8px 18px 0px inset",
+    },
+  });
+  const state = createBustActivePlayerHighlightState();
+  const { windowRef } = createManualTimerWindow(documentRef);
+
+  syncBustActivePlayerHighlight({ documentRef, windowRef }, state);
+
+  assert.equal(
+    activeCard.style.getPropertyValue("--ad-ext-x01-bust-active-player-background-color"),
+    "rgba(255, 0, 0, 0.15)"
+  );
+  assert.equal(
+    activeCard.style.getPropertyValue("--ad-ext-x01-bust-active-player-border"),
+    "0.8px solid rgb(207, 52, 52)"
+  );
+  assert.equal(activeSurface.style.getPropertyValue("background-color"), "rgba(255, 0, 0, 0.15)");
+  assert.equal(activeCard.style.getPropertyValue("border-color"), "rgb(207, 52, 52)");
+  assert.equal(activeCard.style.getPropertyValue("box-shadow"), "none");
+});
+
 test("x01 bust highlight plays the glass crack sound only on bust entry when enabled", () => {
   const { documentRef } = setupBustDocument();
   const state = createBustActivePlayerHighlightState();

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "autodarts-xconfig",`
`3`		`- "version": "2.4.6",`
	`3`	`+ "version": "2.4.7",`
`4`	`4`	`"description": "Clean successor architecture for autodarts xConfig userscript modules",`
`5`	`5`	`"type": "module",`
`6`	`6`	`"imports": {`