refactor(sonar): clear another low-risk UI and runtime batch

- simplify small update-check, tv-board-zoom, winner-fireworks, snapshot-cache, and path helper smells
- keep x01-2player and shell select-value helpers behaviorally identical while reducing local control-flow noise
- update changelog and verify with lint, test, and Sonar scan (87 -> 75 open issues)

Author: thomasasen

CHANGELOG.md

@@ -21,6 +21,9 @@ direkt zu einer versionierten Release-Sektion.
 
 ### Fixed
 
+- Nutzerwirkung: Keine beabsichtigte sichtbare Verhaltensänderung; eine weitere kleine Sonar-Welle hält Update-Status, Winner-Animation, TV-Zoom, Cricket-Snapshot-Cache sowie ausgewählte xConfig-Helfer auf denselben fachlichen Pfaden, drückt einige Status- und Auswahlzweige intern aber direkter aus.
+  Technik: `update-check`, `winner-fireworks`, `tv-board-zoom`, `cricket-surface/snapshot-cache`, `x01-2player/policy`, `xconfig-ui/path-utils` und `shell-view` bereinigen nur lokale `S3358`-, `S1788`- und `S7766`-Treffer durch kleine Helper und unveränderte Fallback-Pfade; Observer-, Snapshot-, Select- und Update-Semantik bleiben dabei gleich, und die bestehenden Runtime-, Domain- und Changelog-Regressionen bleiben der fachliche Schutz gegen Drift.
+
 - Nutzerwirkung: Keine beabsichtigte sichtbare Verhaltensänderung; Theme-Mounting, Checkout-Board-Ziele sowie die Cricket-Wrapper für Highlighting und Grid-FX laufen auf denselben fachlichen Pfaden weiter, sind intern aber in dieser Sonar-Welle klarer in Status- und Aktivierungsblöcke getrennt.
   Technik: `mount-theme-feature`, `checkout-board-targets`, `cricket-highlighter` und `cricket-grid-fx` ziehen kleine Aktivierungs-, Renderstatus- und Nicht-Ready-Statuspfade jetzt in lokale Helper; `mount-theme-feature` kapselt zusätzlich Theme-Evaluator und Mutation-Callback in eigene lokale Fabriken, ohne öffentliche Signaturen oder die beobachtbare Overlay-/Lifecycle-Semantik zu ändern. Die bestehenden Theme-, Lifecycle-, Runtime-Performance- und Degraded-Host-Regressionen sichern diese Wrapper-Refactors gegen Drift ab.
 

src/features/cricket-surface/snapshot-cache.js

@@ -1,8 +1,9 @@
 import { findBoardSvgGroup, isReusableBoardSnapshot } from "../../shared/dartboard-svg.js";
 
-export function resolveGridSnapshot(documentRef, cricketRules, targetOrder, cache = null, findGrid) {
-  if (cache?.grid?.root && cache.grid.root.isConnected !== false) {
-    return cache.grid;
+export function resolveGridSnapshot(documentRef, cricketRules, targetOrder, cache, findGrid) {
+  const resolvedCache = cache && typeof cache === "object" ? cache : null;
+  if (resolvedCache?.grid?.root && resolvedCache.grid.root.isConnected !== false) {
+    return resolvedCache.grid;
   }
 
   const nextGrid =
@@ -13,20 +14,21 @@ export function resolveGridSnapshot(documentRef, cricketRules, targetOrder, cach
           targetOrder,
         })
       : null;
-  if (cache && typeof cache === "object") {
-    cache.grid = nextGrid;
+  if (resolvedCache) {
+    resolvedCache.grid = nextGrid;
   }
   return nextGrid;
 }
 
-export function resolveBoardSnapshot(documentRef, cache = null) {
-  if (isReusableBoardSnapshot(cache?.board, documentRef)) {
-    return cache.board;
+export function resolveBoardSnapshot(documentRef, cache) {
+  const resolvedCache = cache && typeof cache === "object" ? cache : null;
+  if (isReusableBoardSnapshot(resolvedCache?.board, documentRef)) {
+    return resolvedCache.board;
   }
 
   const nextBoard = findBoardSvgGroup(documentRef);
-  if (cache && typeof cache === "object") {
-    cache.board = nextBoard;
+  if (resolvedCache) {
+    resolvedCache.board = nextBoard;
   }
   return nextBoard;
 }

src/features/themes/x01-2player/policy.js

@@ -324,7 +324,7 @@ function findTableSlot(cardNode, stackNode) {
 
 function resolveFallbackActiveIndex(playerCards) {
   const classIndex = playerCards.findIndex((node) => node?.classList?.contains?.("ad-ext-player-active"));
-  return classIndex >= 0 ? classIndex : 0;
+  return Math.max(0, classIndex);
 }
 
 function resolveActivePlayerIndex(playerCards, gameState) {

src/features/tv-board-zoom/index.js

@@ -162,14 +162,7 @@ export function shouldScheduleTvBoardZoomMutation(mutations = [], context = {})
       return false;
     }
 
-    const mutationType = String(
-      mutation.type ||
-        (mutation.attributeName
-          ? "attributes"
-          : mutation.addedNodes || mutation.removedNodes
-            ? "childList"
-            : "")
-    );
+    const mutationType = resolveMutationType(mutation);
 
     if (mutationType === "attributes") {
       return (
@@ -198,6 +191,19 @@ export function shouldScheduleTvBoardZoomMutation(mutations = [], context = {})
   });
 }
 
+function resolveMutationType(mutation) {
+  if (mutation?.type) {
+    return String(mutation.type);
+  }
+  if (mutation?.attributeName) {
+    return "attributes";
+  }
+  if (mutation?.addedNodes || mutation?.removedNodes) {
+    return "childList";
+  }
+  return "";
+}
+
 function getNodeClassName(node) {
   if (!node || typeof node.getAttribute !== "function") {
     return "";
@@ -252,6 +258,16 @@ function buildDebugSummary(payload = {}) {
   }" ty="${payload.ty ?? "-"}" anchor="${payload.anchorX ?? "-"},${payload.anchorY ?? "-"}"`;
 }
 
+function resolveFeatureDebugLogger(featureDebug, level) {
+  if (level === "warn" && typeof featureDebug?.warn === "function") {
+    return featureDebug.warn.bind(featureDebug);
+  }
+  if (typeof featureDebug?.log === "function") {
+    return featureDebug.log.bind(featureDebug);
+  }
+  return null;
+}
+
 function emitDebugEvent(debugState, level, payload = {}) {
   if (!debugState?.featureDebug?.enabled) {
     return;
@@ -263,12 +279,7 @@ function emitDebugEvent(debugState, level, payload = {}) {
   }
   debugState.lastSignature = signature;
 
-  const logger =
-    level === "warn" && typeof debugState.featureDebug.warn === "function"
-      ? debugState.featureDebug.warn.bind(debugState.featureDebug)
-      : typeof debugState.featureDebug.log === "function"
-        ? debugState.featureDebug.log.bind(debugState.featureDebug)
-        : null;
+  const logger = resolveFeatureDebugLogger(debugState.featureDebug, level);
   if (!logger) {
     return;
   }

src/features/winner-fireworks/logic.js

@@ -16,6 +16,13 @@ const TERMINAL_STATUS_TOKENS = new Set([
   "match-over",
   "won",
 ]);
+const STYLE_INTERVAL_MS = Object.freeze({
+  sides: 16,
+  fireworks: 250,
+  victorystorm: 620,
+  stars: 980,
+  default: 920,
+});
 
 function randomInRange(min, max) {
   return Math.random() * (max - min) + min;
@@ -293,15 +300,7 @@ function runStyleBurst(state) {
 }
 
 function getStyleIntervalMs(style, intensityPreset) {
-  const base = style === "sides"
-    ? 16
-    : style === "fireworks"
-      ? 250
-      : style === "victorystorm"
-        ? 620
-        : style === "stars"
-          ? 980
-          : 920;
+  const base = STYLE_INTERVAL_MS[style] ?? STYLE_INTERVAL_MS.default;
   return scaledInterval(base, intensityPreset);
 }
 

src/features/xconfig-ui/path-utils.js

@@ -8,8 +8,9 @@ export function splitFeaturePath(featureKey) {
   return splitSharedFeaturePath(featureKey);
 }
 
-export function setNestedValue(rootValue, pathParts = [], value) {
-  return setSharedNestedValue(rootValue, pathParts, value);
+export function setNestedValue(rootValue, pathParts, value) {
+  const normalizedPathParts = Array.isArray(pathParts) ? pathParts : [];
+  return setSharedNestedValue(rootValue, normalizedPathParts, value);
 }
 
 export function buildFeatureSettingPatch(configKey, settingKey, value) {

src/features/xconfig-ui/shell-view.js

@@ -1073,16 +1073,22 @@ function getFieldNoteText(field) {
   return String(field?.description || "").trim();
 }
 
+function resolveConfiguredFieldValues(feature, field) {
+  const configuredValue = feature?.config?.[field.key];
+  if (isMultiSelectField(field)) {
+    return Array.isArray(configuredValue) ? configuredValue : [configuredValue];
+  }
+  return [configuredValue];
+}
+
 function resolveSelectFieldValues(feature, field) {
   const options = Array.isArray(field?.options) ? field.options : [];
   if (!options.length) {
     return [];
   }
 
   const allowedValues = new Set(options.map((option) => String(option?.value ?? "")));
-  const rawValues = isMultiSelectField(field)
-    ? (Array.isArray(feature?.config?.[field.key]) ? feature.config[field.key] : [feature?.config?.[field.key]])
-    : [feature?.config?.[field.key]];
+  const rawValues = resolveConfiguredFieldValues(feature, field);
   const configuredValues = Array.from(
     new Set(
       rawValues

src/features/xconfig-ui/update-check.js

@@ -117,6 +117,24 @@ function createBaseUpdateStatus(installedVersion, capable) {
   };
 }
 
+function normalizeCheckedAt(value) {
+  const numericValue = Number(value);
+  if (!Number.isFinite(numericValue)) {
+    return 0;
+  }
+  return Math.max(0, numericValue);
+}
+
+function resolveUpdateStatus(normalizedRemoteVersion, comparison, error) {
+  if (normalizedRemoteVersion) {
+    return comparison > 0 ? "available" : "current";
+  }
+  if (error) {
+    return "error";
+  }
+  return "idle";
+}
+
 function safeParseJson(value) {
   if (typeof value !== "string" || !value.trim()) {
     return null;
@@ -224,16 +242,10 @@ function createResolvedUpdateStatus({
 
   return {
     ...baseStatus,
-    status: normalizedRemoteVersion
-      ? comparison > 0
-        ? "available"
-        : "current"
-      : error
-        ? "error"
-        : "idle",
+    status: resolveUpdateStatus(normalizedRemoteVersion, comparison, error),
     remoteVersion: normalizedRemoteVersion,
     available: normalizedRemoteVersion ? comparison > 0 : false,
-    checkedAt: Number(checkedAt) > 0 ? Number(checkedAt) : 0,
+    checkedAt: normalizeCheckedAt(checkedAt),
     sourceUrl: String(sourceUrl || "").trim(),
     error: String(error || "").trim(),
     stale: Boolean(stale),
@@ -263,7 +275,7 @@ function writeStoredPayload(storageRef, payload) {
       UPDATE_STATUS_STORAGE_KEY,
       JSON.stringify({
         remoteVersion: normalizeVersion(payload?.remoteVersion),
-        checkedAt: Number(payload?.checkedAt) > 0 ? Number(payload.checkedAt) : 0,
+        checkedAt: normalizeCheckedAt(payload?.checkedAt),
         sourceUrl: String(payload?.sourceUrl || "").trim(),
         validators: normalizeValidatorsMap(payload?.validators),
       })