Merge pull request #6 from thedavidweng/feat/store-perf

Author: thedavidweng

.github/workflows/ci.yml

@@ -20,6 +20,7 @@ jobs:
           go-version-file: 'go.mod'
           cache: true
 
+      - run: test -z "$(gofmt -l .)"
       - run: go vet ./...
       - run: go test ./... -race
       - run: go build ./...

CONTRIBUTING.md

@@ -28,6 +28,9 @@ go mod download
 ### Build and Test
 
 ```bash
+# Format check (CI will fail if any files are unformatted)
+test -z "$(gofmt -l .)"
+
 # Static analysis
 go vet ./...
 
@@ -41,7 +44,7 @@ go test ./... -cover
 go build ./cmd/money
 ```
 
-CI runs `go vet`, `go test -race`, and `go build` on both `ubuntu-latest` and `macos-latest` for every push and pull request.
+CI runs `gofmt -l`, `go vet`, `go test -race`, and `go build` on both `ubuntu-latest` and `macos-latest` for every push and pull request.
 
 ### Release Workflow
 

internal/cli/cli.go

@@ -105,7 +105,7 @@ If this is your first time, run:
 This creates your config, encryption key, and database. After setup, you can
 link financial institutions and sync transactions locally.
 `,
-		Version:       fmt.Sprintf("%s (commit %s)", Version, Commit),
+		Version: fmt.Sprintf("%s (commit %s)", Version, Commit),
 		Example: `  money setup
   money link "Chase"
   money sync
@@ -473,8 +473,8 @@ func newAccountsCommand(ctx context.Context, state *runtimeState, stdout io.Writ
 		Example: "  money accounts list\n  money accounts list --verbose --json\n  money accounts create-manual --name Savings --type depository --balance 1000.00 --currency USD --confirm",
 	}
 	listCmd := &cobra.Command{
-		Use:   "list",
-		Short: "List accounts",
+		Use:     "list",
+		Short:   "List accounts",
 		Example: "  money accounts list\n  money accounts list --verbose\n  money accounts list --json",
 		RunE: func(cmd *cobra.Command, args []string) error {
 			activeStore, err := requireStore(state)
@@ -625,7 +625,7 @@ func newTransactionsCommand(ctx context.Context, state *runtimeState, stdout io.
 		Use:     "search <query>",
 		Short:   "Search transactions",
 		Example: "  money transactions search \"whole foods\"\n  money transactions search uber --limit 10",
-		Args:  cobra.ExactArgs(1),
+		Args:    cobra.ExactArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			activeStore, err := requireStore(state)
 			if err != nil {
@@ -727,8 +727,8 @@ func newCategoriesCommand(ctx context.Context, state *runtimeState, stdout io.Wr
 		Example: "  money categories list\n  money categories list --verbose --json",
 	}
 	listCmd := &cobra.Command{
-		Use:   "list",
-		Short: "List categories",
+		Use:     "list",
+		Short:   "List categories",
 		Example: "  money categories list\n  money categories list --verbose",
 		RunE: func(cmd *cobra.Command, args []string) error {
 			activeStore, err := requireStore(state)
@@ -1038,16 +1038,16 @@ func newImportCommand(ctx context.Context, state *runtimeState, stdout io.Writer
 			Short: "Import accounts and transactions from " + sourceName,
 			Args:  cobra.ExactArgs(1),
 			RunE: func(cmd *cobra.Command, args []string) error {
-			if state.json && !dryRun && !confirm {
-				return cliError{
-					command:   "import." + sourceName,
-					code:      "CONFIRMATION_REQUIRED",
-					message:   "JSON import writes require --dry-run or --confirm",
-					category:  contracts.CategoryValidation,
-					retryable: false,
-					exitCode:  2,
+				if state.json && !dryRun && !confirm {
+					return cliError{
+						command:   "import." + sourceName,
+						code:      "CONFIRMATION_REQUIRED",
+						message:   "JSON import writes require --dry-run or --confirm",
+						category:  contracts.CategoryValidation,
+						retryable: false,
+						exitCode:  2,
+					}
 				}
-			}
 				if batchID == "" {
 					batchID = time.Now().UTC().Format("20060102T150405Z")
 				}
@@ -1587,7 +1587,6 @@ func newPlaidLogoutCommand(state *runtimeState, stdout io.Writer, commandName st
 	return cmd
 }
 
-
 type providerAvailabilityRow struct {
 	Provider string
 	Status   string

internal/cli/cli_link.go

@@ -502,4 +502,3 @@ func selectLinkInstitution(institutions []providers.Institution, institutionID s
 	}
 	return institutions[0], nil
 }
-

internal/cli/link_flow_test.go

@@ -348,8 +348,8 @@ func TestRunPlaidLinkFlowReturnsCLIErrorOnCancel(t *testing.T) {
 		return fakeLinkSessionServer{
 			url: "http://127.0.0.1:4000",
 			callback: providers.LinkCallback{
-				State:  state,
-				Status: "cancel",
+				State:    state,
+				Status:   "cancel",
 				Metadata: providers.LinkMetadata{LinkSessionID: "sess-cancel"},
 			},
 		}, nil
@@ -396,9 +396,9 @@ func TestRunPlaidLinkFlowReturnsCLIErrorOnLinkError(t *testing.T) {
 		return fakeLinkSessionServer{
 			url: "http://127.0.0.1:4000",
 			callback: providers.LinkCallback{
-				State:  state,
-				Status: "error",
-				Error:  providers.LinkError{Type: "INSTITUTION_ERROR", Code: "INSUFFICIENT_CREDENTIALS", Message: "user entered invalid credentials"},
+				State:    state,
+				Status:   "error",
+				Error:    providers.LinkError{Type: "INSTITUTION_ERROR", Code: "INSUFFICIENT_CREDENTIALS", Message: "user entered invalid credentials"},
 				Metadata: providers.LinkMetadata{RequestID: "req-123", LinkSessionID: "sess-456"},
 			},
 		}, nil

internal/importsource/monarch.go

@@ -14,10 +14,12 @@ import (
 
 // MonarchImporter reads Monarch JSON exports and maps them to canonical records.
 // Expected JSON shape:
-//   {
-//     "accounts": [...],
-//     "transactions": [...]
-//   }
+//
+//	{
+//	  "accounts": [...],
+//	  "transactions": [...]
+//	}
+//
 // Each account has: id, name, type, subtype, balance, currency.
 // Each transaction has: id, account_id, date, amount, name, merchant_name, category, pending.
 type MonarchImporter struct{}

internal/plaidlogin/callback_test.go

@@ -43,10 +43,10 @@ func TestCallbackHandlerAcceptsValidCodeOnce(t *testing.T) {
 
 func TestCallbackHandlerRejectsOAuthErrorMissingCodeWrongStateAndWrongMethod(t *testing.T) {
 	tests := []struct {
-		name       string
-		method     string
-		target     string
-		status     int
+		name        string
+		method      string
+		target      string
+		status      int
 		wantWaitErr bool // true if Wait should return immediately with an error
 	}{
 		{name: "oauth error", method: http.MethodGet, target: "/oauth/callback?error=access_denied&state=state-ok", status: http.StatusBadRequest, wantWaitErr: true},

internal/providers/provider.go

@@ -10,17 +10,17 @@ import (
 // so that provider adapters can use them without importing core directly.
 // The store package imports core directly — it no longer imports providers.
 type (
-	Institution          = core.Institution
-	ProviderItem         = core.ProviderItem
-	FinancialAccount     = core.FinancialAccount
-	Transaction          = core.ProviderTransaction
-	Recurring            = core.ProviderRecurring
-	SyncRun              = core.SyncRun
-	SyncResult           = core.SyncResult
-	InvestmentHolding    = core.InvestmentHolding
-	InvestmentSecurity   = core.InvestmentSecurity
-	Liability            = core.Liability
-	SyncSink             = core.SyncSink
+	Institution        = core.Institution
+	ProviderItem       = core.ProviderItem
+	FinancialAccount   = core.FinancialAccount
+	Transaction        = core.ProviderTransaction
+	Recurring          = core.ProviderRecurring
+	SyncRun            = core.SyncRun
+	SyncResult         = core.SyncResult
+	InvestmentHolding  = core.InvestmentHolding
+	InvestmentSecurity = core.InvestmentSecurity
+	Liability          = core.Liability
+	SyncSink           = core.SyncSink
 )
 
 type Provider interface {

internal/store/migrations/0005_performance_indexes.sql

@@ -0,0 +1,5 @@
+-- Composite index for CashflowSummary: filters by removed, pending, currency, then range on date
+CREATE INDEX IF NOT EXISTS idx_transactions_cashflow ON transactions (removed, pending, currency, date);
+
+-- Composite index for filtered ListTransactions by account
+CREATE INDEX IF NOT EXISTS idx_transactions_account_removed_date ON transactions (removed, account_id, date DESC);