Add PAC release automation#2062
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/release-note-none |
|
@infernus01 - could you help verifying this config |
There was a problem hiding this comment.
This file fires via PAC incoming webhooks, but there's no patch-release.yaml to actually call that webhook. Let's add that file as well.
There was a problem hiding this comment.
Added .github/workflows/patch-release.yaml — mirrors the pattern from tektoncd/pipeline#9671, with PAC_REPOSITORY_NAME and MIN_RELEASE_VERSION adapted for triggers.
| - name: releaseAsLatest | ||
| value: "{{ release_as_latest }}" | ||
| - name: platforms | ||
| value: linux/amd64,linux/arm64,linux/s390x,linux/ppc64le |
There was a problem hiding this comment.
Let's also include windows/amd64
There was a problem hiding this comment.
Added windows/amd64 to platforms in both release.yaml and release-patch.yaml.
|
@rajnish-jais It would be better if you could add a nightly-build workflow as well. Not a blocker for this PR, but that'd good to have, since triggers doesn't have yet. |
|
Please consider the same reviews for the results PR as well. |
|
Both review comments from @infernus01 are resolved:
The nightly-build workflow is noted as a follow-up; will track separately. |
infernus01
left a comment
There was a problem hiding this comment.
Thanks @rajnish-jais.
Let's also update release cheat sheet to document the new automated flow because after this merges, the cheat sheet would be misleading. Could you update the release cheat sheet to reflect the new flow? Also, while you do it, please update the README as well to reflect the new feature. You can take references from other components though.
|
😄 and please consider it for the results PR as well! Thanks. |
|
@infernus01 The results PR (tektoncd/results#1373) already has the same fixes — |
Adds releases-triggers and releases-results namespaces with Repository CRs so PAC can dispatch release PipelineRuns for: - tektoncd/triggers (see tektoncd/triggers#2062) - tektoncd/results (see tektoncd/results#1373) Follows the same pattern as the existing chains, pipeline, pruner, operator, and cli CRs.
Adds releases-triggers and releases-results namespaces with Repository CRs so PAC can dispatch release PipelineRuns for: - tektoncd/triggers (see tektoncd/triggers#2062) - tektoncd/results (see tektoncd/results#1373) Follows the same pattern as the existing chains, pipeline, pruner, operator, and cli CRs.
I appreciate that, btw I was talking about this review for results as well - #2062 (review) |
|
|
|
@infernus01 Updated both files:
|
335750d to
8b4ece7
Compare
infernus01
left a comment
There was a problem hiding this comment.
The releases.md update looks good to me.
We still need to update release-cheat-sheet.md to document the new automated flow.
infernus01
left a comment
There was a problem hiding this comment.
Also please squash the commits.
8b4ece7 to
58487a8
Compare
58487a8 to
9c185ce
Compare
Summary
Adds
.tekton/release.yamland.tekton/release-patch.yamlto automate releases using Pipelines-as-Code, following the exact pattern already merged in:The
.tekton/release.yamlPipelineRun fires once when arelease-v*branch is first created (CEL guard:body.created == true). The.tekton/release-patch.yamlis triggered via PAC incoming webhooks for patch releases, receivingversionandrelease_as_latestas payload params.The companion plumbing PR to add the
RepositoryCR in tektoncd/plumbing will follow.Closes #2061