Skip to content

Commit 08154dc

Browse files
khrmclaude
andcommitted
fix: pass --insecure-registry to ko for plain-HTTP KinD registry
ko >=v0.19 writes SBOMs to the registry over HTTPS by default, which fails against the plain-HTTP KinD registry (registry.local:5000) with: "http: server gave HTTP response to HTTPS client" Set KO_FLAGS=--insecure-registry in the e2e workflow and thread it through ko resolve calls in e2e-common.sh. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c02670b commit 08154dc

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/e2e-matrix.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ jobs:
2121
CLUSTER_DOMAIN: c${{ github.run_id }}.local
2222
ARTIFACTS: ${{ github.workspace }}/artifacts
2323
KOCACHE: /tmp/ko-cache
24+
# registry.local:5000 is a plain-HTTP KinD registry; tell ko to skip TLS
25+
# so that both image pushes and SBOM writes (ko >=v0.19) use plain HTTP.
26+
KO_FLAGS: --insecure-registry
2427

2528
steps:
2629
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

test/e2e-common.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function install_triggers_crd() {
5454
echo ">> Deploying Tekton Triggers"
5555
rel=$(mktemp)
5656
release=$(mktemp)
57-
ko resolve -f config/ > "${rel}" || fail_test "Tekton Triggers build failed"
57+
ko resolve ${KO_FLAGS:-} -f config/ > "${rel}" || fail_test "Tekton Triggers build failed"
5858

5959
if [ "${SKIP_SECURITY_CTX}" == "true" ]; then
6060
yq 'del(.spec.template.spec.containers[]?.securityContext.runAsUser, .spec.template.spec.containers[]?.securityContext.runAsGroup)' "${rel}" > "${release}"
@@ -66,7 +66,7 @@ function install_triggers_crd() {
6666

6767
# Wait for the Interceptors CRD to be available before adding the core-interceptors
6868
kubectl wait --for=condition=Established --timeout=30s crds/clusterinterceptors.triggers.tekton.dev
69-
ko resolve -f config/interceptors > "${rel}" || fail_test "Core interceptors build failed"
69+
ko resolve ${KO_FLAGS:-} -f config/interceptors > "${rel}" || fail_test "Core interceptors build failed"
7070

7171
if [ "${SKIP_SECURITY_CTX}" == "true" ]; then
7272
kubectl patch configmap config-defaults-triggers -n tekton-pipelines --type='merge' -p='{"data":{"default-run-as-user":"","default-fs-group":"", "default-run-as-group":""}}'

0 commit comments

Comments
 (0)