Setting multiple tags with the Tekton Buildah Taks?

[kastl-ars]

Dear all,

I found a similar issue so asking this here:

Is it possible to have multiple tags set during building an image with the buildah task?

Just setting latest is sometimes not enough, it would be nice to also set e.g. the build date or the commit hash in the repository the Containerfile is being used from.

Is this possible? Did I just miss the documentation?

Kind Regards,
Johannes

[vdemeester]

Hey @kastl-ars,

You can set BUILD_EXTRA_ARGS to --tag myimage:$(date +%Y%m%d) --tag myimage:$(git rev-parse --short HEAD) alongside the primary IMAGE parameter and it should work.

It might be worth pointing this out in the doc.

Cheers,

[kastl-ars]

Thanks for the fast reply. it should work sounds like you did not test that recently? :-)

Nevertheless, I'll give this a spin. And yeah, I strongly suggest this should be put into the documentation!

[kastl-ars]

The first try was unsuccessful:

---> Phase: Extra 'buildah bud' arguments informed: '--tag XXX:$(date +%Y%m%d) --tag XXX:$(git rev-parse --short HEAD)'...
Error: accepts at most 1 arg(s), received 10

Using fixed strings instead of the date or git commands works, so this seems quoting related.

With the fixed values I can see the image being built and tagged with all three tags (latest, the date and the commit hash).
Unfortunately it is only pushed with the latest tag.

Using the same values for PUSH_EXTRA_ARGS does not change the behaviour, unfortunately. Any ideas on that? Does it just need the tags without the --tags?

[vdemeester]

@kastl-ars yeah, I didn't test this recently 😅 For the push it might need, but it feels like we should definitely fix / enhance this behavior..

[kastl-ars]

I would really like to see this supported (and documented) out of the box, because this is a very common usage pattern (at least with my colleagues and customers).

Should I open a bug report for both the documentation and the implementation into build and push?

• How to add arguments for building with multiple tags?
  • How to properly quote them (or fix the task to properly handle those types of CLI arguments, not sure where the error is exactly)?
• How to add arguments for pushing multiple tags?
  • How to properly quote them (or fix the task to properly handle those types of CLI arguments, not sure where the error is exactly)?

[kastl-ars]

Unfortunately it is only pushed with the latest tag.

I had some time to dig into this today. It looks to me like --tag is only valid for the buildah bud command, not for buildah push.

https://manpages.opensuse.org/Tumbleweed/buildah/buildah-push.1.en.html

I'll check if I can enhance the script to do multiple pushes.

[kastl-ars]

OK, I got this working, at least with static aka hardcoded tags.

The buildah-Task gets a new variable ADDITIONAL_TAGS
The buildah-common.sh script does its magic for the new variable ADDITIONAL_TAGS
The buildah-bud.sh script needs another if-and-for section, checking for the new variable ADDITIONAL_TAGS. If it is non-zero, it loops over all strings in that variable and pushes the existing image to the registry with the new tag.

     "${PARAMS_IMAGE}" \
     "docker://${PARAMS_IMAGE}"
 
+# push additional tags, if PARAMS_ADDITIONAL_TAGS is not empty
+if [ -n "${PARAMS_ADDITIONAL_TAGS}" ]; then
+
+    phase "Pushing additional tags for '${PARAMS_IMAGE}' to the container registry"
+
+    for tag in ${PARAMS_ADDITIONAL_TAGS};do
+
+         _buildah push "${push_extra_args[@]}" \
+             --digestfile="${digest_file}" \
+             "${PARAMS_IMAGE}" \
+             "docker://${PARAMS_IMAGE}:${tag}"
+    done
+
+fi
+
 #
 # Results
 #

[kastl-ars]

Meh, apparently the buildah task from OpenShift (that I based my experiments on) is an older version than what is currently in the catalog.

I'll retry again with the 0.9.0 task. Meh...

[kastl-ars]

I submitted my task in this PR: #1382