Removes the uncategorized SDK error type, since we don’t map to it.

Author: mliberatore

CHANGELOG.md

@@ -4,7 +4,7 @@
 **Changes**
 * [Changed] Renamed the Crypto Onramp error status enum from `OnrampError` to `OnrampErrorStatus`. Existing generic Onramp errors now use `StripeError<OnrampErrorStatus>`.
 * [Changed] Split rich Crypto Onramp errors into `OnrampSdkError` for SDK-level diagnostics and `OnrampApiError` for API-specific context. `OnrampSdkError` now includes an `onrampErrorType` discriminator typed as `OnrampErrorType`, and `OnrampApiError` narrows it to `OnrampApiErrorType`.
-* [Added] Added `LegacyConfigureAppAttestationError` and `UncategorizedSdkError` Crypto Onramp error types for React Native compatibility errors and native SDK errors that have not yet been modeled more specifically.
+* [Added] Added `LegacyConfigureAppAttestationError` for React Native compatibility app attestation errors.
 
 **Fixes**
 * [Fixed] Manual bank-account entry in ConnectAccountOnboarding now creates an external account on iOS/Android by collecting a bank-account token instead of only Financial Connections accounts.

android/src/onramp/java/com/reactnativestripesdk/OnrampErrors.kt

@@ -68,7 +68,7 @@ private fun createNonApiOnrampError(
     localizedMessage = error.localizedMessage,
     stripeErrorCode = onrampError.code,
   ) {
-    putCommonOnrampFields(onrampError, "UncategorizedSdkError")
+    putCommonOnrampFields(onrampError)
   }
 }
 

android/src/test/java/com/reactnativestripesdk/OnrampErrorsTest.kt

@@ -131,7 +131,6 @@ class OnrampErrorsTest {
     assertEquals("Failed", details!!.getString("code"))
     assertEquals("Something went wrong.", details.getString("message"))
     assertEquals("Something went wrong.", details.getString("localizedMessage"))
-    assertEquals("UncategorizedSdkError", details.getString("onrampErrorType"))
     assertEquals("Developer message.", details.getString("developerMessage"))
     assertEquals("Something went wrong.", details.getString("userMessage"))
     assertEquals("sdk_error", details.getString("stripeErrorCode"))

etc/stripe-react-native.api.md

@@ -1435,7 +1435,7 @@ type CryptoOnrampError = (StripeError<OnrampErrorStatus> & {
     onrampErrorType?: never;
     developerMessage?: never;
     userMessage?: never;
-}) | AppAttestationError | UncategorizedApiError | UncategorizedSdkError | LegacyConfigureAppAttestationError;
+}) | AppAttestationError | UncategorizedApiError | LegacyConfigureAppAttestationError;
 
 // @public
 type CryptoPaymentToken = {
@@ -2595,7 +2595,6 @@ declare namespace Onramp {
         OnrampApiError,
         AppAttestationError,
         UncategorizedApiError,
-        UncategorizedSdkError,
         LegacyConfigureAppAttestationError,
         CryptoOnrampError,
         RetrieveMissingIdentifiersResult,
@@ -2643,7 +2642,7 @@ enum OnrampErrorStatus {
 }
 
 // @public
-type OnrampErrorType = OnrampApiErrorType | 'UncategorizedSdkError' | 'LegacyConfigureAppAttestationError';
+type OnrampErrorType = OnrampApiErrorType | 'LegacyConfigureAppAttestationError';
 
 // @public
 type OnrampGooglePayParams = {
@@ -3938,11 +3937,6 @@ type UncategorizedApiError = OnrampApiError & {
     onrampErrorType: 'UncategorizedApiError';
 };
 
-// @public
-type UncategorizedSdkError = OnrampSdkError & {
-    onrampErrorType: 'UncategorizedSdkError';
-};
-
 // @public
 export const updatePlatformPaySheet: (params: {
     applePay: {

ios/OnrampErrors.swift

@@ -41,7 +41,7 @@ enum OnrampErrors {
                 message: onrampError.userMessage,
                 localizedMessage: onrampError.localizedDescription,
                 stripeErrorCode: onrampError.code,
-                additionalFields: commonOnrampFields(error: onrampError, onrampErrorType: "UncategorizedSdkError")
+                additionalFields: commonOnrampFields(error: onrampError)
             )
         }
 

ios/Tests/OnrampErrorsTests.swift

@@ -130,7 +130,6 @@ class OnrampErrorsTests: XCTestCase {
         XCTAssertEqual(details["code"] as? String, "Failed")
         XCTAssertEqual(details["message"] as? String, error.userMessage)
         XCTAssertEqual(details["localizedMessage"] as? String, error.localizedDescription)
-        XCTAssertEqual(details["onrampErrorType"] as? String, "UncategorizedSdkError")
         XCTAssertEqual(details["developerMessage"] as? String, error.developerMessage)
         XCTAssertEqual(details["userMessage"] as? String, error.userMessage)
         XCTAssertEqual(details["stripeErrorCode"] as? String, error.code)

src/types/Onramp.ts

@@ -280,7 +280,6 @@ export type OnrampApiErrorType =
  */
 export type OnrampErrorType =
   | OnrampApiErrorType
-  | 'UncategorizedSdkError'
   | 'LegacyConfigureAppAttestationError';
 
 /**
@@ -334,13 +333,6 @@ export type UncategorizedApiError = OnrampApiError & {
   onrampErrorType: 'UncategorizedApiError';
 };
 
-/**
- * A typed Crypto Onramp SDK error that did not map to a narrower category.
- */
-export type UncategorizedSdkError = OnrampSdkError & {
-  onrampErrorType: 'UncategorizedSdkError';
-};
-
 /**
  * A compatibility error for older native SDKs that returned app attestation setup
  * failures as legacy configure errors.
@@ -364,7 +356,6 @@ export type CryptoOnrampError =
     })
   | AppAttestationError
   | UncategorizedApiError
-  | UncategorizedSdkError
   | LegacyConfigureAppAttestationError;
 
 /**