Skip to content

Commit 3604062

Browse files
committed
reorder plots and results table
* so that user can see results while plot is updating
1 parent ccf7a40 commit 3604062

2 files changed

Lines changed: 16 additions & 13 deletions

File tree

CHANGES.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ Cubeviz
1212
Imviz
1313
^^^^^
1414

15+
- Reorders photometry results table and plots and includes warning for performance concerns for
16+
large apertures if the raw profile type is selected. [#1801]
17+
1518
Mosviz
1619
^^^^^^
1720

jdaviz/configs/imviz/plugins/aper_phot_simple/aper_phot_simple.vue

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -134,21 +134,14 @@
134134
</div>
135135
</div>
136136

137-
<v-row v-if="plot_available">
138-
<!-- NOTE: the internal bqplot widget defaults to 480 pixels, so if choosing something else,
139-
we will likely need to override that with custom CSS rules in order to avoid the initial
140-
rendering of the plot from overlapping with content below -->
141-
<jupyter-widget :widget="radial_plot" style="width: 100%; height: 480px" />
142-
</v-row>
143-
144-
<div v-if="plot_available && fit_radial_profile">
145-
<j-plugin-section-header>Gaussian Fit Results</j-plugin-section-header>
137+
<div v-if="result_available">
138+
<j-plugin-section-header>Photometry Results</j-plugin-section-header>
146139
<v-row no-gutters>
147140
<v-col cols=6><U>Result</U></v-col>
148141
<v-col cols=6><U>Value</U></v-col>
149142
</v-row>
150143
<v-row
151-
v-for="item in fit_results"
144+
v-for="item in results"
152145
:key="item.function"
153146
no-gutters>
154147
<v-col cols=6>
@@ -158,14 +151,21 @@
158151
</v-row>
159152
</div>
160153

161-
<div v-if="result_available">
162-
<j-plugin-section-header>Photometry Results</j-plugin-section-header>
154+
<v-row v-if="plot_available">
155+
<!-- NOTE: the internal bqplot widget defaults to 480 pixels, so if choosing something else,
156+
we will likely need to override that with custom CSS rules in order to avoid the initial
157+
rendering of the plot from overlapping with content below -->
158+
<jupyter-widget :widget="radial_plot" style="width: 100%; height: 480px" />
159+
</v-row>
160+
161+
<div v-if="plot_available && fit_radial_profile">
162+
<j-plugin-section-header>Gaussian Fit Results</j-plugin-section-header>
163163
<v-row no-gutters>
164164
<v-col cols=6><U>Result</U></v-col>
165165
<v-col cols=6><U>Value</U></v-col>
166166
</v-row>
167167
<v-row
168-
v-for="item in results"
168+
v-for="item in fit_results"
169169
:key="item.function"
170170
no-gutters>
171171
<v-col cols=6>

0 commit comments

Comments
 (0)