Implement MainPawnLostRate, interpreted as a % chance to avoid losing a pawn to the void. At the current values in the tree, this is 41% at max rate.

Author: RyanYappert

Arrowgene.Ddon.GameServer/Characters/OrbUnlockManager.cs

@@ -123,12 +123,10 @@ private PacketQueue UpdateExtendedParamData(GameClient client, CharacterCommon c
                     obj.MainPawnSlot += (ushort)upgrade.Amount;
                     // When the player unlocks this, the total number will be increased to 3.
                     client.Character.MyPawnSlotNum += (byte)upgrade.Amount;
-                    _Server.Database.UpdateMyPawnSlot(client.Character.CharacterId, client.Character.MyPawnSlotNum, connectionIn);
                     break;
                 case OrbGainParamType.SupportPawnSlot:
                     obj.SupportPawnSlot += (ushort)upgrade.Amount;
                     client.Character.RentalPawnSlotNum += (byte)upgrade.Amount;
-                    _Server.Database.UpdateRentalPawnSlot(client.Character.CharacterId, client.Character.RentalPawnSlotNum, connectionIn);
                     break;
                 case OrbGainParamType.UseItemSlot:
                     obj.UseItemSlot += (ushort)upgrade.Amount;
@@ -145,6 +143,7 @@ private PacketQueue UpdateExtendedParamData(GameClient client, CharacterCommon c
                 case OrbGainParamType.PawnCraftNum:
                 // TODO: OrbGainParamType.MainPawnLostRate
                 case OrbGainParamType.MainPawnLostRate:
+                    obj.MainPawnLostRate += (ushort)upgrade.Amount;
                     break;
                 case OrbGainParamType.SecretAbility:
                     queue.Enqueue(client, _Server.JobManager.UnlockSecretAbility(client, character, upgrade.SecretAbility, connectionIn));
@@ -303,20 +302,6 @@ public PacketQueue UnlockDragonForceAugmentationUpgrade(GameClient client, Chara
 
             DragonForceUpgrade upgrade = common is Character arisen ? GetPlayerUpgrade(elementId) : GetPawnUpgrade(elementId);
 
-            if (character is Character)
-            {
-                upgrade = GetPlayerUpgrade(client, (Character)character, elementId);
-            }
-            else
-            {
-                upgrade = GetPawnUpgrade(client, (Pawn)character, elementId);
-            }
-
-            if (upgrade == null)
-            {
-                throw new ResponseErrorException(ErrorCode.ERROR_CODE_ORB_DEVOTE_INVALID_ELEMENT_ID);
-            }
-
             // Check for Valid Conditions before continuing
             if (upgrade.IsRestrictedByTotalLevels())
             {
@@ -515,12 +500,6 @@ private Category GroupNo2Category(GroupNo GroupNo)
                     GroupNo.Group5 => Category.Other,
                     _ => Category.None,
                 };
-                        return Category.Combat;
-                    case GroupNo.Group5:
-                        return Category.Other;
-                }
-
-                return Category.None;
             }
         }
 

Arrowgene.Ddon.GameServer/Handler/PawnPawnLostHandler.cs

@@ -3,6 +3,7 @@
 using Arrowgene.Ddon.Shared.Entity.PacketStructure;
 using Arrowgene.Ddon.Shared.Model;
 using Arrowgene.Logging;
+using System;
 
 namespace Arrowgene.Ddon.GameServer.Handler
 {
@@ -20,18 +21,20 @@ public override PacketQueue Handle(GameClient client, C2SPawnPawnLostReq request
 
             Pawn pawn = client.Character.PawnById(request.PawnId, PawnType.Main);
 
+            bool isLost = Random.Shared.NextDouble() > (client.Character.ExtendedParams.MainPawnLostRate / 100.0);
+
             client.Enqueue(new S2CPawnPawnLostRes()
             {
                 PawnId = pawn.PawnId,
                 PawnName = pawn.Name,
-                IsLost = true
+                IsLost = isLost
             }, queue);
 
             S2CPawnPawnLostNtc ntc = new S2CPawnPawnLostNtc()
             {
                 PawnId = pawn.PawnId,
                 PawnName = pawn.Name,
-                IsLost = true
+                IsLost = isLost
             };
             client.Party.EnqueueToAllExcept(ntc, queue, client);
 
@@ -48,7 +51,7 @@ public override PacketQueue Handle(GameClient client, C2SPawnPawnLostReq request
                 }, queue);
             }
 
-            pawn.PawnState = PawnState.Lost;
+            pawn.PawnState = isLost ? PawnState.Lost : PawnState.None;
             Server.Database.UpdatePawnBaseInfo(pawn);
 
             return queue;

Arrowgene.Ddon.Shared/Entity/Structure/CDataOrbGainExtendParam.cs

@@ -18,6 +18,9 @@ public class CDataOrbGainExtendParam
         public ushort MainPawnSlot { get; set; }
         public ushort SupportPawnSlot { get; set; }
 
+        // Not serialized but stored here for convenience.
+        public ushort MainPawnLostRate { get; set; }
+
         public static CDataOrbGainExtendParam operator +(CDataOrbGainExtendParam a, CDataOrbGainExtendParam b)
         {
             return new CDataOrbGainExtendParam()