Skip to content

Commit 9309986

Browse files
brfrn169brfrn169
committed
Fix Javadoc for populateRecordsForAfterImageIndexTest
1 parent aeff947 commit 9309986

1 file changed

Lines changed: 37 additions & 12 deletions

File tree

‎integration-test/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitSpecificIntegrationTestBase.java‎

Lines changed: 37 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2520,12 +2520,19 @@ private void scan_ScanWithIndexForPreparedWhenCoordinatorStateAbortedAndIndexKey
25202520
* <ul>
25212521
* <li>(0,0): COMMITTED with BALANCE=NEW_BALANCE
25222522
* <li>(0,2): COMMITTED with BALANCE=NEW_BALANCE
2523-
* <li>(0,1): PREPARED/DELETED with BALANCE changed from INITIAL_BALANCE to NEW_BALANCE
2523+
* <li>(0,1): {@code recordState} with BALANCE changed from INITIAL_BALANCE to NEW_BALANCE
25242524
* </ul>
25252525
*
2526-
* When querying BALANCE=NEW_BALANCE, all 3 records match the normal index. After rollback of
2527-
* (0,1), its BALANCE reverts to INITIAL_BALANCE, so it should be filtered out, leaving only the 2
2526+
* When querying BALANCE=NEW_BALANCE, all 3 records match the normal index. If (0,1) is rolled
2527+
* back, its BALANCE reverts to INITIAL_BALANCE, so it should be filtered out, leaving only the 2
25282528
* COMMITTED records.
2529+
*
2530+
* @param storage the storage instance to use for populating records
2531+
* @param namespace the namespace of the table
2532+
* @param table the table name
2533+
* @param recordState the transaction state of the (0,1) record (e.g., PREPARED or DELETED)
2534+
* @param preparedAt the prepared-at timestamp for the (0,1) record
2535+
* @param coordinatorState the coordinator state for the transaction that wrote the (0,1) record
25292536
*/
25302537
private void populateRecordsForAfterImageIndexTest(
25312538
DistributedStorage storage,
@@ -6911,7 +6918,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
69116918
void
69126919
get_WithConjunction_ForPreparedRecordWhoseBeforeImageMatchesConjunction_ShouldReturnRecordAfterLazyRecovery(
69136920
Isolation isolation, boolean readOnly)
6914-
throws UnknownTransactionStatusException, CrudException, ExecutionException,
6921+
throws UnknownTransactionStatusException,
6922+
CrudException,
6923+
ExecutionException,
69156924
CommitException {
69166925
// Arrange
69176926
ConsensusCommitManager manager = createConsensusCommitManager(isolation);
@@ -6974,7 +6983,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
69746983
void
69756984
get_WithConjunction_ForCommittedRecordWhoseBeforeImageMatchesConjunction_ShouldNotReturnRecord(
69766985
Isolation isolation, boolean readOnly)
6977-
throws UnknownTransactionStatusException, CrudException, ExecutionException,
6986+
throws UnknownTransactionStatusException,
6987+
CrudException,
6988+
ExecutionException,
69786989
CommitException {
69796990
// Arrange
69806991
ConsensusCommitManager manager = createConsensusCommitManager(isolation);
@@ -7044,7 +7055,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
70447055
void
70457056
scan_WithConjunction_ForPreparedRecordWhoseBeforeImageMatchesConjunction_ShouldReturnRecordAfterLazyRecovery(
70467057
Isolation isolation, boolean readOnly)
7047-
throws UnknownTransactionStatusException, CrudException, ExecutionException,
7058+
throws UnknownTransactionStatusException,
7059+
CrudException,
7060+
ExecutionException,
70487061
CommitException {
70497062
// Arrange
70507063
ConsensusCommitManager manager = createConsensusCommitManager(isolation);
@@ -7117,7 +7130,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
71177130
void
71187131
scan_WithConjunction_ForCommittedRecordWhoseBeforeImageMatchesConjunction_ShouldNotReturnRecord(
71197132
Isolation isolation, boolean readOnly)
7120-
throws UnknownTransactionStatusException, CrudException, ExecutionException,
7133+
throws UnknownTransactionStatusException,
7134+
CrudException,
7135+
ExecutionException,
71217136
CommitException {
71227137
// Arrange
71237138
ConsensusCommitManager manager = createConsensusCommitManager(isolation);
@@ -7197,7 +7212,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
71977212
void
71987213
scan_WithConjunctionAndLimit_ForCommittedRecordWhoseBeforeImageMatchesConjunction_ShouldNotReturnRecord(
71997214
Isolation isolation, boolean readOnly)
7200-
throws UnknownTransactionStatusException, CrudException, ExecutionException,
7215+
throws UnknownTransactionStatusException,
7216+
CrudException,
7217+
ExecutionException,
72017218
CommitException {
72027219
// Arrange
72037220
ConsensusCommitManager manager = createConsensusCommitManager(isolation);
@@ -7295,7 +7312,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
72957312
void
72967313
getScanner_WithConjunction_ForPreparedRecordWhoseBeforeImageMatchesConjunction_ShouldReturnRecordAfterLazyRecovery(
72977314
Isolation isolation, boolean readOnly)
7298-
throws UnknownTransactionStatusException, CrudException, ExecutionException,
7315+
throws UnknownTransactionStatusException,
7316+
CrudException,
7317+
ExecutionException,
72997318
CommitException {
73007319
// Arrange
73017320
ConsensusCommitManager manager = createConsensusCommitManager(isolation);
@@ -7371,7 +7390,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
73717390
void
73727391
getScanner_WithConjunction_ForCommittedRecordWhoseBeforeImageMatchesConjunction_ShouldNotReturnRecord(
73737392
Isolation isolation, boolean readOnly)
7374-
throws UnknownTransactionStatusException, CrudException, ExecutionException,
7393+
throws UnknownTransactionStatusException,
7394+
CrudException,
7395+
ExecutionException,
73757396
CommitException {
73767397
// Arrange
73777398
ConsensusCommitManager manager = createConsensusCommitManager(isolation);
@@ -7454,7 +7475,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
74547475
void
74557476
getScanner_WithConjunctionAndLimit_ForCommittedRecordWhoseBeforeImageMatchesConjunction_ShouldNotReturnRecord(
74567477
Isolation isolation, boolean readOnly)
7457-
throws UnknownTransactionStatusException, CrudException, ExecutionException,
7478+
throws UnknownTransactionStatusException,
7479+
CrudException,
7480+
ExecutionException,
74587481
CommitException {
74597482
// Arrange
74607483
ConsensusCommitManager manager = createConsensusCommitManager(isolation);
@@ -7555,7 +7578,9 @@ public void scanAndUpdate_ScanWithIndexGiven_ShouldUpdate(Isolation isolation)
75557578
void
75567579
commit_ConflictingExternalUpdate_DifferentGetButSameRecordReturned_ShouldThrowShouldBehaveCorrectly(
75577580
Isolation isolation)
7558-
throws UnknownTransactionStatusException, CrudException, RollbackException,
7581+
throws UnknownTransactionStatusException,
7582+
CrudException,
7583+
RollbackException,
75597584
CommitException {
75607585
// Arrange
75617586
ConsensusCommitManager manager = createConsensusCommitManager(isolation);

0 commit comments

Comments
 (0)