Skip to content

Commit 2491527

Browse files
committed
refactor(common): move AbstractDistributedTransactionProvider from api to common
AbstractDistributedTransactionProvider is an internal abstract helper base, not part of the public API; its sibling abstract bases (AbstractDistributedTransaction, AbstractDistributedTransactionManager, AbstractTwoPhaseCommitTransaction, ...) already live in com.scalar.db.common, so it belongs there too. The public SPI contract, the DistributedTransactionProvider interface, stays in com.scalar.db.api. The in-tree subclasses (ConsensusCommitProvider, JdbcTransactionProvider) are updated to the new import. Out-of-tree subclasses that extend this base (e.g. the cluster's transaction providers) must update their import to com.scalar.db.common.AbstractDistributedTransactionProvider in a paired change.
1 parent fcc76cb commit 2491527

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

core/src/main/java/com/scalar/db/api/AbstractDistributedTransactionProvider.java renamed to core/src/main/java/com/scalar/db/common/AbstractDistributedTransactionProvider.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
1-
package com.scalar.db.api;
1+
package com.scalar.db.common;
22

3-
import com.scalar.db.common.ActiveTransactionManagedDistributedTransactionManager;
4-
import com.scalar.db.common.ActiveTransactionManagedTwoPhaseCommitTransactionManager;
5-
import com.scalar.db.common.AttributePropagatingDistributedTransactionManager;
6-
import com.scalar.db.common.StateManagedDistributedTransactionManager;
7-
import com.scalar.db.common.StateManagedTwoPhaseCommitTransactionManager;
3+
import com.scalar.db.api.DistributedTransactionManager;
4+
import com.scalar.db.api.DistributedTransactionProvider;
5+
import com.scalar.db.api.TwoPhaseCommitTransactionManager;
86
import com.scalar.db.config.DatabaseConfig;
97
import javax.annotation.Nullable;
108

core/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package com.scalar.db.transaction.consensuscommit;
22

3-
import com.scalar.db.api.AbstractDistributedTransactionProvider;
43
import com.scalar.db.api.DistributedTransactionAdmin;
54
import com.scalar.db.api.DistributedTransactionManager;
65
import com.scalar.db.api.TwoPhaseCommit;
76
import com.scalar.db.api.TwoPhaseCommitTransactionManager;
7+
import com.scalar.db.common.AbstractDistributedTransactionProvider;
88
import com.scalar.db.config.DatabaseConfig;
99

1010
public class ConsensusCommitProvider extends AbstractDistributedTransactionProvider {

core/src/main/java/com/scalar/db/transaction/jdbc/JdbcTransactionProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package com.scalar.db.transaction.jdbc;
22

3-
import com.scalar.db.api.AbstractDistributedTransactionProvider;
43
import com.scalar.db.api.DistributedTransactionAdmin;
54
import com.scalar.db.api.DistributedTransactionManager;
65
import com.scalar.db.api.TwoPhaseCommit;
76
import com.scalar.db.api.TwoPhaseCommitTransactionManager;
7+
import com.scalar.db.common.AbstractDistributedTransactionProvider;
88
import com.scalar.db.config.DatabaseConfig;
99
import com.scalar.db.storage.jdbc.JdbcConfig;
1010
import javax.annotation.Nullable;

0 commit comments

Comments
 (0)