Merge pull request #12 from robertoschwald/feature/fix_validateConfig

Fix validateConfig, add tests

Author: robertoschwald

.github/workflows/build.yml

@@ -29,6 +29,9 @@ jobs:
       - name: Build the project
         run: npm run build
 
+      - name: Test the project
+        run: npm test
+
       - name: List, audit, fix outdated dependencies and build again
         run: |
           npm list --outdated

.github/workflows/npm-publish.yml

@@ -57,6 +57,9 @@ jobs:
       - name: Build
         run: npm run build
 
+      - name: Test the project
+        run: npm test
+
       - name: Show npm pack file list (dry-run)
         run: npm pack --dry-run
 

package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-obis-powermeter",
   "displayName": "Homebridge OBIS Powermeter",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Plugin for OBIS smart meter devices (SML/D0) to read power, energy, and voltages.",
   "license": "Apache-2.0",
   "author": "Robert Oschwald <robertoschwald@users.noreply.github.com>",

src/Platform.ts

@@ -112,7 +112,8 @@ export class HomebridgeObisPowerConsumption implements DynamicPlatformPlugin {
   }
 
   private validateConfig(): boolean {
-    return this.config.serialPort.length > 0;
+    const sp = (this.config as Partial<PluginConfig> | undefined)?.serialPort;
+    return typeof sp === 'string' && sp.trim().length > 0;
   }
 
   private obisOptions: ObisSerialOptions = {

src/__tests__/Platform.test.ts

@@ -52,6 +52,25 @@ describe('HomebridgeSmlPowerConsumption', () => {
     expect((platform as any).validateConfig()).toBe(false);
   });
 
+  it('validateConfig returns false when serialPort is missing', () => {
+    const cfg = { ...config } as any;
+    delete cfg.serialPort;
+    const p = new HomebridgeObisPowerConsumption(log, cfg, api);
+    expect((p as any).validateConfig()).toBe(false);
+  });
+
+  it('validateConfig returns false for whitespace-only serialPort', () => {
+    const cfg = { ...config, serialPort: '  \t  ' } as any;
+    const p = new HomebridgeObisPowerConsumption(log, cfg, api);
+    expect((p as any).validateConfig()).toBe(false);
+  });
+
+  it('validateConfig returns false for non-string serialPort', () => {
+    const cfg = { ...config, serialPort: 12345 as unknown as string } as any;
+    const p = new HomebridgeObisPowerConsumption(log, cfg, api);
+    expect((p as any).validateConfig()).toBe(false);
+  });
+
   it('handles invalid serial port during validation (init throws)', async () => {
     jest.spyOn(SmartMeterObis as any, 'init').mockImplementation(() => {
       throw new Error('open failed');