naming

Author: TomasVotruba

src/Analyzer/DuplicatedScenarioTitlesAnalyzer.php

@@ -33,8 +33,6 @@ public function analyze(array $featureFiles): array
             }
         }
 
-        return array_filter($scenarioNamesToFiles, function (array $files): bool {
-            return count($files) > 1;
-        });
+        return array_filter($scenarioNamesToFiles, fn(array $files): bool => count($files) > 1);
     }
 }

src/Gherkin/GherkinParser.php

@@ -10,7 +10,7 @@
 use Behat\Gherkin\Parser;
 use Webmozart\Assert\Assert;
 
-final class GherkinParser
+final readonly class GherkinParser
 {
     private Parser $parser;
 

src/Rule/DuplicatedScenarioTitleRule.php

@@ -14,7 +14,7 @@
 final readonly class DuplicatedScenarioTitleRule implements RuleInterface
 {
     public function __construct(
-        private DuplicatedScenarioTitlesAnalyzer $duplicatedScenarioNamesAnalyzer
+        private DuplicatedScenarioTitlesAnalyzer $duplicatedScenarioTitlesAnalyzer
     ) {
     }
 
@@ -30,7 +30,7 @@ public function process(
         PatternCollection $patternCollection,
         string $projectDirectory
     ): array {
-        $scenarioNamesToFiles = $this->duplicatedScenarioNamesAnalyzer->analyze($featureFiles);
+        $scenarioNamesToFiles = $this->duplicatedScenarioTitlesAnalyzer->analyze($featureFiles);
 
         $ruleErrors = [];
         foreach ($scenarioNamesToFiles as $scenarioName => $files) {

tests/Analyzer/DuplicatedScenarioNamesAnalyzer/DuplicatedScenarioTitlesAnalyzerTest.php

@@ -10,21 +10,21 @@
 
 final class DuplicatedScenarioTitlesAnalyzerTest extends AbstractTestCase
 {
-    private DuplicatedScenarioTitlesAnalyzer $duplicatedScenarioNamesAnalyzer;
+    private DuplicatedScenarioTitlesAnalyzer $duplicatedScenarioTitlesAnalyzer;
 
     protected function setUp(): void
     {
         parent::setUp();
 
-        $this->duplicatedScenarioNamesAnalyzer = $this->make(DuplicatedScenarioTitlesAnalyzer::class);
+        $this->duplicatedScenarioTitlesAnalyzer = $this->make(DuplicatedScenarioTitlesAnalyzer::class);
     }
 
     public function testSpot(): void
     {
         $featureFiles = BehatMetafilesFinder::findFeatureFiles([__DIR__ . '/Fixture/simple']);
         $this->assertCount(2, $featureFiles);
 
-        $duplicatedScenarioNamesToFiles = $this->duplicatedScenarioNamesAnalyzer->analyze($featureFiles);
+        $duplicatedScenarioNamesToFiles = $this->duplicatedScenarioTitlesAnalyzer->analyze($featureFiles);
 
         $this->assertCount(1, $duplicatedScenarioNamesToFiles);
         $this->assertArrayHasKey('Same scenario name', $duplicatedScenarioNamesToFiles);
@@ -42,7 +42,7 @@ public function testSkipSecondLineDifferent(): void
         $featureFiles = BehatMetafilesFinder::findFeatureFiles([__DIR__ . '/Fixture/no-multi-line']);
         $this->assertCount(2, $featureFiles);
 
-        $duplicatedScenarioNamesToFiles = $this->duplicatedScenarioNamesAnalyzer->analyze($featureFiles);
+        $duplicatedScenarioNamesToFiles = $this->duplicatedScenarioTitlesAnalyzer->analyze($featureFiles);
 
         $this->assertCount(0, $duplicatedScenarioNamesToFiles);
     }