fix: validate table requirement for dine in order

Author: rahulchaudhary2002

app/Http/Requests/Pos/StorePosOrderRequest.php

@@ -3,6 +3,7 @@
 namespace App\Http\Requests\Pos;
 
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Validation\Rule;
 
 class StorePosOrderRequest extends FormRequest
 {
@@ -17,7 +18,7 @@ public function rules(): array
             'outlet_id'          => ['required', 'exists:outlets,id'],
             'order_type'         => ['required', 'in:dine_in,takeaway,delivery'],
             'customer_id'        => ['nullable', 'exists:customers,id'],
-            'dining_table_ids'   => ['nullable', 'array'],
+            'dining_table_ids'   => [Rule::requiredIf($this->input('order_type') === 'dine_in'), 'nullable', 'array', 'min:1'],
             'dining_table_ids.*' => ['exists:dining_tables,id'],
             'note'               => ['nullable', 'string', 'max:1000'],
             'items'              => ['required', 'array', 'min:1'],

resources/js/components/order-split-modal.tsx

@@ -93,29 +93,29 @@ export function OrderSplitModal({ orderId, orderNumber, items, tables = [], onCl
                     </button>
                 </div>
 
+                {/* Table selector — outside scroll area so dropdown isn't clipped */}
+                {tables.length > 0 && (
+                    <div className="border-b border-border dark:border-stone-800 px-4 py-3 space-y-1.5">
+                        <label className="text-xs font-semibold text-foreground">Table for new order</label>
+                        <SearchableSelect
+                            value={diningTableId ?? ''}
+                            placeholder="Same as original order"
+                            onChange={(e) => setDiningTableId(e.target.value ? Number(e.target.value) : null)}
+                        >
+                            <option value="">Same as original order</option>
+                            {tables.map((t) => (
+                                <option key={t.id} value={t.id}>
+                                    {t.dining_area ? `${t.dining_area.name} - ` : ''}{t.name}
+                                </option>
+                            ))}
+                        </SearchableSelect>
+                    </div>
+                )}
+
                 {/* Content */}
                 <div className="flex-1 overflow-y-auto p-4 space-y-3">
                     <p className="text-xs text-muted-foreground">Select items to move into a new order. The original order keeps the remaining items.</p>
 
-                    {/* Table selector for new order */}
-                    {tables.length > 0 && (
-                        <div className="rounded-lg border border-border dark:border-stone-700 p-3 space-y-1.5">
-                            <label className="text-xs font-semibold text-foreground">Table for new order</label>
-                            <SearchableSelect
-                                value={diningTableId ?? ''}
-                                placeholder="Same as original order"
-                                onChange={(e) => setDiningTableId(e.target.value ? Number(e.target.value) : null)}
-                            >
-                                <option value="">Same as original order</option>
-                                {tables.map((t) => (
-                                    <option key={t.id} value={t.id}>
-                                        {t.dining_area ? `${t.dining_area.name} - ` : ''}{t.name}
-                                    </option>
-                                ))}
-                            </SearchableSelect>
-                        </div>
-                    )}
-
                     {/* Items */}
                     {activeItems.map((item) => {
                         const max = parseFloat(String(item.quantity));

resources/js/pages/pos/index.tsx

@@ -679,6 +679,10 @@ export default function PosIndex({ outlets, categories, foods, customers: initia
 
     function placeOrder() {
         if (cart.length === 0 || !outletId) return;
+        if (orderType === 'dine_in' && tableIds.length === 0) {
+            showError('Please select at least one table for dine-in orders.');
+            return;
+        }
         setProcessing(true);
         const csrf = (document.querySelector('meta[name="csrf-token"]') as HTMLMetaElement | null)?.content ?? '';
         fetch(posPlaceOrder.url(), {