Skip to content

Commit bf253f9

Browse files
committed
Fix broken asset paths in per-game theme CSS (double assets/ prefix)
The per-game theme SCSS compiles to <game>/assets/theme-*.min.css, so a url('assets/foo') inside it resolves to <game>/assets/assets/foo and 404s (fortnite already used the correct bare-filename form). This left: - destiny / elite / battlefield1: custom @font-face fonts 404ing, silently falling back to system fonts - rainbow6 (both themes) & battlefield1 (dark): the ESL/Ubisoft/EA/DICE group-logo labels blank, since text is hidden via text-indent and the logo image failed to load Drop the redundant assets/ prefix so the bare filename resolves correctly (verified live: corrected paths return 200 and the r6 logos paint at 50x23). Note: csgo's blank group labels (fixed separately) are a different bug - its inlined styles.css uses correct paths, but the labels collapse to width:0, so that fix forces plain-text labels instead.
1 parent b52b228 commit bf253f9

7 files changed

Lines changed: 16 additions & 16 deletions

File tree

games/battlefield1/theme-dark.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
@font-face {
44
font-family: 'Purista';
5-
src: url( 'assets/purista-medium.woff2' ) format( 'woff2' ),
6-
url( 'assets/purista-medium.woff' ) format( 'woff' );
5+
src: url( 'purista-medium.woff2' ) format( 'woff2' ),
6+
url( 'purista-medium.woff' ) format( 'woff' );
77
font-weight: normal;
88
font-style: normal;
99
font-display: swap;
@@ -59,13 +59,13 @@ a:active {
5959
}
6060

6161
.group-label.ea {
62-
background-image: url( 'assets/logo-ea.png' );
62+
background-image: url( 'logo-ea.png' );
6363
text-indent: -9999px;
6464
width: 50px;
6565
}
6666

6767
.group-label.dice {
68-
background-image: url( 'assets/logo-dice.png' );
68+
background-image: url( 'logo-dice.png' );
6969
text-indent: -9999px;
7070
width: 50px;
7171
}

games/destiny/theme-dark.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
font-family: 'Destiny';
55
font-weight: normal;
66
font-style: normal;
7-
src: url( 'assets/destiny-font.woff2' ) format( 'woff2' ),
8-
url( 'assets/destiny-font.woff' ) format( 'woff' );
7+
src: url( 'destiny-font.woff2' ) format( 'woff2' ),
8+
url( 'destiny-font.woff' ) format( 'woff' );
99
font-display: swap;
1010
}
1111

games/destiny/theme-light.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
font-family: 'Destiny';
55
font-weight: normal;
66
font-style: normal;
7-
src: url( 'assets/destiny-font.woff2' ) format( 'woff2' ),
8-
url( 'assets/destiny-font.woff' ) format( 'woff' );
7+
src: url( 'destiny-font.woff2' ) format( 'woff2' ),
8+
url( 'destiny-font.woff' ) format( 'woff' );
99
font-display: swap;
1010
}
1111

games/elite/theme-dark.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
font-family: 'Eurostile';
55
font-style: normal;
66
font-weight: normal;
7-
src: url( 'assets/eurostile.woff2' ) format( 'woff2' ),
8-
url( 'assets/eurostile.woff' ) format( 'woff' );
7+
src: url( 'eurostile.woff2' ) format( 'woff2' ),
8+
url( 'eurostile.woff' ) format( 'woff' );
99
font-display: swap;
1010
}
1111

games/elite/theme-light.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
font-family: 'Eurostile';
55
font-style: normal;
66
font-weight: normal;
7-
src: url( 'assets/eurostile.woff2' ) format( 'woff2' ),
8-
url( 'assets/eurostile.woff' ) format( 'woff' );
7+
src: url( 'eurostile.woff2' ) format( 'woff2' ),
8+
url( 'eurostile.woff' ) format( 'woff' );
99
font-display: swap;
1010
}
1111

games/rainbow6/theme-dark.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
@import "../../web-assets/theme-dark";
22

33
.group-label.esl {
4-
background-image: url( 'assets/logo-esl.png' );
4+
background-image: url( 'logo-esl.png' );
55
text-indent: -9999px;
66
width: 50px;
77
}
88

99
.group-label.ubisoft {
10-
background-image: url( 'assets/logo-ubisoft.png' );
10+
background-image: url( 'logo-ubisoft.png' );
1111
text-indent: -9999px;
1212
width: 50px;
1313
}

games/rainbow6/theme-light.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
@import "../../web-assets/theme-light";
22

33
.group-label.esl {
4-
background-image: url( 'assets/logo-esl.png' );
4+
background-image: url( 'logo-esl.png' );
55
text-indent: -9999px;
66
width: 50px;
77
}
88

99
.group-label.ubisoft {
10-
background-image: url( 'assets/logo-ubisoft.png' );
10+
background-image: url( 'logo-ubisoft.png' );
1111
text-indent: -9999px;
1212
width: 50px;
1313
}

0 commit comments

Comments
 (0)