fix: use console_error_panic_hook correctly

Author: oshikiri

engine/Cargo.toml

@@ -13,15 +13,11 @@ crate-type = ["cdylib", "rlib"]
 
 [features]
 default = []
+debug-panic-hook = ["dep:console_error_panic_hook"]
 
 [dependencies]
 wasm-bindgen = "0.2.108"
 js-sys = "0.3.85"
-
-# The `console_error_panic_hook` crate provides better debugging of panics by
-# logging them with `console.error`. This is great for development, but requires
-# all the `std::fmt` and `std::panicking` infrastructure, so isn't great for
-# code size when deploying.
 console_error_panic_hook = { version = "0.1.7", optional = true }
 
 [dev-dependencies]

engine/src/README.md

@@ -7,9 +7,11 @@ echo -e "];\n}" >> parameters.rs
 ```
 
 ## Debugging
-```rs
-extern crate console_error_panic_hook;
-use std::panic;
+panic の詳細を DevTools に出したい場合は feature を有効化します。
 
-panic::set_hook(Box::new(console_error_panic_hook::hook));
+- feature: `debug-panic-hook`
+- hook 初期化: `newBoard` / `Game::create` 呼び出し時に `set_once()` を実行
+
+```sh
+wasm-pack build --dev -- --features debug-panic-hook
 ```

engine/src/board.rs

@@ -9,6 +9,7 @@ use wasm_bindgen::prelude::*;
 use wasm_bindgen::JsValue;
 
 use crate::parameters::parameters::PATTERN_INSTANCES;
+use crate::utils;
 
 #[wasm_bindgen]
 #[derive(Clone, Debug, PartialEq)]
@@ -20,6 +21,7 @@ pub struct Board {
 #[allow(dead_code)]
 #[wasm_bindgen(js_name = newBoard)]
 pub fn new_board() -> Board {
+    utils::set_panic_hook();
     Board {
         first: 0b_00000000_00000000_00000000_00001000_00010000_00000000_00000000_00000000,
         second: 0b_00000000_00000000_00000000_00010000_00001000_00000000_00000000_00000000,

engine/src/game.rs

@@ -5,6 +5,7 @@ use crate::board::Player;
 use crate::board::*;
 use crate::console_log;
 use crate::strategy::*;
+use crate::utils;
 
 #[wasm_bindgen]
 pub struct Game {
@@ -37,6 +38,7 @@ impl Game {
 #[wasm_bindgen]
 impl Game {
     pub fn create(player_human: Player, opponent_strategy_type: StrategyType) -> Game {
+        utils::set_panic_hook();
         let current_board = new_board();
         let opponent_strategy: Box<dyn Strategy> = match opponent_strategy_type {
             StrategyType::NumdiskLookahead => Box::new(NumdiskLookaheadStrategy {}),

engine/src/utils.rs

@@ -10,14 +10,7 @@ macro_rules! console_log {
     }
 }
 
-#[allow(dead_code)]
 pub fn set_panic_hook() {
-    // When the `console_error_panic_hook` feature is enabled, we can call the
-    // `set_panic_hook` function at least once during initialization, and then
-    // we will get better error messages if our code ever panics.
-    //
-    // For more details see
-    // https://github.com/rustwasm/console_error_panic_hook#readme
-    #[cfg(feature = "console_error_panic_hook")]
+    #[cfg(all(target_arch = "wasm32", feature = "debug-panic-hook"))]
     console_error_panic_hook::set_once();
 }