TRUNK-6706: Disable hibernate.generate_statistics by default#6354
Open
Janani-Balasooriya wants to merge 2 commits into
Open
TRUNK-6706: Disable hibernate.generate_statistics by default#6354Janani-Balasooriya wants to merge 2 commits into
Janani-Balasooriya wants to merge 2 commits into
Conversation
Member
|
@claude review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6354 +/- ##
============================================
+ Coverage 59.45% 59.58% +0.13%
- Complexity 9555 9567 +12
============================================
Files 731 731
Lines 38399 38399
Branches 5598 5598
============================================
+ Hits 22829 22879 +50
+ Misses 13532 13479 -53
- Partials 2038 2041 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Janani-Balasooriya
force-pushed
the
TRUNK-6706
branch
from
July 21, 2026 11:34
13ff9a6 to
62113e8
Compare
|
Contributor
|
@claude review |
jwnasambu
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of what I changed
Changed the default value of
hibernate.generate_statisticsinapi/src/main/resources/hibernate.default.propertiesfromtruetofalse. Statistics generation maintains counters on every query, entity, collection, and cache operation, and the only consumer in core is a shutdown-time debug log dump, so this default was adding overhead for data that's almost never read.No code changes were needed to preserve explicit overrides:
HibernateContextDAO.mergeDefaultRuntimeProperties()already only applies a default when the key isn't already present in the user's runtime properties, so anyone settinghibernate.generate_statistics=truethemselves will have that value preserved.Added two unit tests to
ContextDAOTest.java:should_defaultGenerateStatisticsToFalse()should_notOverrideExplicitGenerateStatisticsSetting()Note: I noticed three tests in
ContextTest.javacheck cache eviction using Hibernate's statistics counter, which no longer updates by default after this change. Flagging in case a follow-up is wanted, happy to help fix if so.I noticed this ticket is labeled
backport. Should this fix also be applied to older maintained branches, or is that handled separately by the team?Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6706
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
./mvnw clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master