TRUNK-6692: Make test resource path constants immutable#6343
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6343 +/- ##
============================================
- Coverage 59.47% 59.45% -0.03%
- Complexity 9539 9540 +1
============================================
Files 731 731
Lines 38323 38323
Branches 5587 5587
============================================
- Hits 22793 22784 -9
- Misses 13492 13500 +8
- Partials 2038 2039 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@claude review |
jwnasambu
reviewed
Jul 17, 2026
Contributor
There was a problem hiding this comment.
@imandeepduhan Thanks this L.G.T.M. Kindly update this branch with the latest changes from master and you be good to go.
jwnasambu
approved these changes
Jul 17, 2026
Contributor
Author
|
@jwnasambu Thanks ! I updated my branch with the latest changes from master. It is already up to date. |
Contributor
Author
ibacher
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Marks the test resource path constants as
finalin the Liquibase test classes, as they are initialized only once and are never reassigned.Why is this needed?
This is a small code quality improvement that makes the code's intent clearer by indicating that these values are immutable, without introducing any functional changes.
JIRA TICKET : https://openmrs.atlassian.net/browse/TRUNK-6692