plugins: force IP version depending on static HE IP

When a Static Hosted Engine IP is provided, we automatically set the
he_force_ip6 or he_force_ip4 variables.

This because otherwise we end up in situations where the hosted engine
has an IPv6 address, but tries to connect to the host via IPv4 or the
other way around.

If we start hosted-engine-setup and we specify a static IP address for
the Hosted Engine. We need to handle this better.
Cause now the following could happen:
- A static IPv6 is passed to hosted-engine-setup for the HE
- he_host_ip is not defined
- No he_force_ip6/he_force_ip4 specified

-> As no he_host_ip is passed, this is defined within the playbook
-> he_host_ip is derived from the intersection of IPs the
he_host_address resolves to and the output of `hostname -I`.
The first IP from that intersect is chosen as he_host_ip.
-> This host is added to /etc/hosts on the HE.

But now, if you specify a static IP for the HE, this will get configured
independently from what was set as he_host_ip.
This means that if your host has both IPv4 and IPv6, the he_host_ip
could be an IPv4, and thus the /etc/hosts in the HE contains the IPv4
address of the host.
But if you then specified an IPv6 address for the HE, the HE will be
configured with an IPv6-only address. And in the final stages the HE
will try to connect to your host, it resolves to IPv4 address, and this
will fail, because the HE only has an IPv6 address.

Therefor we set he_force_ip6 or he_force_ip4 depending on the address
version you specify as HE IP.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>

Author: dupondje

src/plugins/gr-he-ansiblesetup/core/misc.py

@@ -22,6 +22,7 @@
 
 
 import gettext
+import netaddr
 import re
 import uuid
 
@@ -434,6 +435,25 @@ def _closeup(self):
             ]
         }
 
+        # If a static CIDR is provided for the Hosted Engine VM,
+        # then we force connection to the host with same IP version
+        # Otherwise we end up in a situation where the IPv6 only
+        # HE VM tries to connect to the host with an IPv4 address
+        if self.environment[ohostedcons.CloudInit.VM_STATIC_CIDR]:
+            ip = netaddr.IPNetwork(
+                self.environment[ohostedcons.CloudInit.VM_STATIC_CIDR]
+            )
+            if ip.version == 6:
+                if self.environment[ohostedcons.NetworkEnv.FORCE_IPV4]:
+                    raise RuntimeError(
+                        _('Cannot force IPv4 when HE static IP is IPv6'))
+                bootstrap_vars['he_force_ip6'] = True
+            else:
+                if self.environment[ohostedcons.NetworkEnv.FORCE_IPV6]:
+                    raise RuntimeError(
+                        _('Cannot force IPv6 when HE static IP is IPv4'))
+                bootstrap_vars['he_force_ip4'] = True
+
         if self.environment[
             ohostedcons.CoreEnv.RENEW_PKI_ON_RESTORE
         ] is not None: