SelectBox: only one item can be rendered as selected at the same time

Author: dg

examples/custom-control.php

@@ -93,7 +93,8 @@ public function getControl()
 
 			. Helpers::createSelectBox(
 					[1 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12],
-					['selected?' => $this->month]
+					[],
+					$this->month
 				)->name($name . '[month]')
 
 			. Html::el('input', [

src/Forms/Controls/MultiSelectBox.php

@@ -69,9 +69,9 @@ public function getControl(): Nette\Utils\Html
 		return Nette\Forms\Helpers::createSelectBox(
 			$items,
 			[
-				'selected?' => $this->value,
 				'disabled:' => is_array($this->disabled) ? $this->disabled : NULL,
-			] + $this->optionAttributes
+			] + $this->optionAttributes,
+			$this->value
 		)->addAttributes(parent::getControl()->attrs)->multiple(TRUE);
 	}
 

src/Forms/Controls/SelectBox.php

@@ -99,9 +99,9 @@ public function getControl(): Nette\Utils\Html
 		return Nette\Forms\Helpers::createSelectBox(
 			$items,
 			[
-				'selected?' => $this->value,
 				'disabled:' => is_array($this->disabled) ? $this->disabled : NULL,
-			] + $this->optionAttributes
+			] + $this->optionAttributes,
+			$this->value
 		)->addAttributes(parent::getControl()->attrs);
 	}
 

src/Forms/Helpers.php

@@ -191,6 +191,9 @@ public static function createSelectBox(array $items, array $optionAttrs = NULL,
 						. htmlspecialchars((string) $caption, ENT_NOQUOTES, 'UTF-8')
 						. '</option>';
 				}
+				if ($selected === $value) {
+					unset($optionAttrs['selected'], $option->attrs['selected']);
+				}
 			}
 			$res .= $tmp;
 			$tmp = '';

tests/Forms/Controls.MultiSelectBox.render.phpt

@@ -50,6 +50,17 @@ test(function () { // selected
 });
 
 
+test(function () { // selected 2x
+	$form = new Form;
+	$input = $form->addMultiSelect('list', 'Label', [
+		['a' => 'First'],
+		['a' => 'First'],
+	])->setValue('a');
+
+	Assert::same('<select name="list[]" id="frm-list" multiple><optgroup label="0"><option value="a" selected>First</option></optgroup><optgroup label="1"><option value="a" selected>First</option></optgroup></select>', (string) $input->getControl());
+});
+
+
 test(function () { // translator & groups
 	$form = new Form;
 	$input = $form->addMultiSelect('list', 'Label', [

tests/Forms/Controls.SelectBox.render.phpt

@@ -50,6 +50,17 @@ test(function () { // selected
 });
 
 
+test(function () { // selected 2x
+	$form = new Form;
+	$input = $form->addSelect('list', 'Label', [
+		['a' => 'First'],
+		['a' => 'First'],
+	])->setValue('a');
+
+	Assert::same('<select name="list" id="frm-list"><optgroup label="0"><option value="a" selected>First</option></optgroup><optgroup label="1"><option value="a">First</option></optgroup></select>', (string) $input->getControl());
+});
+
+
 test(function () { // translator & groups
 	$form = new Form;
 	$input = $form->addSelect('list', 'Label', [

tests/Forms/Helpers.createSelectBox.phpt

@@ -87,6 +87,15 @@ test(function () {
 		)
 	);
 
+	Assert::same(
+		'<select><optgroup label="0"><option value="a" selected>First</option></optgroup><optgroup label="1"><option value="a">First</option></optgroup></select>',
+		(string) Helpers::createSelectBox(
+			[['a' => 'First'], ['a' => 'First']],
+			[],
+			'a'
+		)
+	);
+
 	Assert::same(
 		'<select><option value="a" selected>First</option><option value="b" selected>Second</option></select>',
 		(string) Helpers::createSelectBox(
@@ -95,4 +104,13 @@ test(function () {
 			['a', 'b']
 		)
 	);
+
+	Assert::same(
+		'<select><optgroup label="0"><option value="a" selected>First</option></optgroup><optgroup label="1"><option value="a" selected>First</option></optgroup></select>',
+		(string) Helpers::createSelectBox(
+			[['a' => 'First'], ['a' => 'First']],
+			[],
+			['a', 'b']
+		)
+	);
 });