refactor: consolidate all API functions into client.ts

Move all WAHA API calls from view files and services into src/client.ts for centralized session management. Functions now use getSession() to retrieve session from appState internally.

Moved functions:
- loadSessions, logoutSession, deleteSession (from SessionsView)
- loadChats (from ChatsView)
- loadContacts, loadChatDetails, loadOlderMessages, sendMessage (from ConversationView)
- pollChats, fetchMyProfile (from PollingService)

Updated imports and call signatures across:
- src/index.ts
- src/views/ChatsView.ts
- src/views/ConversationView.ts
- src/views/SessionsView.ts
- src/views/QRCodeView.ts
- src/views/ChatListManager.ts
- src/services/PollingService.ts

Also added copyToClipboard utility for platform-specific clipboard operations.

Author: muhammedaksam

src/client.ts

@@ -17,19 +17,23 @@ import {
   pinMessage,
   deleteMessage,
   reactToMessage,
+  copyToClipboard,
+  loadMessages,
+  loadChats,
+  loadSessions,
+  logoutSession,
+  deleteSession,
+  loadContacts,
+  loadOlderMessages,
 } from "./client"
 import { appState } from "./state/AppState"
 import { Footer } from "./components/Footer"
 import { ContextMenu, handleContextMenuKey, getSelectedMenuItem } from "./components/ContextMenu"
-import { deleteSession, logoutSession, SessionsView } from "./views/SessionsView"
-import { loadSessions } from "./views/SessionsView"
-import { loadChats, focusSearchInput, blurSearchInput, clearSearchInput } from "./views/ChatsView"
+import { SessionsView } from "./views/SessionsView"
+import { focusSearchInput, blurSearchInput, clearSearchInput } from "./views/ChatsView"
 import {
-  loadMessages,
-  loadContacts,
   scrollConversation,
   destroyConversationScrollBox,
-  loadOlderMessages,
   focusMessageInput,
   blurMessageInput,
 } from "./views/ConversationView"
@@ -234,7 +238,7 @@ async function main() {
     debugLog("App", `Found working session: ${workingSession.name}, switching to chats view`)
     appState.setCurrentSession(workingSession.name)
     appState.setCurrentView("chats")
-    await loadChats(workingSession.name)
+    await loadChats()
     pollingService.start(workingSession.name)
   } else {
     // No working session - show QR view for login
@@ -337,9 +341,7 @@ async function main() {
 
     // Execute context menu action
     const executeContextMenuAction = async (actionId: string, contextMenu: ContextMenuState) => {
-      if (!state.currentSession || !contextMenu?.targetId) return
-
-      const session = state.currentSession
+      if (!contextMenu?.targetId) return
       const targetId = contextMenu.targetId
 
       debugLog("ContextMenu", `Executing action: ${actionId} on ${contextMenu.type} ${targetId}`)
@@ -352,21 +354,21 @@ async function main() {
               const chat = contextMenu.targetData as { _chat?: { archived?: boolean } }
               const isArchivedChat = chat?._chat?.archived === true
               if (isArchivedChat) {
-                await unarchiveChat(session, targetId)
+                await unarchiveChat(targetId)
               } else {
-                await archiveChat(session, targetId)
+                await archiveChat(targetId)
               }
               // Refresh chat list
-              await loadChats(session)
+              await loadChats()
               break
             }
             case "unread":
-              await markChatUnread(session, targetId)
-              await loadChats(session)
+              await markChatUnread(targetId)
+              await loadChats()
               break
             case "delete":
-              await deleteChat(session, targetId)
-              await loadChats(session)
+              await deleteChat(targetId)
+              await loadChats()
               break
           }
         } else if (contextMenu.type === "message") {
@@ -384,45 +386,53 @@ async function main() {
               break
             }
             case "copy": {
-              // Copy message text to clipboard
+              // Copy message text to system clipboard
               const message = contextMenu.targetData as { body?: string }
               if (message?.body) {
-                // For terminal apps, we can't easily access clipboard
-                // But we can log it or implement native clipboard later
-                debugLog("ContextMenu", `Copy text: ${message.body}`)
+                const copied = await copyToClipboard(message.body)
+                debugLog("ContextMenu", copied ? `Copied to clipboard` : `Clipboard copy failed`)
               }
               break
             }
             case "star": {
               const message = contextMenu.targetData as { isStarred?: boolean }
               const isStarred = message?.isStarred === true
               if (state.currentChatId) {
-                await starMessage(session, targetId, state.currentChatId, !isStarred)
+                await starMessage(targetId, state.currentChatId, !isStarred)
                 // Refresh messages
-                await loadMessages(session, state.currentChatId)
+                await loadMessages(state.currentChatId)
               }
               break
             }
             case "pin": {
               if (state.currentChatId) {
-                await pinMessage(session, state.currentChatId, targetId)
-                await loadMessages(session, state.currentChatId)
+                await pinMessage(state.currentChatId, targetId)
+                await loadMessages(state.currentChatId)
               }
               break
             }
             case "react": {
               // For now, add a thumbs up reaction
               // Could show a sub-menu for emoji selection later
-              await reactToMessage(session, targetId, "👍")
+              await reactToMessage(targetId, "👍")
               break
             }
             case "delete": {
               if (state.currentChatId) {
-                await deleteMessage(session, state.currentChatId, targetId)
-                await loadMessages(session, state.currentChatId)
+                await deleteMessage(state.currentChatId, targetId)
+                await loadMessages(state.currentChatId)
               }
               break
             }
+            case "forward": {
+              // TODO: Implement chat picker UI for selecting destination
+              // For now, just log that forward was requested
+              debugLog(
+                "ContextMenu",
+                `Forward requested for message: ${targetId} - need chat picker UI`
+              )
+              break
+            }
           }
         }
       } catch (error) {
@@ -459,7 +469,7 @@ async function main() {
       if (state.currentView === "sessions") {
         await loadSessions()
       } else if (state.currentView === "chats" && state.currentSession) {
-        await loadChats(state.currentSession)
+        await loadChats()
       }
     }
 
@@ -623,7 +633,7 @@ async function main() {
           appState.setCurrentSession(selectedSession.name)
           appState.setCurrentView("chats")
           appState.setSelectedChatIndex(0) // Reset chat selection
-          await loadChats(selectedSession.name)
+          await loadChats()
           pollingService.start(selectedSession.name)
         }
       } else if (state.currentView === "chats" && state.chats.length > 0) {
@@ -648,8 +658,8 @@ async function main() {
           // Destroy old scroll box before loading new messages
           destroyConversationScrollBox()
           // Load contacts in background to populate cache
-          loadContacts(state.currentSession)
-          await loadMessages(state.currentSession, chatId)
+          loadContacts()
+          await loadMessages(chatId)
         }
       }
     }
@@ -822,7 +832,7 @@ async function main() {
       if (state.currentSession) {
         appState.setCurrentView("chats")
         appState.setSelectedChatIndex(0)
-        await loadChats(state.currentSession)
+        await loadChats()
       }
     }
   })

src/index.ts

@@ -4,10 +4,8 @@
  */
 
 import { appState } from "../state/AppState"
-import { getClient } from "../client"
-import { loadMessages } from "../views/ConversationView"
+import { loadMessages, pollChats, fetchMyProfile } from "../client"
 import { debugLog } from "../utils/debug"
-import type { ChatSummary } from "@muhammedaksam/waha-node"
 
 // Polling intervals in milliseconds
 const CHATS_POLL_INTERVAL = 3000 // 3 seconds for chat list
@@ -24,13 +22,13 @@ class PollingService {
     debugLog("Polling", `Starting polling service for session: ${sessionName}`)
 
     // Fetch current user's profile for self-chat detection
-    this.fetchMyProfile(sessionName)
+    fetchMyProfile()
 
     // Start chats polling
-    this.chatsTimer = setInterval(() => this.pollChats(sessionName), CHATS_POLL_INTERVAL)
+    this.chatsTimer = setInterval(() => this.doPollChats(), CHATS_POLL_INTERVAL)
 
     // Start messages polling (will only actually poll if a chat is selected)
-    this.messagesTimer = setInterval(() => this.pollMessages(sessionName), MESSAGES_POLL_INTERVAL)
+    this.messagesTimer = setInterval(() => this.pollMessages(), MESSAGES_POLL_INTERVAL)
   }
 
   public stop(): void {
@@ -45,30 +43,20 @@ class PollingService {
     debugLog("Polling", "Stopped polling service")
   }
 
-  private async pollChats(sessionName: string): Promise<void> {
+  private async doPollChats(): Promise<void> {
     if (this.isPollingChats) return
     this.isPollingChats = true
 
     try {
-      const client = getClient()
-      const response = await client.chats.chatsControllerGetChatsOverview(sessionName, {
-        limit: 1000,
-      })
-      const chats = (response.data as unknown as ChatSummary[]) || []
-
-      // Update state - Reactivity will handle UI updates if data changed
-      // Note: We might need to optimize this if it causes too many re-renders
-      // But ChatListManager has its own hash check to prevent unnecessary rebuilds
-      appState.setChats(chats)
+      await pollChats()
     } catch {
-      // Silent error for polling to avoid spamming logs
-      // debugLog("Polling", `Error polling chats: ${error}`)
+      // Silent error for polling
     } finally {
       this.isPollingChats = false
     }
   }
 
-  private async pollMessages(sessionName: string): Promise<void> {
+  private async pollMessages(): Promise<void> {
     if (this.isPollingMessages) return
 
     const state = appState.getState()
@@ -84,26 +72,13 @@ class PollingService {
     try {
       // We use loadMessages which already updates the state
       // It fetches the latest 50 messages, which should include any new ones
-      await loadMessages(sessionName, currentChatId)
+      await loadMessages(currentChatId)
     } catch {
       // Silent error
     } finally {
       this.isPollingMessages = false
     }
   }
-
-  private async fetchMyProfile(sessionName: string): Promise<void> {
-    try {
-      const client = getClient()
-      const response = await client.profile.profileControllerGetMyProfile(sessionName)
-      if (response.data) {
-        appState.setMyProfile(response.data)
-        debugLog("Polling", `Fetched my profile: ${response.data.name} (${response.data.id})`)
-      }
-    } catch {
-      debugLog("Polling", "Failed to fetch profile")
-    }
-  }
 }
 
 export const pollingService = new PollingService()

src/services/PollingService.ts

@@ -22,8 +22,9 @@ import {
 } from "../utils/formatters"
 import { debugLog } from "../utils/debug"
 import { appState } from "../state/AppState"
-import { loadMessages, loadContacts, destroyConversationScrollBox } from "./ConversationView"
+import { destroyConversationScrollBox } from "./ConversationView"
 import { ROW_HEIGHT } from "../utils/chatListScroll"
+import { loadContacts, loadMessages } from "../client"
 
 interface ChatRowData {
   box: BoxRenderable
@@ -242,8 +243,8 @@ class ChatListManager {
             appState.setSelectedChatIndex(chatIndex)
 
             // Load contacts and messages
-            loadContacts(currentState.currentSession)
-            loadMessages(currentState.currentSession, chatId)
+            loadContacts()
+            loadMessages(chatId)
           }
         }
       },

src/utils/contacts.ts

@@ -9,13 +9,11 @@ import { appState } from "../state/AppState"
 import { getRenderer } from "../state/RendererContext"
 import { WhatsAppTheme, Icons } from "../config/theme"
 import { debugLog } from "../utils/debug"
-import { getClient } from "../client"
 import type { ActiveFilter } from "../state/AppState"
 import type { ChatSummary } from "@muhammedaksam/waha-node"
 import { chatListManager } from "./ChatListManager"
 import { Logo } from "../components/Logo"
 import { filterChats, countUnreadInArchived, isArchived } from "../utils/filterChats"
-import { loadAllContacts } from "../utils/contacts"
 import {
   searchChatsWithSections,
   flattenSearchResults,
@@ -418,22 +416,3 @@ export function ChatsView() {
     ...components
   )
 }
-
-// Load chats from WAHA API
-export async function loadChats(sessionName: string): Promise<void> {
-  try {
-    debugLog("Chats", `Loading chats for session: ${sessionName}`)
-    const client = getClient()
-    const response = await client.chats.chatsControllerGetChats(sessionName, {})
-    const chats = (response.data as unknown as ChatSummary[]) || []
-    debugLog("Chats", `Loaded ${chats.length} chats`)
-    appState.setChats(chats)
-
-    // Also load all contacts for comprehensive search
-    const allContacts = await loadAllContacts(sessionName)
-    appState.setAllContacts(allContacts)
-  } catch (error) {
-    debugLog("Chats", `Failed to load chats: ${error}`)
-    appState.setChats([])
-  }
-}