Skip to content

Commit 4b3d4d1

Browse files
committed
Merge dev into main
2 parents f192b6d + 935a5ab commit 4b3d4d1

4 files changed

Lines changed: 16 additions & 7 deletions

File tree

.github/sonar-suppressions.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
"id": "S1144",
1111
"reason": "Unused private types or members should be removed - false positives on reflection/serialization patterns"
1212
},
13+
{
14+
"id": "S1192",
15+
"reason": "String literals should not be duplicated - guard clause exception messages are inline by .NET convention, not localizable strings"
16+
},
1317
{
1418
"id": "S1244",
1519
"reason": "Floating point numbers should not be tested for equality - intentional exact comparisons in financial calculations"

.github/workflows/Publish.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
# ==============================================================================
4444
ReSharper_Analysis:
4545
runs-on: ubuntu-latest
46-
timeout-minutes: 15
46+
timeout-minutes: 20
4747
permissions:
4848
contents: read
4949
actions: write
@@ -68,6 +68,9 @@ jobs:
6868
- name: Restore dependencies
6969
run: dotnet restore
7070

71+
- name: Build solution
72+
run: dotnet build QuanTAlib.slnx --no-restore --configuration Debug --nologo -m:1
73+
7174
- name: Prepare SARIF directory
7275
run: mkdir -p .sarif
7376

@@ -80,7 +83,9 @@ jobs:
8083
- name: Run ReSharper InspectCode (SARIF)
8184
run: |
8285
set +e
83-
jb inspectcode QuanTAlib.slnx \
86+
jb inspectcode lib/quantalib.csproj \
87+
--no-build \
88+
--include="**/*.cs" \
8489
--format=sarif \
8590
--output=.sarif/resharper.sarif
8691
rc=$?

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
<!-- S107: "Methods should not have too many parameters" - high-performance SIMD methods require multiple parameters for zero-allocation patterns -->
7474
<!-- S1244: "Do not check floating point equality with exact values" - exact-zero div guards and exact-equality tie detection are fundamental patterns in quantitative indicators -->
7575
<!-- MA0007: "Add comma after the last value" - trailing commas not enforced in this codebase -->
76-
<NoWarn>$(NoWarn);S107;S1144;S1244;S1944;S2053;S2245;S2259;S2583;S2589;S3329;S3604;S3655;S3776;S3949;S3966;S4158;S4347;S5773;S6781;MA0007;MA0048;MA0051;MA0076;RCS1123;RCS1159;IDE0007</NoWarn>
76+
<NoWarn>$(NoWarn);S107;S1144;S1192;S1244;S1944;S2053;S2245;S2259;S2583;S2589;S3329;S3604;S3655;S3776;S3949;S3966;S4158;S4347;S5773;S6781;MA0007;MA0048;MA0051;MA0076;RCS1123;RCS1159;IDE0007</NoWarn>
7777
</PropertyGroup>
7878

7979
<!-- Code Coverage Configuration (for NDepend integration) -->

python/src/Exports.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1387,13 +1387,13 @@ public static int QtlEbsw(double* src, int n, double* dst, int period, int hpPer
13871387
catch { return StatusCodes.QTL_ERR_INTERNAL; }
13881388
}
13891389

1390-
// Eacp: Pattern A (int period, int min, int max, bool useSimd → int)
1390+
// Eacp: (int minPeriod, int maxPeriod, int avgLength, bool enhance → int)
13911391
[UnmanagedCallersOnly(EntryPoint = "qtl_eacp")]
1392-
public static int QtlEacp(double* src, int n, double* dst, int period, int minPeriod, int maxPeriod, int useMedian)
1392+
public static int QtlEacp(double* src, int n, double* dst, int minPeriod, int maxPeriod, int avgLength, int enhance)
13931393
{
13941394
int v = Chk1(src, dst, n); if (v != 0) return v;
1395-
v = ChkPeriod(period); if (v != 0) return v;
1396-
try { Eacp.Batch(Src(src, n), Dst(dst, n), period, minPeriod, maxPeriod, useMedian != 0); return StatusCodes.QTL_OK; }
1395+
v = ChkPeriod(minPeriod); if (v != 0) return v;
1396+
try { Eacp.Batch(Src(src, n), Dst(dst, n), minPeriod, maxPeriod, avgLength, enhance != 0); return StatusCodes.QTL_OK; }
13971397
catch { return StatusCodes.QTL_ERR_INTERNAL; }
13981398
}
13991399

0 commit comments

Comments
 (0)