Commit ba0077a
Fix VS insertion app.config push: drop spurious regex prefix and disambiguate build number (#15790)
The post-roslyn-tools step that pushes vstest.console/app.config and
revision.txt into the VS insertion PR has been silently failing on every
run since it landed.
Two compounding bugs in the source-commit resolution:
1. The primary regex matched 'Updated Updating VS Test Platform from'
but roslyn-tools logs 'Updating VS Test Platform from' (no 'Updated'
prefix). The primary path never fired, so the fallback always ran.
2. The fallback queried '/builds?buildNumber=20260514.9' and took
value[0]. buildNumber is not unique across pipelines — on a typical
day it matches builds from dotnet-roslyn, dotnet-runtime,
microsoft-vstest, microsoft-testfx, dotnet-wpf, and several others.
The fallback returned the first one (e.g. dotnet-roslyn), then tried
to fetch app.config from the microsoft-vstest mirror at that
unrelated SHA, failing with TF401029: GitCommitDoesNotExistException.
Drop the bogus 'Updated ' prefix from the primary regex (verified
against the actual log line in build 2975466) and filter the fallback
result by definition.name so the right pipeline is picked.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 0069e8d commit ba0077a
1 file changed
Lines changed: 8 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
224 | | - | |
| 224 | + | |
225 | 225 | | |
226 | | - | |
| 226 | + | |
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
236 | 238 | | |
237 | 239 | | |
238 | 240 | | |
239 | 241 | | |
240 | 242 | | |
241 | | - | |
242 | | - | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
243 | 246 | | |
244 | 247 | | |
245 | 248 | | |
| |||
0 commit comments