Code Duplication in Deluxe and SuperDeluxe Classes

[isaiasgh]

There is a significant code duplication issue between the Deluxe and SuperDeluxe classes. Both classes contain identical methods (set, getRate, getStatus, getWifi, and statusChange). This code duplication increases the risk of errors and makes maintenance more difficult, as any change to the duplicated logic would need to be applied in multiple places.

Example of Current Code:

public class Deluxe extends Room {
    public void set(int r, boolean w, boolean s) {
        rate = r;
        wifi = w;
        status = s;
    }

    public int getRate() {
        return rate;
    }

    public boolean getStatus() {
        return status;
    }

    public boolean getWifi() {
        return wifi;
    }

    public void statusChange() {
        status = !status;
    }
}

public class SuperDeluxe extends Room {
    public void set(int r, boolean w, boolean s) {
        rate = r;
        wifi = w;
        status = s;
    }

    public int getRate() {
        return rate;
    }

    public boolean getStatus() {
        return status;
    }

    public boolean getWifi() {
        return wifi;
    }

    public void statusChange() {
        status = !status;
    }
}

Proposed Refactoring:

To address this issue, I recommend using the Pull Up Method refactoring technique. This involves moving the duplicated methods to a common superclass, allowing both Deluxe and SuperDeluxe to inherit these methods and thus eliminating the duplication.

Refactored Code Example:

public abstract class Room {
    protected int rate;
    protected boolean wifi;
    protected boolean status;

    public void set(int r, boolean w, boolean s) {
        rate = r;
        wifi = w;
        status = s;
    }

    public int getRate() {
        return rate;
    }

    public boolean getStatus() {
        return status;
    }

    public boolean getWifi() {
        return wifi;
    }

    public void statusChange() {
        status = !status;
    }
}

public class Deluxe extends Room {
    // No need to redefine methods here, they are inherited from Room
}

public class SuperDeluxe extends Room {
    // No need to redefine methods here, they are inherited from Room
}

Benefits of Refactoring:

• Eliminates Redundancy: The duplicated code will be consolidated in one place, reducing the risk of inconsistencies and errors.
• Improves Reusability: By moving the shared methods to a superclass, any other future classes that might share similar functionality can also inherit from this superclass.
• Enhances Maintainability: With the logic centralized in a single location, making updates or bug fixes becomes much simpler and less error-prone.

Let me know if you need help with implementing this refactoring or have any questions!