Skip to content

Commit 287289c

Browse files
committed
fix(telemetry): inject appVersion at build + auto-resolve at runtime
The released v0.45.1 binary shipped with the source default appVersion="dev" because .goreleaser.yaml had ldflags="-s -w" only, so every startup ping was rejected by the receiver with HTTP 400 (invalid version: regex requires leading digit). Two-layer fix: 1. .goreleaser.yaml now passes -X main.appVersion={{.Version}} so goreleaser-built binaries report the actual release version. 2. Switch to telemetry.SendForModule which prefers debug.ReadBuildInfo Main/Deps when available, falling back to appVersion. This means `go install github.com/lukaszraczylo/ graphql-monitoring-proxy@vX.Y.Z` users also get correct versions without relying on the ldflag. Bumps oss-telemetry to v0.2.1 for SendForModule.
1 parent 21b429c commit 287289c

4 files changed

Lines changed: 5 additions & 4 deletions

File tree

.goreleaser.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ builds:
1919
- arm64
2020
ldflags:
2121
- -s -w
22+
- -X main.appVersion={{.Version}}
2223

2324
archives:
2425
- id: graphql-proxy

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ require (
1818
github.com/lukaszraczylo/ask v0.0.0-20240916204100-6e9ef53a62d9
1919
github.com/lukaszraczylo/go-ratecounter v0.1.12
2020
github.com/lukaszraczylo/go-simple-graphql v1.2.89
21-
github.com/lukaszraczylo/oss-telemetry v0.0.0-20260521005811-e02d51419c52
21+
github.com/lukaszraczylo/oss-telemetry v0.2.1
2222
github.com/redis/go-redis/v9 v9.18.0
2323
github.com/sony/gobreaker v1.0.0
2424
github.com/stretchr/testify v1.11.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ github.com/lukaszraczylo/go-ratecounter v0.1.12 h1:VO6hHYGw/Jy9JUizXf/bS0AI2QX1u
7676
github.com/lukaszraczylo/go-ratecounter v0.1.12/go.mod h1:TqXEOCtFJStk1i0tkipprv1kiDHGon1MVUisjSTBSKM=
7777
github.com/lukaszraczylo/go-simple-graphql v1.2.89 h1:Xbu1Ny+a0lT2Sr2SaSC8mcHmGQDwGD4TJKk4DDd+PwA=
7878
github.com/lukaszraczylo/go-simple-graphql v1.2.89/go.mod h1:PxQYblQDZISmYYj8sNfazAWxAOh1rhAtU208y+uPV8s=
79-
github.com/lukaszraczylo/oss-telemetry v0.0.0-20260521005811-e02d51419c52 h1:HAm1OV/1uYN3VA/HdDNFjwh8KerTLwl1SoxF+IiNf/M=
80-
github.com/lukaszraczylo/oss-telemetry v0.0.0-20260521005811-e02d51419c52/go.mod h1:+Cn78qZo8rc3T9eZt0v3oICYRdd75wORtSidc8lNjDQ=
79+
github.com/lukaszraczylo/oss-telemetry v0.2.1 h1:6ULyfzXplpdmIY/i01OPM1jeod9+L1RAhI0jtbVnJI0=
80+
github.com/lukaszraczylo/oss-telemetry v0.2.1/go.mod h1:+Cn78qZo8rc3T9eZt0v3oICYRdd75wORtSidc8lNjDQ=
8181
github.com/mattn/go-colorable v0.1.14 h1:9A9LHSqF/7dyVVX6g0U9cwm9pG3kP9gSzcuIPHPsaIE=
8282
github.com/mattn/go-colorable v0.1.14/go.mod h1:6LmQG8QLFO4G5z1gPvYEzlUgJ2wF+stgPZH1UqBm1s8=
8383
github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY=

main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ func parseConfig() {
518518
}
519519

520520
func main() {
521-
telemetry.Send("graphql-monitoring-proxy", appVersion)
521+
telemetry.SendForModule("graphql-monitoring-proxy", "github.com/lukaszraczylo/graphql-monitoring-proxy", appVersion)
522522

523523
// Parse configuration
524524
parseConfig()

0 commit comments

Comments
 (0)