Readd download attribute to download buttons (#667)

Author: rollerozxa

app/public/static/js/download_card.js

@@ -30,6 +30,8 @@ function setLuantiVersion(version) {
 	localStorage.setItem("luanti-version", version.value);
 
 	const {
+		packageName,
+		releaseId,
 		releaseName,
 		releaseUrl,
 		releaseSize,
@@ -53,6 +55,10 @@ function setLuantiVersion(version) {
 		const btn = document.querySelector("#download-card .btn-download");
 		btn.setAttribute("href", releaseUrl);
 
+		// See PackageRelease.get_download_filename()
+		const filename = `${packageName}_${releaseId}.zip`;
+		btn.setAttribute("download", filename);
+
 		const size = document.getElementById("download-file-size");
 		if (releaseSize > 1024*1024) {
 			size.textContent = `[${(releaseSize / 1024 / 1024).toFixed(1)} MB]`;

app/templates/packages/view.html

@@ -290,9 +290,11 @@ <h1 class="my-4">{{ meta.title }}</h1>
 										{% if version_release %}
 											{% set id, name, file_size_bytes, created_at, _ = version_release %}
 											data-release-url="{{ package.get_url('packages.download_release', id=id) }}"
+											data-package-name="{{ package.name }}"
+											data-release-id="{{ id }}"
 											data-release-name="{{ name }}"
 											data-release-size="{{ file_size_bytes }}"
-											data-release-created-at="{{ created_at | datetime }} "
+											data-release-created-at="{{ created_at | datetime }}"
 										{% endif %}
 										{% if loop.index == (luanti_versions | length) - 1 %}selected{% endif %}
 										{% if loop.index >= (luanti_versions | length) - 1 %}data-latest="true"{% endif %}>
@@ -701,7 +703,7 @@ <h2 class="tab-title">{{ _("Releases") }}</h2>
 										{{ release.name }}
 									</p>
 									<p>
-										<a href="{{ release.get_download_url() }}" class="btn btn-secondary me-3">
+										<a href="{{ release.get_download_url() }}" download="{{ release.get_download_filename() }}" class="btn btn-secondary me-3">
 											{{ _("Download") }}
 										</a>
 									</p>