fix: add reset db on command, expose error on e2e tests (#1627)

* fix factory reset not deleting data

* make onboarding errors pop up on e2e tests

* style: ruff format (auto)

* added check for error when uploading

* added check if its on first step to rollback, not only if its complete

* reset correctly

* update timeout for uploading document

* remove misclick

* fixed lint

* fix mypy errors

* style: ruff format (auto)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: 2 people

Makefile

@@ -534,6 +534,7 @@ factory-reset: ## Complete reset (stop, remove volumes, clear data, remove image
 	echo "  - Remove all volumes"; \
 	echo "  - Delete langflow-data directory"; \
 	echo "  - Delete config directory"; \
+	echo "  - Delete data directory (database and session configs)"; \
 	echo "  - Delete JWT keys (private_key.pem, public_key.pem)"; \
 	echo "  - Remove OpenRAG images"; \
 	echo ""; \
@@ -559,6 +560,16 @@ factory-reset: ## Complete reset (stop, remove volumes, clear data, remove image
 		rm -rf config; \
 		echo "$(PURPLE)config removed$(NC)"; \
 	fi; \
+	if [ -d "data" ]; then \
+		echo "Removing data..."; \
+		rm -rf data; \
+		echo "$(PURPLE)data removed$(NC)"; \
+	fi; \
+	if [ -n "$$OPENRAG_DATA_PATH" ] && [ -d "$$OPENRAG_DATA_PATH" ]; then \
+		echo "Removing $$OPENRAG_DATA_PATH..."; \
+		rm -rf "$$OPENRAG_DATA_PATH"; \
+		echo "$(PURPLE)$$OPENRAG_DATA_PATH removed$(NC)"; \
+	fi; \
 	if [ -f "keys/private_key.pem" ] || [ -f "keys/public_key.pem" ]; then \
 		echo "Removing JWT keys..."; \
 		rm -f keys/private_key.pem keys/public_key.pem 2>/dev/null || \

frontend/app/onboarding/_components/onboarding-card.tsx

@@ -510,7 +510,10 @@ const OnboardingCard = ({
                 >
                   <div className="pb-6 flex items-center gap-4">
                     <X className="w-4 h-4 text-destructive shrink-0" />
-                    <span className="text-mmd text-muted-foreground">
+                    <span
+                      data-testid="onboarding-error"
+                      className="text-mmd text-muted-foreground"
+                    >
                       {error}
                     </span>
                   </div>

frontend/app/onboarding/_components/onboarding-upload.tsx

@@ -24,6 +24,7 @@ const OnboardingUpload = ({ onComplete }: OnboardingUploadProps) => {
   const [uploadedTaskId, setUploadedTaskId] = useState<string | null>(null);
   const [shouldCreateFilter, setShouldCreateFilter] = useState(false);
   const [isCreatingFilter, setIsCreatingFilter] = useState(false);
+  const [error, setError] = useState<string | null>(null);
 
   const createFilterMutation = useCreateFilter();
   const updateOnboardingMutation = useUpdateOnboardingStateMutation();
@@ -63,6 +64,41 @@ const OnboardingUpload = ({ onComplete }: OnboardingUploadProps) => {
       matchingTask.status === "running" ||
       matchingTask.status === "processing";
 
+    // Check if matching task failed or has error status
+    const failedTask =
+      matchingTask.status === "failed" || matchingTask.status === "error";
+
+    // Check if any file inside the task failed
+    const filesArray = matchingTask.files
+      ? (Object.values(matchingTask.files) as {
+          status: string;
+          error?: string;
+        }[])
+      : [];
+    const hasFailedFile = filesArray.some(
+      (file) => file.status === "failed" || file.status === "error",
+    );
+
+    if (failedTask || hasFailedFile) {
+      let errorMessage = "Document ingestion failed. Please try again.";
+      if (matchingTask.error) {
+        errorMessage = matchingTask.error;
+      } else {
+        const failedFile = filesArray.find(
+          (file) =>
+            (file.status === "failed" || file.status === "error") && file.error,
+        );
+        if (failedFile?.error) {
+          errorMessage = failedFile.error;
+        }
+      }
+
+      setError(errorMessage);
+      setCurrentStep(null);
+      setUploadedTaskId(null);
+      return;
+    }
+
     // If task is completed or has processed files, complete the onboarding step
     if (!isTaskActive || (matchingTask.processed_files ?? 0) > 0) {
       // Set to final step to show "Done"
@@ -169,6 +205,7 @@ const OnboardingUpload = ({ onComplete }: OnboardingUploadProps) => {
 
   const performUpload = async (file: File) => {
     setIsUploading(true);
+    setError(null);
     try {
       setCurrentStep(0);
       const result = await uploadFile(file, true, true); // Pass createFilter=true
@@ -193,6 +230,7 @@ const OnboardingUpload = ({ onComplete }: OnboardingUploadProps) => {
       const errorMessage =
         error instanceof Error ? error.message : "Upload failed";
       console.error("Upload failed", errorMessage);
+      setError(errorMessage);
 
       // Dispatch event that chat context can listen to
       // This avoids circular dependency issues
@@ -246,6 +284,25 @@ const OnboardingUpload = ({ onComplete }: OnboardingUploadProps) => {
           exit={{ opacity: 0, y: -24 }}
           transition={{ duration: 0.4, ease: "easeInOut" }}
         >
+          <AnimatePresence mode="wait">
+            {error && (
+              <motion.div
+                key="error"
+                initial={{ opacity: 1, y: 0, height: "auto" }}
+                exit={{ opacity: 0, y: -10, height: 0 }}
+              >
+                <div className="pb-6 flex items-center gap-4">
+                  <X className="w-4 h-4 text-destructive shrink-0" />
+                  <span
+                    data-testid="onboarding-upload-error"
+                    className="text-mmd text-muted-foreground"
+                  >
+                    {error}
+                  </span>
+                </div>
+              </motion.div>
+            )}
+          </AnimatePresence>
           <Button
             size="sm"
             variant="outline"

frontend/tests/utils/onboarding.ts

@@ -54,14 +54,19 @@ export async function completeOnboarding(
   }
 
   const isCompleted = await completedLocator.isVisible();
+  const isFirstStep = await page.getByTestId("openai-llm-tab").isVisible();
 
-  if (isCompleted) {
-    if (!reset) {
-      console.log("Onboarding already complete, skipping...");
-      return;
-    }
+  if (isCompleted && !reset) {
+    console.log("Onboarding already complete, skipping...");
+    return;
+  }
+
+  const needsRollback = reset && (isCompleted || !isFirstStep);
 
-    console.log("Onboarding complete and reset is true, rolling back...");
+  if (needsRollback) {
+    console.log(
+      "Onboarding complete or not on the first step, and reset is true, rolling back...",
+    );
     const response = await page.request.post("/api/onboarding/rollback");
     if (!response.ok()) {
       const text = await response.text();
@@ -141,9 +146,18 @@ export async function completeOnboarding(
     await page.getByTestId("onboarding-complete-button").click();
 
     await expect(page.getByText("Thinking")).toBeVisible();
-    await expect(page.getByText("Done")).toBeVisible({
+
+    const doneLocator = page.getByText("Done");
+    const errorLocator = page.getByTestId("onboarding-error");
+
+    await expect(doneLocator.or(errorLocator)).toBeVisible({
       timeout: isEmbedding ? 120000 : 60000,
     });
+
+    if (await errorLocator.isVisible()) {
+      const errorText = await errorLocator.innerText();
+      throw new Error(`Onboarding step failed: ${errorText}`);
+    }
   };
 
   // 1. LLM configuration
@@ -182,6 +196,17 @@ export async function completeOnboarding(
     path.join(__dirname, "../assets", "test-document.md"),
   );
 
-  await expect(page.getByText("Done")).toBeVisible({ timeout: 60000 });
+  const uploadDoneLocator = page.getByText("Done");
+  const uploadErrorLocator = page.getByTestId("onboarding-upload-error");
+
+  await expect(uploadDoneLocator.or(uploadErrorLocator)).toBeVisible({
+    timeout: 120000,
+  });
+
+  if (await uploadErrorLocator.isVisible()) {
+    const errorText = await uploadErrorLocator.innerText();
+    throw new Error(`Onboarding document upload failed: ${errorText}`);
+  }
+
   await expect(page.getByTestId("onboarding-content")).toBeHidden();
 }

src/api/settings/endpoints.py

@@ -1373,6 +1373,10 @@ async def remove_filter(filter_id: str | None):
         current_config.knowledge.embedding_model = ""
         current_config.onboarding.openrag_docs_ingested_version = None
         current_config.onboarding.openrag_docs_remote_signature = None
+        current_config.onboarding.assistant_message = None
+        current_config.onboarding.selected_nudge = None
+        current_config.onboarding.card_steps = None
+        current_config.onboarding.upload_steps = None
 
         embedding_only = body.embedding_only if body else False