[scanner] fix: extract text utilities from god-script into scripts/lib/#2526
Merged
Merged
Conversation
…b/text-utils.mjs Extract 11 pure text-processing functions (345 lines) from the 2036-line generate-cncf-missions.mjs into a reusable lib module: cleanText, isGarbageSnippet, truncateAtWordBoundary, truncateAtSentenceBoundary, extractFromNumberedTemplate, extractFromBoldTemplate, stripPRTemplate, isLikelyEnglish, slugify, sanitizeInfraDetails, redactCredentials These utilities are now importable by generate-platform-missions.mjs and generate-cncf-install-missions.mjs without copy-pasting. Fixes #2481 Signed-off-by: sec-check <sec-check@hive.local>
kubestellar-prow
Bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/XL
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+20
to
+21
| return text | ||
| .replace(/<!--[\s\S]*?-->/g, '') |
| if (lower.includes('for first time contributors') || lower.includes('please ensure your pull request')) return true | ||
| if (lower.includes('query performance') && lower.includes('![image]')) return true | ||
| if (lower.includes('"tag_name"') || lower.includes('"html_url"') || lower.includes('"created_at"')) return true | ||
| if (lower.includes('api.github.com')) return true |
| export function stripPRTemplate(text) { | ||
| if (!text) return '' | ||
| let cleaned = text | ||
| cleaned = cleaned.replace(/<!--[\s\S]*?-->/g, '') |
Contributor
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts 11 pure text-processing functions (345 lines) from the 2036-line
generate-cncf-missions.mjsintoscripts/lib/text-utils.mjs:cleanTextisGarbageSnippettruncateAtWordBoundarytruncateAtSentenceBoundaryextractFromNumberedTemplateextractFromBoldTemplatestripPRTemplateisLikelyEnglishslugifysanitizeInfraDetailsredactCredentialsResult
generate-cncf-missions.mjs: 2036 → 1691 lines (-17%)generate-platform-missions.mjsandgenerate-cncf-install-missions.mjsFixes #2481