fix(transcript): include final second of day in CLI day-view range (#1508)

Day-view CLI transcript reads (`--date` and default "today") used an exclusive end of `${date}T23:59:59Z`, dropping entries in the final second of the day. Add a shared `utcDayRange(date)` helper (next-day 00:00:00Z exclusive end) and wire it into both branches, preserving readRange's half-open [start, end) semantics (rule #35). Includes a test asserting a 23:59:59.500Z entry is returned and a next-day boundary entry is excluded.

Author: joshuaswarren

packages/remnic-core/src/cli.ts

@@ -5,6 +5,7 @@ import { createHash } from "node:crypto";
 import type { Readable, Writable } from "node:stream";
 import type { Orchestrator } from "./orchestrator.js";
 import { ThreadingManager } from "./threading.js";
+import { utcDayRange } from "./transcript.js";
 import { runWearablesCliCommand } from "./wearables/cli.js";
 import type {
   BehaviorSignalEvent,
@@ -8630,26 +8631,23 @@ export function registerCli(
           }
 
           if (date) {
-            // Read specific date
-            const entries = await orchestrator.transcript.readRange(
-              `${date}T00:00:00Z`,
-              `${date}T23:59:59Z`,
-              channel,
-            );
+            // Read specific date. Use a half-open [start, next-day-00:00:00Z)
+            // window so `readRange`'s exclusive upper bound still covers the
+            // final second of the day (rule #35).
+            const { start, end } = utcDayRange(date);
+            const entries = await orchestrator.transcript.readRange(start, end, channel);
             console.log(formatTranscript(entries));
           } else if (recent) {
             // Parse duration (e.g., "12h", "30m")
             const hours = parseDuration(recent);
             const entries = await orchestrator.transcript.readRecent(hours, channel);
             console.log(formatTranscript(entries));
           } else {
-            // Default: show today's transcript
+            // Default: show today's transcript. Same half-open day window as
+            // the --date branch so the final second of the day is included.
             const today = new Date().toISOString().slice(0, 10);
-            const entries = await orchestrator.transcript.readRange(
-              `${today}T00:00:00Z`,
-              `${today}T23:59:59Z`,
-              channel,
-            );
+            const { start, end } = utcDayRange(today);
+            const entries = await orchestrator.transcript.readRange(start, end, channel);
             console.log(formatTranscript(entries));
           }
         });

packages/remnic-core/src/transcript-day-range.test.ts

@@ -0,0 +1,101 @@
+/**
+ * Tests for the CLI transcript day-view window helper `utcDayRange`.
+ *
+ * The `transcript --date <day>` and default "today" CLI views read a single
+ * calendar day via {@link TranscriptManager.readRange}, which uses a half-open
+ * `[start, end)` interval (`entryTime < end`, CLAUDE.md rule #35). The day end
+ * must therefore be the NEXT day's `00:00:00Z`, not `${date}T23:59:59Z`:
+ * a literal `23:59:59Z` end (== `.000Z`) silently drops any entry stamped in
+ * the final second of the day (`23:59:59.000Z`–`23:59:59.999Z`).
+ *
+ * (Pre-existing boundary gap flagged as a P2 on PR #1507, fixed out of band.)
+ */
+
+import assert from "node:assert/strict";
+import { mkdtemp, realpath, rm } from "node:fs/promises";
+import os from "node:os";
+import path from "node:path";
+import test from "node:test";
+
+import { TranscriptManager, utcDayRange } from "./transcript.js";
+import type { PluginConfig, TranscriptEntry } from "./types.js";
+
+function makeConfig(memoryDir: string): PluginConfig {
+  // TranscriptManager only reads memoryDir + transcriptSkipChannelTypes.
+  return {
+    memoryDir,
+    transcriptSkipChannelTypes: [],
+  } as unknown as PluginConfig;
+}
+
+// On macOS `os.tmpdir()` is a `/var/folders/...` symlink to `/private/var/...`.
+// Canonicalize the test root upfront (issue #691 symlink convention).
+async function makeMemoryDir(): Promise<string> {
+  return realpath(await mkdtemp(path.join(os.tmpdir(), "remnic-tx-dayrange-")));
+}
+
+function entryAt(timestamp: string, turnId: string): TranscriptEntry {
+  return {
+    sessionKey: "agent:generalist:main",
+    turnId,
+    role: "user",
+    content: `content-${turnId}`,
+    timestamp,
+  } as TranscriptEntry;
+}
+
+// ── utcDayRange: half-open [start, next-day-00:00:00Z) ───────────────────────
+
+test("utcDayRange end is the next day's 00:00:00Z (half-open day window)", () => {
+  assert.deepEqual(utcDayRange("2025-03-15"), {
+    start: "2025-03-15T00:00:00Z",
+    end: "2025-03-16T00:00:00Z",
+  });
+});
+
+test("utcDayRange rolls over month boundaries", () => {
+  assert.deepEqual(utcDayRange("2025-01-31"), {
+    start: "2025-01-31T00:00:00Z",
+    end: "2025-02-01T00:00:00Z",
+  });
+});
+
+test("utcDayRange rolls over leap-day and year boundaries", () => {
+  assert.deepEqual(utcDayRange("2024-02-28"), {
+    start: "2024-02-28T00:00:00Z",
+    end: "2024-02-29T00:00:00Z",
+  });
+  assert.deepEqual(utcDayRange("2025-12-31"), {
+    start: "2025-12-31T00:00:00Z",
+    end: "2026-01-01T00:00:00Z",
+  });
+});
+
+// ── Day-view range includes the final second of the day (the bug fix) ────────
+
+test("day-view range returns an entry stamped at 23:59:59.500Z of the queried day", async () => {
+  const memoryDir = await makeMemoryDir();
+  try {
+    const tm = new TranscriptManager(makeConfig(memoryDir));
+    const date = "2025-03-15";
+    const channel = "agent:generalist:main";
+
+    // Entry in the final second of the day — dropped by the old
+    // `${date}T23:59:59Z` (== `.000Z`) exclusive upper bound.
+    await tm.append(entryAt(`${date}T23:59:59.500Z`, "final-second"));
+    // Midday control entry, comfortably inside the window.
+    await tm.append(entryAt(`${date}T12:00:00.000Z`, "midday"));
+    // Start-of-next-day entry must stay OUT — the upper bound is exclusive
+    // (`[start, end)`, rule #35), so `nextDate T00:00:00.000Z` is not the
+    // queried day.
+    await tm.append(entryAt("2025-03-16T00:00:00.000Z", "next-day"));
+
+    const { start, end } = utcDayRange(date);
+    const entries = await tm.readRange(start, end, channel);
+    const ids = entries.map((e) => e.turnId).sort();
+
+    assert.deepEqual(ids, ["final-second", "midday"]);
+  } finally {
+    await rm(memoryDir, { recursive: true, force: true });
+  }
+});

packages/remnic-core/src/transcript.ts

@@ -33,6 +33,32 @@ function makeRawLineDeduper(): (rawLine: string) => boolean {
   };
 }
 
+/**
+ * Compute the half-open UTC instant range `[start, end)` that covers an entire
+ * calendar day, suitable for {@link TranscriptManager.readRange}.
+ *
+ * `readRange` filters with an EXCLUSIVE upper bound (`entryTime < end`, CLAUDE.md
+ * rule #35 / AGENTS.md rule 23). The end is therefore the NEXT day's
+ * `00:00:00Z`, not `${date}T23:59:59Z`: a literal `23:59:59Z` end (== `.000Z`)
+ * would drop any entry stamped in the final second of the day
+ * (`23:59:59.000Z`–`23:59:59.999Z`). Using the next day's midnight keeps the
+ * `[start, end)` semantics intact while including the whole day.
+ *
+ * @param date - A `YYYY-MM-DD` calendar day (UTC).
+ */
+export function utcDayRange(date: string): { start: string; end: string } {
+  const start = `${date}T00:00:00Z`;
+  const startMs = Date.parse(start);
+  if (Number.isNaN(startMs)) {
+    // Malformed date: preserve the pre-existing "empty range" behavior (an
+    // unparseable bound makes `readRange` match nothing) rather than throwing.
+    return { start, end: start };
+  }
+  const next = new Date(startMs);
+  next.setUTCDate(next.getUTCDate() + 1);
+  return { start, end: `${next.toISOString().slice(0, 10)}T00:00:00Z` };
+}
+
 /**
  * Manages conversation transcript storage, checkpointing, and recall formatting.
  *