Fix Sonar issues (#1831)

qmonmert · web-flow · commit 13c9b7ce944b · 2026-05-06T21:56:08.000+01:00
diff --git a/jhipster-framework/src/main/java/tech/jhipster/service/ConditionBuilder.java b/jhipster-framework/src/main/java/tech/jhipster/service/ConditionBuilder.java
@@ -23,7 +23,6 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.function.Function;
-import java.util.stream.Collectors;
 import org.springframework.data.relational.core.sql.Column;
 import org.springframework.data.relational.core.sql.Condition;
 import org.springframework.data.relational.core.sql.Conditions;
@@ -146,7 +145,7 @@ private <X> void buildBooleanConditions(Filter<X> generalData, Column column) {
                         .getIn()
                         .stream()
                         .map(eachIn -> SQL.literalOf(columnConverter.convert(eachIn, Boolean.class)))
-                        .collect(Collectors.toList())
+                        .toList()
                 )
             );
         }
@@ -158,7 +157,7 @@ private <X> void buildBooleanConditions(Filter<X> generalData, Column column) {
                         .getNotIn()
                         .stream()
                         .map(eachNotIn -> SQL.literalOf(columnConverter.convert(eachNotIn, Boolean.class)))
-                        .collect(Collectors.toList())
+                        .toList()
                 )
             );
         }
@@ -186,7 +185,7 @@ private <X> void buildGeneralConditions(Filter<X> generalData, Column column, Cl
                         .getIn()
                         .stream()
                         .map(eachIn -> SQL.literalOf(converterFunction.apply(eachIn)))
-                        .collect(Collectors.toList())
+                        .toList()
                 )
             );
         }
@@ -198,7 +197,7 @@ private <X> void buildGeneralConditions(Filter<X> generalData, Column column, Cl
                         .getNotIn()
                         .stream()
                         .map(eachNotIn -> SQL.literalOf(converterFunction.apply(eachNotIn)))
-                        .collect(Collectors.toList())
+                        .toList()
                 )
             );
         }
diff --git a/jhipster-framework/src/test/java/tech/jhipster/domain/util/JSR310DateConvertersTest.java b/jhipster-framework/src/test/java/tech/jhipster/domain/util/JSR310DateConvertersTest.java
@@ -6,7 +6,7 @@
 import java.util.Date;
 import org.junit.jupiter.api.Test;
 
-public class JSR310DateConvertersTest {
+class JSR310DateConvertersTest {
 
     @Test
     void testLocalDateToDateConverter() {
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/BigDecimalFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/BigDecimalFilterTest.java
@@ -87,7 +87,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<BigDecimal> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/BooleanFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/BooleanFilterTest.java
@@ -78,7 +78,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Boolean> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/DoubleFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/DoubleFilterTest.java
@@ -86,7 +86,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Double> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/DurationFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/DurationFilterTest.java
@@ -87,7 +87,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Duration> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/FilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/FilterTest.java
@@ -83,7 +83,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Object> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/FloatFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/FloatFilterTest.java
@@ -86,7 +86,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Float> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/InstantFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/InstantFilterTest.java
@@ -87,7 +87,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Instant> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/IntegerFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/IntegerFilterTest.java
@@ -86,7 +86,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Integer> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/LocalDateFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/LocalDateFilterTest.java
@@ -87,7 +87,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<LocalDate> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/LongFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/LongFilterTest.java
@@ -86,7 +86,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Long> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/RangeFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/RangeFilterTest.java
@@ -86,7 +86,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Short> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/ShortFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/ShortFilterTest.java
@@ -86,7 +86,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<Short> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/StringFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/StringFilterTest.java
@@ -82,7 +82,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<String> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/UUIDFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/UUIDFilterTest.java
@@ -79,7 +79,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<UUID> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/service/filter/ZonedDateTimeFilterTest.java b/jhipster-framework/src/test/java/tech/jhipster/service/filter/ZonedDateTimeFilterTest.java
@@ -87,7 +87,7 @@ void testSetNotEquals() {
     void testSetSpecified() {
         Filter<ZonedDateTime> chain = filter.setSpecified(true);
         assertThat(chain).isEqualTo(filter);
-        assertThat(filter.getSpecified()).isEqualTo(true);
+        assertThat(filter.getSpecified()).isTrue();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/web/rest/errors/ProblemDetailWithCauseTest.java b/jhipster-framework/src/test/java/tech/jhipster/web/rest/errors/ProblemDetailWithCauseTest.java
@@ -4,12 +4,7 @@
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 import java.net.URI;
-import java.util.HashMap;
-import java.util.Map;
 import org.junit.jupiter.api.Test;
-import org.springframework.http.HttpStatus;
-import org.springframework.http.ResponseEntity;
-import tech.jhipster.web.rest.errors.ProblemDetailWithCause;
 
 class ProblemDetailWithCauseTest {
 
diff --git a/jhipster-framework/src/test/java/tech/jhipster/web/rest/errors/ReactiveWebExceptionHandlerTest.java b/jhipster-framework/src/test/java/tech/jhipster/web/rest/errors/ReactiveWebExceptionHandlerTest.java
@@ -1,7 +1,6 @@
 package tech.jhipster.web.rest.errors;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.net.URI;
 import org.apache.commons.logging.Log;
@@ -23,7 +22,7 @@
 import tools.jackson.databind.JsonNode;
 import tools.jackson.databind.ObjectMapper;
 
-public class ReactiveWebExceptionHandlerTest {
+class ReactiveWebExceptionHandlerTest {
 
     // Constants
     private static final MediaType RESPONSE_TYPE = MediaType.APPLICATION_PROBLEM_JSON;
diff --git a/jhipster-framework/src/test/java/tech/jhipster/web/util/PaginationUtilTest.java b/jhipster-framework/src/test/java/tech/jhipster/web/util/PaginationUtilTest.java
@@ -51,8 +51,7 @@ void generatePaginationHttpHeadersTest() {
         Page<String> page = new PageImpl<>(new ArrayList<>(), PageRequest.of(6, 50), 400L);
         HttpHeaders headers = PaginationUtil.generatePaginationHttpHeaders(uriBuilder, page);
         List<String> strHeaders = headers.get(HttpHeaders.LINK);
-        assertThat(strHeaders).isNotNull();
-        assertThat(strHeaders).hasSize(1);
+        assertThat(strHeaders).isNotNull().hasSize(1);
         String headerData = strHeaders.get(0);
         assertThat(headerData.split(",")).hasSize(4);
         String expectedData =
@@ -72,8 +71,7 @@ void commaTest() {
         Page<String> page = new PageImpl<>(content);
         HttpHeaders headers = PaginationUtil.generatePaginationHttpHeaders(uriBuilder, page);
         List<String> strHeaders = headers.get(HttpHeaders.LINK);
-        assertThat(strHeaders).isNotNull();
-        assertThat(strHeaders).hasSize(1);
+        assertThat(strHeaders).isNotNull().hasSize(1);
         String headerData = strHeaders.get(0);
         assertThat(headerData.split(",")).hasSize(2);
         String expectedData =
@@ -93,8 +91,7 @@ void multiplePagesTest() {
         Page<String> page = new PageImpl<>(content, PageRequest.of(0, 50), 400L);
         HttpHeaders headers = PaginationUtil.generatePaginationHttpHeaders(uriBuilder, page);
         List<String> strHeaders = headers.get(HttpHeaders.LINK);
-        assertThat(strHeaders).isNotNull();
-        assertThat(strHeaders).hasSize(1);
+        assertThat(strHeaders).isNotNull().hasSize(1);
         String headerData = strHeaders.get(0);
         assertThat(headerData.split(",")).hasSize(3);
         String expectedData =
@@ -110,8 +107,7 @@ void multiplePagesTest() {
         page = new PageImpl<>(content, PageRequest.of(1, 50), 400L);
         headers = PaginationUtil.generatePaginationHttpHeaders(uriBuilder, page);
         strHeaders = headers.get(HttpHeaders.LINK);
-        assertThat(strHeaders).isNotNull();
-        assertThat(strHeaders).hasSize(1);
+        assertThat(strHeaders).isNotNull().hasSize(1);
         headerData = strHeaders.get(0);
         assertThat(headerData.split(",")).hasSize(4);
         expectedData =
@@ -128,8 +124,7 @@ void multiplePagesTest() {
         page = new PageImpl<>(content, PageRequest.of(6, 50), 400L);
         headers = PaginationUtil.generatePaginationHttpHeaders(uriBuilder, page);
         strHeaders = headers.get(HttpHeaders.LINK);
-        assertThat(strHeaders).isNotNull();
-        assertThat(strHeaders).hasSize(1);
+        assertThat(strHeaders).isNotNull().hasSize(1);
         headerData = strHeaders.get(0);
         assertThat(headerData.split(",")).hasSize(4);
         expectedData =
@@ -146,8 +141,7 @@ void multiplePagesTest() {
         page = new PageImpl<>(content, PageRequest.of(7, 50), 400L);
         headers = PaginationUtil.generatePaginationHttpHeaders(uriBuilder, page);
         strHeaders = headers.get(HttpHeaders.LINK);
-        assertThat(strHeaders).isNotNull();
-        assertThat(strHeaders).hasSize(1);
+        assertThat(strHeaders).isNotNull().hasSize(1);
         headerData = strHeaders.get(0);
         assertThat(headerData.split(",")).hasSize(3);
         expectedData =
@@ -163,8 +157,7 @@ void greaterSemicolonTest() {
         Page<String> page = new PageImpl<>(new ArrayList<>());
         HttpHeaders headers = PaginationUtil.generatePaginationHttpHeaders(uriBuilder, page);
         List<String> strHeaders = headers.get(HttpHeaders.LINK);
-        assertThat(strHeaders).isNotNull();
-        assertThat(strHeaders).hasSize(1);
+        assertThat(strHeaders).isNotNull().hasSize(1);
         String headerData = strHeaders.get(0);
         assertThat(headerData.split(",")).hasSize(2);
         String[] linksData = headerData.split(",");
diff --git a/jhipster-framework/src/test/java/tech/jhipster/web/util/ResponseUtilTest.java b/jhipster-framework/src/test/java/tech/jhipster/web/util/ResponseUtilTest.java
@@ -51,7 +51,7 @@ void testOptionalYesWithoutHeaders() {
         ResponseEntity<Integer> response = ResponseUtil.wrapOrNotFound(optionalYes);
         assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
         assertThat(response.getBody()).isEqualTo(42);
-        assertThat(response.getHeaders().size()).isEqualTo(0);
+        assertThat(response.getHeaders().size()).isZero();
     }
 
     @Test
diff --git a/jhipster-framework/src/test/java/tech/jhipster/web/util/reactive/ResponseUtilTest.java b/jhipster-framework/src/test/java/tech/jhipster/web/util/reactive/ResponseUtilTest.java
@@ -33,7 +33,7 @@ void testMonoYesWithoutHeaders() {
         ResponseEntity<Integer> response = ResponseUtil.wrapOrNotFound(monoYes).block();
         assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
         assertThat(response.getBody()).isEqualTo(42);
-        assertThat(response.getHeaders().size()).isEqualTo(0);
+        assertThat(response.getHeaders().size()).isZero();
     }
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@`
`23`	`23`	`import java.util.ArrayList;`
`24`	`24`	`import java.util.List;`
`25`	`25`	`import java.util.function.Function;`
`26`		`-import java.util.stream.Collectors;`
`27`	`26`	`import org.springframework.data.relational.core.sql.Column;`
`28`	`27`	`import org.springframework.data.relational.core.sql.Condition;`
`29`	`28`	`import org.springframework.data.relational.core.sql.Conditions;`
`@@ -146,7 +145,7 @@ private <X> void buildBooleanConditions(Filter<X> generalData, Column column) {`
`146`	`145`	`.getIn()`
`147`	`146`	`.stream()`
`148`	`147`	`.map(eachIn -> SQL.literalOf(columnConverter.convert(eachIn, Boolean.class)))`
`149`		`- .collect(Collectors.toList())`
	`148`	`+ .toList()`
`150`	`149`	`)`
`151`	`150`	`);`
`152`	`151`	`}`
`@@ -158,7 +157,7 @@ private <X> void buildBooleanConditions(Filter<X> generalData, Column column) {`
`158`	`157`	`.getNotIn()`
`159`	`158`	`.stream()`
`160`	`159`	`.map(eachNotIn -> SQL.literalOf(columnConverter.convert(eachNotIn, Boolean.class)))`
`161`		`- .collect(Collectors.toList())`
	`160`	`+ .toList()`
`162`	`161`	`)`
`163`	`162`	`);`
`164`	`163`	`}`
`@@ -186,7 +185,7 @@ private <X> void buildGeneralConditions(Filter<X> generalData, Column column, Cl`
`186`	`185`	`.getIn()`
`187`	`186`	`.stream()`
`188`	`187`	`.map(eachIn -> SQL.literalOf(converterFunction.apply(eachIn)))`
`189`		`- .collect(Collectors.toList())`
	`188`	`+ .toList()`
`190`	`189`	`)`
`191`	`190`	`);`
`192`	`191`	`}`
`@@ -198,7 +197,7 @@ private <X> void buildGeneralConditions(Filter<X> generalData, Column column, Cl`
`198`	`197`	`.getNotIn()`
`199`	`198`	`.stream()`
`200`	`199`	`.map(eachNotIn -> SQL.literalOf(converterFunction.apply(eachNotIn)))`
`201`		`- .collect(Collectors.toList())`
	`200`	`+ .toList()`
`202`	`201`	`)`
`203`	`202`	`);`
`204`	`203`	`}`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ void testSetNotEquals() {`
`87`	`87`	`void testSetSpecified() {`
`88`	`88`	`Filter<BigDecimal> chain = filter.setSpecified(true);`
`89`	`89`	`assertThat(chain).isEqualTo(filter);`
`90`		`- assertThat(filter.getSpecified()).isEqualTo(true);`
	`90`	`+ assertThat(filter.getSpecified()).isTrue();`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`@Test`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ void testSetNotEquals() {`
`78`	`78`	`void testSetSpecified() {`
`79`	`79`	`Filter<Boolean> chain = filter.setSpecified(true);`
`80`	`80`	`assertThat(chain).isEqualTo(filter);`
`81`		`- assertThat(filter.getSpecified()).isEqualTo(true);`
	`81`	`+ assertThat(filter.getSpecified()).isTrue();`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`@Test`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ void testSetNotEquals() {`
`86`	`86`	`void testSetSpecified() {`
`87`	`87`	`Filter<Double> chain = filter.setSpecified(true);`
`88`	`88`	`assertThat(chain).isEqualTo(filter);`
`89`		`- assertThat(filter.getSpecified()).isEqualTo(true);`
	`89`	`+ assertThat(filter.getSpecified()).isTrue();`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`@Test`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ void testSetNotEquals() {`
`83`	`83`	`void testSetSpecified() {`
`84`	`84`	`Filter<Object> chain = filter.setSpecified(true);`
`85`	`85`	`assertThat(chain).isEqualTo(filter);`
`86`		`- assertThat(filter.getSpecified()).isEqualTo(true);`
	`86`	`+ assertThat(filter.getSpecified()).isTrue();`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`@Test`