Skip to content

Commit dbb6b05

Browse files
Fix Module Federation shared deps version check for non-semver git URLs
1 parent 92c751f commit dbb6b05

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

generators/client/templates/webpack/webpack.microfrontend.js.jhi.ejs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,18 @@ const apiVersion = '0.0.1';
3636
const sharedDefaults = { singleton: true, strictVersion: true, requiredVersion: apiVersion };
3737
const shareMappings = (...mappings) => Object.fromEntries(mappings.map(map => [map, { ...sharedDefaults, version: apiVersion }]));
3838
39+
const isValidSemver = version => /^\d/.test(version) || version.startsWith('^') || version.startsWith('~');
40+
3941
const shareDependencies = ({ skipList = [] } = {}) =>
4042
Object.fromEntries(
4143
Object.entries(packageJson.dependencies)
4244
.filter(([dependency]) => !skipList.includes(dependency))
43-
.map(([dependency, version]) => [dependency, { ...sharedDefaults, version, requiredVersion: version }]),
45+
.map(([dependency, version]) => [
46+
dependency,
47+
isValidSemver(version)
48+
? { ...sharedDefaults, version, requiredVersion: version }
49+
: { ...sharedDefaults, version: apiVersion, requiredVersion: apiVersion },
50+
]),
4451
);
4552
<%_ } _%>
4653

0 commit comments

Comments
 (0)