Skip to content

Commit efd75c2

Browse files
authored
Merge pull request #181 from donhui/0514
fix: corrected the NullPointerException when delete resource
2 parents c040551 + 2ec78a4 commit efd75c2

2 files changed

Lines changed: 18 additions & 2 deletions

File tree

  • src/main
    • java/org/waveywaves/jenkins/plugins/tekton/client/build/delete
    • resources/org/waveywaves/jenkins/plugins/tekton/client/build/delete/DeleteRaw

src/main/java/org/waveywaves/jenkins/plugins/tekton/client/build/delete/DeleteRaw.java

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.waveywaves.jenkins.plugins.tekton.client.build.delete;
22

3+
import com.google.common.base.Strings;
34
import hudson.Extension;
45
import hudson.FilePath;
56
import hudson.Launcher;
@@ -41,7 +42,8 @@ public DeleteRaw(String resourceType, String clusterName, DeleteAllBlock deleteA
4142
super();
4243
this.resourceType = resourceType;
4344
this.resourceName = deleteAllStatus != null ? deleteAllStatus.resourceName : null;
44-
setTektonClient(TektonUtils.getTektonClient(clusterName));
45+
this.clusterName = clusterName;
46+
setTektonClient(TektonUtils.getTektonClient(getClusterName()));
4547
}
4648

4749
public static class DeleteAllBlock {
@@ -53,13 +55,25 @@ public DeleteAllBlock(String resourceName) {
5355
}
5456
}
5557

58+
public String getClusterName() {
59+
if (Strings.isNullOrEmpty(clusterName)) {
60+
clusterName = TektonUtils.DEFAULT_CLIENT_KEY;
61+
}
62+
return clusterName;
63+
}
5664
public String getResourceType(){
5765
return this.resourceType;
5866
}
5967
public String getResourceName(){
6068
return this.resourceName;
6169
}
6270

71+
@DataBoundSetter
72+
public void setClusterName(String clusterName) {
73+
this.clusterName = clusterName;
74+
setTektonClient(TektonUtils.getTektonClient(getClusterName()));
75+
}
76+
6377
@DataBoundSetter
6478
protected void setResourceType(String resourceType) {
6579
this.resourceType = resourceType;
@@ -74,6 +88,8 @@ private TektonResourceType getTypedResourceType(){
7488
return TektonResourceType.valueOf(getResourceType());
7589
}
7690

91+
92+
7793
@Override
7894
public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws InterruptedException, IOException {
7995
runDelete();

src/main/resources/org/waveywaves/jenkins/plugins/tekton/client/build/delete/DeleteRaw/config.jelly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<f:select name="resourceType"></f:select>
55
</f:entry>
66
<f:entry title="Cluster Name" field="clusterName">
7-
<f:select name="inputType"></f:select>
7+
<f:select name="clusterName"></f:select>
88
</f:entry>
99
<f:block>
1010
<f:optionalBlock

0 commit comments

Comments
 (0)