Skip to content

Commit e6893eb

Browse files
rhyslbwclaude
andcommitted
fix(deps): restore protobufjs & serialize-javascript resolutions (re-introduced vulns)
PR #1723 removed these two resolutions as "redundant" — that was wrong. Without them the tree resolves protobufjs 7.2.6 and serialize-javascript 6.0.2, which are vulnerable: - protobufjs < 7.5.5: GHSA-xq3m-2v4x-88gg CRITICAL arbitrary code execution (+ 5 high, 4 medium) - serialize-javascript < 7.0.3: GHSA-5c6j-r48x-rmvq high (+ medium) Restore the pins (protobufjs 7.6.4, serialize-javascript ^7.0.5) so they resolve to patched versions (7.6.4 / 7.0.6). These force exact patched versions because the owning parents (@trezor/protobuf, mocha/webpack tooling) still pull the old lines. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 97da539 commit e6893eb

2 files changed

Lines changed: 13 additions & 40 deletions

File tree

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@
101101
"js-yaml": "^4.2.0",
102102
"tar": "^7.5.16",
103103
"tmp": "^0.2.6",
104-
"uuid": "^11.1.1"
104+
"uuid": "^11.1.1",
105+
"protobufjs": "7.6.4",
106+
"serialize-javascript": "^7.0.5"
105107
}
106108
}

yarn.lock

Lines changed: 10 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -6276,21 +6276,21 @@ __metadata:
62766276
languageName: node
62776277
linkType: hard
62786278

6279-
"@protobufjs/codegen@npm:^2.0.4, @protobufjs/codegen@npm:^2.0.5":
6279+
"@protobufjs/codegen@npm:^2.0.5":
62806280
version: 2.0.5
62816281
resolution: "@protobufjs/codegen@npm:2.0.5"
62826282
checksum: b5f1e43b4b9432247297083e395982054b8ff0e3a6de550bffe12de16a22bd6e900f7820a3348ecbac95cbf78bbb6b71e268f64fdbbeda1f354846965baa01ca
62836283
languageName: node
62846284
linkType: hard
62856285

6286-
"@protobufjs/eventemitter@npm:^1.1.0, @protobufjs/eventemitter@npm:^1.1.1":
6286+
"@protobufjs/eventemitter@npm:^1.1.1":
62876287
version: 1.1.1
62886288
resolution: "@protobufjs/eventemitter@npm:1.1.1"
62896289
checksum: 7f8cb422ebccf3e17fd7baf9a0b5cd7ddbe2e83bc44d0330aa48e45931806b7cfea68319a2025856c68f7376dc602f9e7b4fcbcfc369de2ce58d99a4a800e1ab
62906290
languageName: node
62916291
linkType: hard
62926292

6293-
"@protobufjs/fetch@npm:^1.1.0, @protobufjs/fetch@npm:^1.1.1":
6293+
"@protobufjs/fetch@npm:^1.1.1":
62946294
version: 1.1.1
62956295
resolution: "@protobufjs/fetch@npm:1.1.1"
62966296
dependencies:
@@ -6306,13 +6306,6 @@ __metadata:
63066306
languageName: node
63076307
linkType: hard
63086308

6309-
"@protobufjs/inquire@npm:^1.1.0":
6310-
version: 1.1.2
6311-
resolution: "@protobufjs/inquire@npm:1.1.2"
6312-
checksum: 6515cd6d884e16aa1f78df479f43860a492cf79450e0e8a35838da2a59d5fc08bd63f9a5daf752e7c4b0999f7ac6cdc44419a36f916af40cbf5831e8a8856949
6313-
languageName: node
6314-
linkType: hard
6315-
63166309
"@protobufjs/path@npm:^1.1.2":
63176310
version: 1.1.2
63186311
resolution: "@protobufjs/path@npm:1.1.2"
@@ -6327,7 +6320,7 @@ __metadata:
63276320
languageName: node
63286321
linkType: hard
63296322

6330-
"@protobufjs/utf8@npm:^1.1.0, @protobufjs/utf8@npm:^1.1.1":
6323+
"@protobufjs/utf8@npm:^1.1.1":
63316324
version: 1.1.1
63326325
resolution: "@protobufjs/utf8@npm:1.1.1"
63336326
checksum: 9352cf54a92219bd7eac9791c62f4d9abc27381a4b8d639e76ca33edb4813e6905c17ea1f894f4730ea1c6e99e69dac4484a661d6715193d88e90c1775df9fe9
@@ -22127,27 +22120,7 @@ __metadata:
2212722120
languageName: node
2212822121
linkType: hard
2212922122

22130-
"protobufjs@npm:7.2.6":
22131-
version: 7.2.6
22132-
resolution: "protobufjs@npm:7.2.6"
22133-
dependencies:
22134-
"@protobufjs/aspromise": ^1.1.2
22135-
"@protobufjs/base64": ^1.1.2
22136-
"@protobufjs/codegen": ^2.0.4
22137-
"@protobufjs/eventemitter": ^1.1.0
22138-
"@protobufjs/fetch": ^1.1.0
22139-
"@protobufjs/float": ^1.0.2
22140-
"@protobufjs/inquire": ^1.1.0
22141-
"@protobufjs/path": ^1.1.2
22142-
"@protobufjs/pool": ^1.1.0
22143-
"@protobufjs/utf8": ^1.1.0
22144-
"@types/node": ">=13.7.0"
22145-
long: ^5.0.0
22146-
checksum: 3c62e48f7d50017ac3b0dcd2a58e617cf858f9fba56a488bd48b9aa3482893a75540052dbcb3c12dfbaab42b1d04964611175faf06bdadcd33a4ebac982a511e
22147-
languageName: node
22148-
linkType: hard
22149-
22150-
"protobufjs@npm:^7.2.5, protobufjs@npm:^7.3.2, protobufjs@npm:^7.5.5":
22123+
"protobufjs@npm:7.6.4":
2215122124
version: 7.6.4
2215222125
resolution: "protobufjs@npm:7.6.4"
2215322126
dependencies:
@@ -22346,7 +22319,7 @@ __metadata:
2234622319
languageName: node
2234722320
linkType: hard
2234822321

22349-
"randombytes@npm:^2.0.0, randombytes@npm:^2.0.1, randombytes@npm:^2.0.5, randombytes@npm:^2.1.0":
22322+
"randombytes@npm:^2.0.0, randombytes@npm:^2.0.1, randombytes@npm:^2.0.5":
2235022323
version: 2.1.0
2235122324
resolution: "randombytes@npm:2.1.0"
2235222325
dependencies:
@@ -23528,12 +23501,10 @@ __metadata:
2352823501
languageName: node
2352923502
linkType: hard
2353023503

23531-
"serialize-javascript@npm:^6.0.0, serialize-javascript@npm:^6.0.2":
23532-
version: 6.0.2
23533-
resolution: "serialize-javascript@npm:6.0.2"
23534-
dependencies:
23535-
randombytes: ^2.1.0
23536-
checksum: c4839c6206c1d143c0f80763997a361310305751171dd95e4b57efee69b8f6edd8960a0b7fbfc45042aadff98b206d55428aee0dc276efe54f100899c7fa8ab7
23504+
"serialize-javascript@npm:^7.0.5":
23505+
version: 7.0.6
23506+
resolution: "serialize-javascript@npm:7.0.6"
23507+
checksum: c20a2546e3f28030dc68b92127d975d706c9cad73a455a120d9b604cb88c362ce2d767177385e2f231514cc3d42abd932f50a5b65e3b5f19251330c0314da684
2353723508
languageName: node
2353823509
linkType: hard
2353923510

0 commit comments

Comments
 (0)