Skip to content

Commit 73f4e8c

Browse files
fix(trufflehog): make bench metrics job non-blocking (#170)
Grafana Bench metrics export should not fail the overall workflow when the scan job already completed. Matches shared-workflows zizmor PR #1920.
1 parent a923482 commit 73f4e8c

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.github/workflows/reusable-trufflehog.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,7 @@ jobs:
388388
389389
grafana-bench:
390390
name: Send TruffleHog metrics to Prometheus via Grafana Bench
391+
continue-on-error: true
391392
needs: [trufflehog-scan]
392393
# Only run for grafana org and non-fork PRs (fork PRs have no OIDC/Vault access).
393394
if: ${{ github.repository_owner == 'grafana' && (github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork) && inputs.send-bench-metrics && always() && !cancelled() && (needs.trufflehog-scan.result == 'success' || needs.trufflehog-scan.result == 'failure') }}

0 commit comments

Comments
 (0)