Release v4.0.0 (#1329)

Author: sirosen

.flake8

@@ -8,5 +8,5 @@ per-file-ignores = *.pyi:E302,E305
 
 [flake8:local-plugins]
 extension =
-    SDK = _globus_sdk_flake8:Plugin
-paths = ./src/globus_sdk/
+    SDK = globus_sdk_flake8:Plugin
+paths = ./src/globus_sdk/_internal/extensions/

.github/workflows/test.yaml

@@ -80,8 +80,12 @@ jobs:
               - "pylint"
               - "test-lazy-imports"
               - "twine-check"
-            cache-paths:
-              - ".mypy_cache/"
+            # TODO: revisit caching strategy for '.mypy_cache'
+            # we believe a bad cache can be restored when the package changes,
+            # tricking 'mypy-test' into seeing an old version of the SDK
+            #
+            # cache-paths:
+            #   - ".mypy_cache/"
 
     uses: "globus/workflows/.github/workflows/tox.yaml@f41714f6a8b102569807b348fce50960f9617df8" # v1.2
     with:

Makefile

@@ -1,4 +1,4 @@
-SDK_VERSION=$(shell grep '^__version__' src/globus_sdk/version.py | cut -d '"' -f2)
+SDK_VERSION=$(shell grep '^version' pyproject.toml | head -n 1 | cut -d '"' -f2)
 
 # these are just tox invocations wrapped nicely for convenience
 .PHONY: lint test docs all-checks

RELEASING.md

@@ -18,7 +18,7 @@
 - Decide on the new version number and create a branch;
    `git checkout -b release-$SDK_VERSION`
 
-- Update the version in `src/globus_sdk/version.py`
+- Update the version in `pyproject.toml`
 
 - Update metadata and changelog, then verify changes in `changelog.rst`
 
@@ -28,7 +28,7 @@ $EDITOR changelog.rst
 ```
 
 - Add changed files;
-    `git add changelog.d/ changelog.rst src/globus_sdk/version.py`
+    `git add changelog.d/ changelog.rst pyproject.toml`
 
 - Commit; `git commit -m 'Bump version and changelog for release'`
 

changelog.d/check-version-is-new.py

@@ -6,24 +6,22 @@
 import re
 import sys
 
+if sys.version_info >= (3, 11):
+    import tomllib
+else:
+    # Older Python versions
+    import tomli as tomllib
+
 PATTERN_FORMAT = "^v{version}\\s+\\({date}\\)$"
 CHANGELOG_D = os.path.dirname(__file__)
 REPO_ROOT = os.path.dirname(CHANGELOG_D)
 
 
 def parse_version():
-    # single source of truth for package version
-    version_string = ""
-    version_pattern = re.compile(r'__version__ = "([^"]*)"')
-    with open(os.path.join(REPO_ROOT, "src", "globus_sdk", "version.py")) as f:
-        for line in f:
-            match = version_pattern.match(line)
-            if match:
-                version_string = match.group(1)
-                break
-    if not version_string:
-        raise RuntimeError("Failed to parse version information")
-    return version_string
+    with open(os.path.join(REPO_ROOT, "pyproject.toml"), "rb") as f:
+        pyproject = tomllib.load(f)
+
+    return pyproject["project"]["version"]
 
 
 def get_header_re(version):