|
| 1 | +# Contributing to ALBEDO |
| 2 | + |
| 3 | +Internal team collaboration guide for the ALBEDO platform. |
| 4 | + |
| 5 | +## Team |
| 6 | + |
| 7 | +| Role | Responsibilities | |
| 8 | +|---|---| |
| 9 | +| System Architect | Methodology design, source validation, final approval (Gerald Kombo) | |
| 10 | + |
| 11 | +## Git Workflow |
| 12 | + |
| 13 | +### Branch Naming |
| 14 | +``` |
| 15 | +type/ticket-number-short-description |
| 16 | +``` |
| 17 | + |
| 18 | +Types: `feature`, `bugfix`, `hotfix`, `refactor`, `docs` |
| 19 | + |
| 20 | +### Commit Messages |
| 21 | +``` |
| 22 | +type: subject #ticket |
| 23 | +``` |
| 24 | + |
| 25 | +Examples: |
| 26 | +- `feat: add KNCR PDF generation endpoint #101` |
| 27 | +- `fix: correct leakage deduction calculation #102` |
| 28 | + |
| 29 | +## Code Standards |
| 30 | + |
| 31 | +1. `declare(strict_types=1)` in all PHP files |
| 32 | +2. PSR-12 compliance (4 spaces, braces on same line) |
| 33 | +3. Type hints on all parameters and return types |
| 34 | +4. Keep controllers thin — business logic in Services |
| 35 | +5. All constants in `config/albedo.php` with source citations |
| 36 | + |
| 37 | +## Source Authority Protocol |
| 38 | + |
| 39 | +When adding new constants: |
| 40 | +1. Identify official source (Tier 1-5) |
| 41 | +2. Verify URL accessibility |
| 42 | +3. Extract exact value (no rounding) |
| 43 | +4. Add to `config/albedo.php` with source comment |
| 44 | +5. Create PR with source documentation |
| 45 | + |
| 46 | +## Database Rules |
| 47 | + |
| 48 | +1. Never modify existing migrations — create new ones |
| 49 | +2. Always include `down()` method |
| 50 | +3. Use foreign keys for referential integrity |
| 51 | +4. Index frequently queried columns |
| 52 | +5. Comment complex columns |
| 53 | + |
| 54 | +## Pull Request Checklist |
| 55 | + |
| 56 | +- [ ] PSR-12 compliant |
| 57 | +- [ ] `declare(strict_types=1)` included |
| 58 | +- [ ] Tests pass (`php artisan test`) |
| 59 | +- [ ] New constants have source citations |
| 60 | +- [ ] Migration includes `down()` method |
| 61 | +- [ ] No hardcoded values |
0 commit comments