Skip to content

Commit 7ce714a

Browse files
committed
fix(common): SC2181 — check defaults write exit code directly
1 parent 5142330 commit 7ce714a

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

common.sh

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -543,15 +543,17 @@ apply_audited_defaults() {
543543
fi
544544

545545
if [[ "${sudo_flag:-}" == "sudo" ]]; then
546-
sudo defaults write "$domain" "$key" "$type" "$new_val" 2>/dev/null
547-
else
548-
defaults write "$domain" "$key" "$type" "$new_val" 2>/dev/null
549-
fi
550-
551-
if [[ $? -eq 0 ]]; then
552-
log_ok "$label$new_val"
546+
if sudo defaults write "$domain" "$key" "$type" "$new_val" 2>/dev/null; then
547+
log_ok "$label$new_val"
548+
else
549+
log_err "Failed: $label"
550+
fi
553551
else
554-
log_err "Failed: $label"
552+
if defaults write "$domain" "$key" "$type" "$new_val" 2>/dev/null; then
553+
log_ok "$label$new_val"
554+
else
555+
log_err "Failed: $label"
556+
fi
555557
fi
556558
done
557559

0 commit comments

Comments
 (0)