Commit 2d5c116
authored
fix: address PR review findings (Bug 1-3 + sidebar minor)
Bug 1 (runtime_events.go): use msg.ConfigPath instead of
constructing 'budget.' + msg.Limit; named budget paths like
'budgets.tight.max_cost' now display correctly.
Bug 2 (types.go): MaxTime comment updated from 'wall-clock
duration' to 'working time — cumulative turn durations; idle
time does not count'.
Bug 3 (docs/configuration/budget/index.md): three occurrences
of 'wall-clock time' changed to 'working time' (front-matter
description, lede paragraph, and example heading).
Minor (sidebar.go): removed duplicate first comment block from
formatBudgetDuration.1 parent 3589dcd commit 2d5c116
4 files changed
Lines changed: 7 additions & 7 deletions
File tree
- docs/configuration/budget
- pkg
- config/latest
- tui
- components/sidebar
- page/chat
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
| 179 | + | |
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
92 | 94 | | |
93 | 95 | | |
94 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1866 | 1866 | | |
1867 | 1867 | | |
1868 | 1868 | | |
1869 | | - | |
1870 | | - | |
1871 | 1869 | | |
1872 | 1870 | | |
1873 | 1871 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
455 | | - | |
| 455 | + | |
456 | 456 | | |
457 | 457 | | |
458 | 458 | | |
| |||
0 commit comments