-
Notifications
You must be signed in to change notification settings - Fork 413
Expand file tree
/
Copy path.golangci.yml
More file actions
199 lines (199 loc) · 5.26 KB
/
Copy path.golangci.yml
File metadata and controls
199 lines (199 loc) · 5.26 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
version: "2"
run:
tests: true
linters:
enable:
- asasalint
- asciicheck
- bidichk
- containedctx
- copyloopvar
- decorder
- depguard
- dogsled
- durationcheck
- embeddedstructfieldcheck
- errcheck
- errname
- errorlint
- exptostd
- fatcontext
- forbidigo
- ginkgolinter
- gocheckcompilerdirectives
- godoclint
- gochecknoinits
- gochecksumtype
- gocritic
- gosec
- gomoddirectives
- gomodguard_v2
- goprintffuncname
- govet
- grouper
- iface
- importas # Enforces consistent import aliases.
- inamedparam
- ineffassign
- intrange
- iotamixing
- loggercheck
- misspell
- mirror
- modernize
- nakedret
- noctx
- nolintlint
- nosprintfhostport
- nilnesserr
- perfsprint
- predeclared
- reassign
- recvcheck
- revive
- rowserrcheck
- sloglint
- staticcheck
- testableexamples
- testifylint
- thelper
- unconvert
- unparam
- unused
- usestdlibvars
- unqueryvet
- usetesting
- whitespace
- wastedassign
- bodyclose
- makezero
- sqlclosecheck
settings:
forbidigo:
forbid:
- pattern: context\.Background()
msg: "do not use context.Background() in tests, use t.Context()"
- pattern: context\.TODO()
msg: "do not use context.TODO() in tests, use t.Context()"
- pattern: os\.MkdirTemp()
msg: "do not use os.MkdirTemp() in tests, use t.TempDir()"
- pattern: os\.Setenv()
msg: "do not use os.Setenv() in tests, use t.Setenv()"
- pattern: os\.Chdir()
msg: "do not use os.Chdir() in tests, use t.Chdir()"
- pattern: fmt\.Print.*()
msg: "do not use fmt.Print() or fmt.Println() in tests"
- pattern: time\.Sleep
msg: "do not sleep in tests: synchronize on channels/require.Eventually, or use fake time in a synctest bubble (nolint with a reason)"
depguard:
rules:
internal:
files:
- "**/*.go"
deny:
- pkg: github.com/docker/docker-agent/internal
desc: don't use /internal/ from /pkg/
old_yaml:
files:
- "**/*.go"
deny:
- pkg: gopkg.in/yaml.v3
desc: don't use deprecated gopkg.in/yaml.v3, use github.com/goccy/go-yaml instead
testify_is_for_tests:
files:
- "**/*.go"
- "!**/*_test.go"
deny:
- pkg: github.com/stretchr/testify
desc: don't use testify in production code
gomoddirectives:
replace-allow-list:
- github.com/charmbracelet/ultraviolet
- github.com/cyphar/filepath-securejoin
gocritic:
disabled-checks:
- dupImport
- hugeParam
- rangeValCopy
- unnamedResult
- appendAssign
enabled-tags:
- diagnostic
- style
- performance
revive:
rules:
- name: exported
arguments:
- checkPrivateReceivers
- name: package-comments
disabled: false
staticcheck:
checks:
- all
gosec:
excludes:
# Errors-unhandled is covered better by errcheck (already enabled);
# gosec's pattern matches many legitimate Close-on-error-path callsites.
- G104
# Hardcoded-credentials matches constant names like ToolNameLSPWorkspace*
# and intentionally-public client telemetry keys; portcullis covers real cases.
- G101
# Subprocess-with-variable: docker-agent intentionally launches user-configured
# commands (LSP servers, hooks, agents, editors).
- G204
# File-inclusion-via-variable: paths come from CLI flags, config, and validated
# destinations throughout the codebase.
- G304
# Weak-RNG: math/rand is used for jitter, model selection, spinner animations —
# never for security.
- G404
# Slice-bounds: false positive on dynamically-validated indices.
- G602
# Path-traversal/SSRF/command-injection taint analysis: paths, URLs, and
# commands are derived from validated config (resolveToolsetPath, configured
# OAuth providers, user-set $EDITOR/$VISUAL).
- G702
- G703
- G704
exclusions:
generated: lax
presets:
- comments
- std-error-handling
rules:
- path-except: _test\.go
linters:
- forbidigo
- path: _test\.go
linters:
- gosec
- path: pkg/model/provider/oaistream/
linters:
- staticcheck
text: "SA1019:.*FunctionCall.*deprecated"
# Vendored verbatim from moby/moby; keep its //nolint:gosec directives
# even though our config excludes gosec G404 globally.
- path: pkg/worktree/namesgenerator/
linters:
- nolintlint
issues:
max-same-issues: 3
formatters:
enable:
- gci
- gofmt
- gofumpt
settings:
gci:
custom-order: true
sections:
- standard
- default
- prefix(github.com/docker/docker-agent)
gofmt:
rewrite-rules:
- pattern: 'interface{}'
replacement: 'any'
gofumpt:
extra-rules: true