Skip to content

Commit e0bc134

Browse files
committed
Makes //:node_modules/@rules_prerender/declarative_shadow_dom private.
Refs #71. I accidentally used this target today when I actually wanted `//:prerender_components/@rules_prerender/declarative_shadow_dom`. There is not much use for the Node module and using it directly violates the expectation that all the various "slices" of the component stay together in a cohesive way. Limiting visibility makes it easier to catch this mistake in the future.
1 parent 46f5930 commit e0bc134

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

BUILD.bazel

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ types_only(
6161
npm_link_package(
6262
name = "node_modules/@rules_prerender/declarative_shadow_dom",
6363
src = "//packages/declarative_shadow_dom:pkg",
64-
visibility = ["//:__subpackages__"],
64+
# Should use `//:prerender_components/@rules_prerender/declarative_shadow_dom`.
65+
visibility = ["//visibility:private"],
6566
)
6667
link_prerender_component(
6768
name = "prerender_components/@rules_prerender/declarative_shadow_dom",

0 commit comments

Comments
 (0)