Commit 98afff8
committed
Removes
Running this on `prepare` is the best practice from Husky to avoid installing into consumer packages. That makes sense, but has two problems:
1. `prepare` runs on `npm publish`, meaning that `bazel run //:pkg.publish` also executes `husky install`, which then fails because `.git` isn't present in the sandbox (see this [release failure](https://github.com/dgp1130/rules_prerender/runs/3530314979?check_suite_focus=true)).
2. `prepare` runs on `npm install rules_prerender-*.tgz`. I can't confirm that this is actually intended behavior, but it effectively installs Husky into a consumer package, which is most annoying in the [`ref/external` branch](https://github.com/dgp1130/rules_prerender/tree/ref/external/) and needs to be worked around.
I'll try to figure out if there is a cleaner way to install Husky, otherwise maybe I'll just document that you have to do it manually?husky install from prepare script.1 parent 0cfe3b5 commit 98afff8
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
| 28 | + | |
30 | 29 | | |
31 | 30 | | |
32 | 31 | | |
| |||
0 commit comments