Restrict tool visibility to //tools/internal:__pkg__.

All published tools should be referenced via `//tools/internal:*`, because it provides the aliases and stubs that resolve the tools to different paths between HEAD builds and published builds.

Updated the `pkg_npm()` rule to use these internal references and also moved `//packages/renderer:renderer_js` to `//tools/internal/...` which was previously missed.

Author: dgp1130

BUILD.bazel

@@ -58,15 +58,15 @@ pkg_npm(
         # Merge all tools and files to publish all together into the directory.
         ":publish_files",
         "//common:publish_files",
-        "//packages/annotation_extractor",
-        "//packages/renderer",
         "//packages/renderer:publish_files",
-        "//packages/resource_injector",
-        "//packages/resource_packager",
         "//packages/rules_prerender",
         "//packages/rules_prerender:publish_files",
-        "//packages/script_entry_generator",
-        "//packages/style_entry_generator",
+        "//tools/internal:annotation_extractor",
+        "//tools/internal:renderer",
+        "//tools/internal:resource_injector",
+        "//tools/internal:resource_packager",
+        "//tools/internal:script_entry_generator",
+        "//tools/internal:style_entry_generator",
         "//tools/internal:publish_files",
     ],
 )

packages/annotation_extractor/BUILD.bazel

@@ -5,7 +5,7 @@ load("//tools:jasmine.bzl", "jasmine_node_test")
 nodejs_binary(
     name = "annotation_extractor",
     entry_point = "annotation_extractor.ts",
-    visibility = ["//visibility:public"],
+    visibility = ["//tools/internal:__pkg__"],
     templated_args = ["--bazel_patch_module_resolver"],
     data = [
         ":annotation_extractor_lib",

packages/renderer/BUILD.bazel

@@ -14,7 +14,7 @@ publish_files(
 ts_library(
     name = "renderer",
     srcs = ["renderer.ts"],
-    visibility = ["//visibility:public"],
+    visibility = ["//tools/internal:__pkg__"],
     deps = [
         ":entry_point",
         "//common:binary",
@@ -28,7 +28,7 @@ ts_library(
 filegroup(
     name = "renderer_js",
     srcs = [":renderer"],
-    visibility = ["//visibility:public"],
+    visibility = ["//tools/internal:__pkg__"],
     output_group = "es5_sources",
 )
 

packages/renderer/BUILD.publish

@@ -3,5 +3,5 @@ exports_files(glob(["**/*.bzl"]), visibility = ["//visibility:public"])
 filegroup(
     name = "renderer_js",
     srcs = ["renderer.js"],
-    visibility = ["//visibility:public"],
+    visibility = ["//tools/internal:__pkg__"],
 )

packages/resource_injector/BUILD.bazel

@@ -5,12 +5,12 @@ load("//tools:jasmine.bzl", "jasmine_node_test")
 nodejs_binary(
     name = "resource_injector",
     entry_point = "resource_injector.ts",
+    visibility = ["//tools/internal:__pkg__"],
     templated_args = ["--bazel_patch_module_resolver"],
     data = [
         ":resource_injector_lib",
         "@npm//yargs",
     ],
-    visibility = ["//visibility:public"],
 )
 
 ts_library(

packages/resource_packager/BUILD.bazel

@@ -5,8 +5,8 @@ load("//tools:jasmine.bzl", "jasmine_node_test")
 nodejs_binary(
     name = "resource_packager",
     entry_point = ":resource_packager.ts",
+    visibility = ["//tools/internal:__pkg__"],
     templated_args = ["--bazel_patch_module_resolver"],
-    visibility = ["//visibility:public"],
     data = [
         ":resource_packager_lib",
         "@npm//yargs",

packages/rules_prerender/prerender_multi_page.bzl

@@ -99,7 +99,7 @@ def prerender_multi_page(
     binary = "%s_binary" % name
     nodejs_binary(
         name = binary,
-        entry_point = "//packages/renderer:renderer_js",
+        entry_point = "//tools/internal:renderer_js",
         templated_args = ["--bazel_patch_module_resolver"],
         testonly = testonly,
         data = RENDERER_RUNTIME_DEPS + [

packages/script_entry_generator/BUILD.bazel

@@ -5,12 +5,12 @@ load("//tools:jasmine.bzl", "jasmine_node_test")
 nodejs_binary(
     name = "script_entry_generator",
     entry_point = ":script_entry_generator.ts",
+    visibility = ["//tools/internal:__pkg__"],
     templated_args = ["--bazel_patch_module_resolver"],
     data = [
         ":script_entry_generator_lib",
         "@npm//yargs",
     ],
-    visibility = ["//visibility:public"],
 )
 
 ts_library(

packages/style_entry_generator/BUILD.bazel

@@ -5,12 +5,12 @@ load("//tools:jasmine.bzl", "jasmine_node_test")
 nodejs_binary(
     name = "style_entry_generator",
     entry_point = ":style_entry_generator.ts",
+    visibility = ["//tools/internal:__pkg__"],
     templated_args = ["--bazel_patch_module_resolver"],
     data = [
         ":style_entry_generator_lib",
         "@npm//yargs",
     ],
-    visibility = ["//visibility:public"],
 )
 
 ts_library(

tools/internal/BUILD.bazel

@@ -36,6 +36,11 @@ alias(
     actual = "//packages/renderer",
 )
 
+alias(
+    name = "renderer_js",
+    actual = "//packages/renderer:renderer_js",
+)
+
 alias(
     name = "resource_injector",
     actual = "//packages/resource_injector",