Skip to content

Commit ddd05f1

Browse files
authored
Merge pull request #43 from crisanlucid/chore/update-readme-and-workflow-comments
docs: update README release flow and workflow comments
2 parents aa47ee9 + 8f8e868 commit ddd05f1

2 files changed

Lines changed: 21 additions & 31 deletions

File tree

.github/workflows/bump-version.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Manually triggered version bump.
2-
# Bumps package.json + package-lock.json, opens a PR to merge into main,
3-
# then pushes the tag (triggers create-release.yml).
2+
# Bumps package.json + package-lock.json, pushes the tag, and opens a PR.
3+
# Merging the PR triggers create-release.yml to create the GitHub Release.
44

55
name: Bump version
66

@@ -52,5 +52,5 @@ jobs:
5252
env:
5353
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5454

55-
- name: Push tag (triggers create-release workflow)
55+
- name: Push tag
5656
run: git push origin --tags

README.md

Lines changed: 18 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,8 @@ vite-react-tailwind-bionic-reading project
1717

1818
### How to Run
1919

20-
```
21-
npm i && npm dev
22-
```
23-
or
24-
```
25-
yarn && yarn dev
20+
```bash
21+
npm install && npm run dev
2622
```
2723

2824
## PDF functionality
@@ -54,37 +50,31 @@ git push origin feature/my-feature
5450

5551
### 2. Open a Pull Request → merge into `main`
5652

57-
- Open a PR on GitHub targeting `main`
58-
- Merging triggers automatically:
59-
- **Node.js CI** — installs deps + builds
60-
- **Build and Deploy** — deploys to GitHub Pages
53+
Opening a PR triggers:
54+
- **Node.js CI** — installs deps, builds, runs tests
55+
- **CodeQL** — security scan
56+
57+
Merging into `main` additionally triggers:
58+
- **Build and Deploy** — deploys to GitHub Pages (only when source files change)
6159

6260
### 3. Bump the version
6361

6462
Go to **Actions → Bump version → Run workflow** and choose:
65-
- `patch` → bug fixes / small improvements (0.4.0 → 0.4.1)
66-
- `minor` → new features, backwards compatible (0.4.0 → 0.5.0)
67-
- `major` → breaking changes (0.4.0 → 1.0.0)
63+
- `patch` → bug fixes / small improvements (0.5.0 → 0.5.1)
64+
- `minor` → new features, backwards compatible (0.5.0 → 0.6.0)
65+
- `major` → breaking changes (0.5.0 → 1.0.0)
6866

6967
This workflow will:
70-
- Bump `package.json` version
71-
- Create and push a git tag (e.g. `v0.4.1`)
72-
- Open a PR to merge the version bump back into `main`
68+
- Bump `package.json` + `package-lock.json` version
69+
- Create a git tag (e.g. `v0.6.0`) and push it
70+
- Open a PR named `chore: bump version to vX.X.X`
7371

7472
### 4. Merge the version bump PR
7573

76-
A PR named `chore: bump version to vX.X.X` will be opened automatically — merge it into `main`.
77-
78-
### 5. Trigger the release manually
79-
80-
Because `main` is protected, the tag push won't auto-trigger the release workflow.
81-
82-
Go to **Actions → Create Release → Run workflow**.
83-
84-
This will:
85-
- Build the project
86-
- Publish to npm
87-
- Create a GitHub Release with auto-generated notes
74+
Merge the `chore: bump version to vX.X.X` PR into `main`. This automatically:
75+
- Runs CI (install, build, test)
76+
- Deploys to GitHub Pages
77+
- **Creates a GitHub Release** with auto-generated notes
8878

8979
---
9080

0 commit comments

Comments
 (0)