Skip to content

Commit 43ed7a1

Browse files
committed
chore(parser): remove IterInput TODOs
After testing, `IterInput` seems to be somehow significantly slower than `MappedInput` with a slice
1 parent ddb1e68 commit 43ed7a1

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

src/parser.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,6 @@ macro_rules! parse_with {
189189
let src = $src.with_context(FileID::SRC);
190190
|| -> Result<_, ParseError> {
191191
let tokens = lexer::lexer($comment_prefix).parse(src).into_result()?;
192-
// TODO: replace with `chumsky::input::IterInput` on chumsky 0.10.2 (on 0.10.1 it
193-
// doesn't implement the correct traits)
194192
let tokens = tokens.map(end, |(x, s)| (x, s));
195193
let res = $parser.parse(tokens).into_result()?;
196194
Ok(res)

src/parser/instruction.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ pub type ParsedArgs = Vec<ParsedArgument>;
4747
/// Input type to be used with instruction argument parsers
4848
// NOTE: we need to name this input type to be able to box the parsers, which is required to store
4949
// them on a struct
50-
// TODO: replace with `chumsky::input::IterInput` on chumsky 0.10.2 (on 0.10.1 it doesn't implement
51-
// the correct traits)
5250
type TokenInput<'src> =
5351
MappedInput<Token, Span, &'src [Spanned<Token>], fn(&Spanned<Token>) -> (&Token, &Span)>;
5452

0 commit comments

Comments
 (0)