Skip to content

Commit c7dd352

Browse files
Drop personal name and dollar value from comments
Three inline comments contained a partner first name; one of them also recorded a confirmed-value dollar figure on the Grants council_engaged action. The conversion value already moved to a wrangler secret in the previous deploy, so the figure was stale. The placeholder-skip sentinel string in the CAPI client is renamed to a generic TODO_PENDING. No logic change.
1 parent 5603a5c commit c7dd352

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

client/src/utils/public/gclidCapture.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export type ConversionEvent = 'profile_created' | 'start_exploring' | 'mode_sele
6767

6868
// Council Engaged fires once a visitor has heard this many seconds of council
6969
// audio (curated or custom), measured as audio actually played. One number,
70-
// shared by both council players. Tunable per Jakub's input.
70+
// shared by both council players.
7171
export const COUNCIL_ENGAGED_THRESHOLD_S = 60;
7272

7373
/**

workers/llm-proxy/src/services/googleAdsCapi.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,8 @@ const ACCOUNTS: Record<AccountKey, AccountConfig> = {
4747
profile_created: '7608272394', // gtag label 2t5rCIqM9KscELfN0stD
4848
start_exploring: '7609132235', // gtag label n70GCMvJqKwcELfN0stD
4949
mode_selected: '7609132238', // gtag label 4AWSCM7JqKwcELfN0stD
50-
// Reusing the existing Session>60s action (gtag label
51-
// jjIcCOmB9KscELfN0stD), renamed to Council Engaged by Jakub on
52-
// 2026-05-20. Value $4 confirmed.
50+
// The Session>60s action was renamed to Council Engaged on
51+
// 2026-05-20 (gtag label jjIcCOmB9KscELfN0stD).
5352
council_engaged: '7608271081',
5453
},
5554
},
@@ -216,7 +215,7 @@ async function uploadToAccount(
216215

217216
// A conversion action still on a placeholder ID (not yet set up in Google
218217
// Ads) is skipped, rather than sent with an invalid resource name.
219-
if (actionId === 'TODO_FROM_JAKUB') {
218+
if (actionId === 'TODO_PENDING') {
220219
console.log(`[capi] ${accountKey} ${input.event} skipped: action id pending`);
221220
return;
222221
}

0 commit comments

Comments
 (0)